Serve a trusted holder from a runtime of its own account, refuse it in the machine's runtime, and say while an agent can become root where it runs (hq ADR 0259 §8)

2026-10-09 13:48:56 +02:00
parent c9be75b13e
commit 9372e80cec
18 changed files with 747 additions and 25 deletions
@@ -0,0 +1,60 @@
+package main
+
+import (
+	"strings"
+	"testing"
+
+	"github.com/novox/mesh-controller/internal/conditions"
+)
+
+// novox/hq ADR 0259 §8, rule 3: the probe fails today — agents run as the operator's account, which has
+// passwordless sudo, and the login shell runs their commands as it — and passes only once neither holds.
+func TestAnAgentAbleToBecomeRootWhereTheRouterRunsIsSaid(t *testing.T) {
+	root := escalation{Root: true, Why: "(ALL : ALL) NOPASSWD: ALL"}
+	none := escalation{Why: "no rule lets it without a password"}
+	base := func() agentRootFacts {
+		return agentRootFacts{Machine: "anchor", Trusted: []string{"telegram", "messenger"}, Runtime: "ops",
+			Answers: map[string]escalation{}}
+	}
+
+	today := base()
+	today.Agent, today.LoginShell = "ops", true
+	today.Answers["ops"] = root
+	got := agentRootObservations(today)
+	if len(got) != 1 || got[0].Severity != conditions.Urgent || got[0].Kind != kindAgentRoot ||
+		!strings.Contains(got[0].Summary, "the operator's account") || !strings.Contains(got[0].Summary, "the login shell") {
+		t.Fatalf("today: %+v", got)
+	}
+
+	agentsMoved := base()
+	agentsMoved.Agent, agentsMoved.AgentNamed, agentsMoved.LoginShell = "agents", true, true
+	agentsMoved.Answers["agents"], agentsMoved.Answers["ops"] = none, root
+	if got := agentRootObservations(agentsMoved); len(got) != 1 || strings.Contains(got[0].Summary, "agents (") ||
+		!strings.Contains(got[0].Summary, "the login shell") {
+		t.Errorf("agents of their own account, the login shell still the runtime's: %+v", got)
+	}
+
+	closed := base()
+	closed.Agent, closed.AgentNamed = "agents", true
+	closed.Answers["agents"], closed.Answers["ops"] = none, root
+	if got := agentRootObservations(closed); len(got) != 0 {
+		t.Errorf("agents of their own account and no login shell there: %+v", got)
+	}
+
+	noAgents := base()
+	noAgents.Answers["ops"] = root
+	if got := agentRootObservations(noAgents); len(got) != 0 {
+		t.Errorf("no agent runs there and no login shell is held: %+v", got)
+	}
+}
+
+// Its words are plain, as every condition's are (novox/hq ADR 0253).
+func TestTheRootConditionIsSaidInPlainWords(t *testing.T) {
+	f := agentRootFacts{Machine: "anchor", Trusted: []string{"telegram"}, Runtime: "ops", Agent: "ops",
+		Answers: map[string]escalation{"ops": {Root: true, Why: "x"}}}
+	o := agentRootObservations(f)[0]
+	if why, ok := conditions.PlainWords(conditions.Words{Headline: o.Headline, Explanation: o.Explanation,
+		Needs: o.Needs, Resolved: o.Resolved}, "anchor"); !ok {
+		t.Errorf("not plain: %s", why)
+	}
+}