Delete vendor/ and the route proxy's: the build module fetches the modules, the root image builds with -mod=mod (issue 1305, C6)

internal/lint/removed_test.go

@@ -20,3 +20,24 @@ func TestTheRepositoryHoldsNoMergeCheckScript(t *testing.T) {
 		}
 	}
 }
+
+// No module of this repository keeps a copy of its dependencies (issue 1305): the build module fetches them, and
+// `go build ./...` with GOFLAGS=-mod=mod is how every build reads them.
+func TestTheRepositoryHoldsNoVendorDirectory(t *testing.T) {
+	err := filepath.WalkDir(root, func(path string, d os.DirEntry, err error) error {
+		if err != nil {
+			return err
+		}
+		if d.IsDir() && d.Name() == ".git" {
+			return filepath.SkipDir
+		}
+		if d.IsDir() && d.Name() == "vendor" {
+			t.Errorf("%s is a vendor directory: dependencies are fetched, never kept (issue 1305)", path)
+			return filepath.SkipDir
+		}
+		return nil
+	})
+	if err != nil {
+		t.Fatal(err)
+	}
+}

internal/testbus/testbus_test.go

@@ -22,7 +22,7 @@ func TestTheBusTheTestsRunIsTheBusTheMeshRuns(t *testing.T) {
 	release, from := catalogueBusRelease(t, filepath.Join(beside.Catalogue(t), "nats"))
 	if release != Version {
 		t.Errorf("the tests run bus %s and the catalogue's bus image is %s (%s): move go.mod's nats-server pin "+
-			"(and `go mod vendor`) with the image", Version, release, from)
+			"with the image", Version, release, from)
 	}
 	path := os.Getenv("MESH_FACTS")
 	if path == "" {