issue 974: review 1: a verb's end, a provisioner client's word and a failed key read each ask or retry a look; the silent bucket ages; the acceptance test starts the rollout through the serving wiring

cmd/mesh-controller/plan_looks_test.go

@@ -2,6 +2,7 @@ package main
 
 import (
 	"context"
+	"errors"
 	"sync/atomic"
 	"testing"
 	"time"
@@ -257,3 +258,60 @@ func TestAnExpiredSilentKeyAsksForALookAndAReportsDeleteDoesNot(t *testing.T) {
 	}
 	eventually(t, "the expiry asks for a look", func() bool { return looks.Load() == 1 })
 }
+
+// A provisioner client's word on a module's files asks for a look, as a send that handed it modules is applied only
+// once it has said so (issue 974, review 1): no walk waits for its silent key for what the client already said.
+func TestAProvisionerClientsWordAsksForALook(t *testing.T) {
+	js, err := broker.Dial(testbus.URL(t))
+	if err != nil {
+		t.Fatal(err)
+	}
+	t.Cleanup(js.Close)
+	if err := broker.AssertMeshStreams(js); err != nil {
+		t.Fatal(err)
+	}
+	var failures, looks atomic.Int32
+	l := lookerCounting(&failures, &looks, nil)
+	lookerMu.Lock()
+	theLooker = l
+	lookerMu.Unlock()
+	t.Cleanup(func() { lookerMu.Lock(); theLooker = nil; lookerMu.Unlock() })
+	ctx, stop := context.WithCancel(context.Background())
+	defer stop()
+	go l.run(ctx)
+	if err := startProvAppliedLooks(ctx, js); err != nil {
+		t.Fatal(err)
+	}
+	legacy, err := js.Conn().JetStream()
+	if err != nil {
+		t.Fatal(err)
+	}
+	if _, err := legacy.Publish(broker.ProvisionerAppliedSubject("ace", "plex"), []byte(`{"status":"applied"}`)); err != nil {
+		t.Fatal(err)
+	}
+	eventually(t, "a look on the client's word", func() bool { return looks.Load() >= 1 })
+}
+
+type brokenClock struct{ silentClock }
+
+func (brokenClock) Held(context.Context) (map[silentWait]time.Time, error) {
+	return nil, errors.New("the bus is down")
+}
+
+// A bus that will not say which keys it holds does not leave the waits unwatched: each is looked at by a timer of its own
+// and the error is given back, so the look is marked failed and retried (issue 974, review 1).
+func TestKeysThatCannotBeReadAreWatchedByTimersAndTheLookFails(t *testing.T) {
+	w := silentWait{Plan: "plan-held", Tier: 0, Node: "ace"}
+	sent := time.Now().UTC()
+	t.Cleanup(func() { silentTimers.mu.Lock(); delete(silentTimers.timers, w); silentTimers.mu.Unlock() })
+	err := keepSilentKeys(t.Context(), brokenClock{}, map[silentWait]time.Time{w: sent}, sent)
+	if err == nil {
+		t.Fatal("no error given back")
+	}
+	silentTimers.mu.Lock()
+	armed := silentTimers.timers[w].Equal(sent)
+	silentTimers.mu.Unlock()
+	if !armed {
+		t.Error("no timer of its own watches the wait")
+	}
+}