Take mesh-sdk at 86f9a1a5 and name each node's bucket with its FileBucketFor, refusing a node name that could carry a wildcard (issues 1696, 1697; ADR 0488)

cmd/mesh-controller/declaration_files.go

@@ -159,14 +159,18 @@ func openBucket(ctx context.Context, conn *nats.Conn, node string) (busObjects,
 	if err != nil {
 		return busObjects{}, err
 	}
-	store, err := js.ObjectStore(ctx, broker.DeclarationFilesBucketOf(node))
+	bucket, err := broker.DeclarationFilesBucketOf(node)
+	if err != nil {
+		return busObjects{}, fmt.Errorf("the object bucket of node %q: %w", node, err)
+	}
+	store, err := js.ObjectStore(ctx, bucket)
 	if errors.Is(err, jetstream.ErrBucketNotFound) {
 		if err = broker.EnsureDeclarationFiles(ctx, js, node); err == nil {
-			store, err = js.ObjectStore(ctx, broker.DeclarationFilesBucketOf(node))
+			store, err = js.ObjectStore(ctx, bucket)
 		}
 	}
 	if err != nil {
-		return busObjects{}, fmt.Errorf("the object bucket %s: %w", broker.DeclarationFilesBucketOf(node), err)
+		return busObjects{}, fmt.Errorf("the object bucket %s: %w", bucket, err)
 	}
 	return busObjects{store}, nil
 }

cmd/mesh-controller/declaration_files_integration_test.go

@@ -105,7 +105,11 @@ func TestADeclarationOfMoreThanThreeMiBIsSentByReferenceOnARealBus(t *testing.T)
 	if err != nil || len(named) != 3 {
 		t.Fatalf("what the latest declaration names: %v %v", named, err)
 	}
-	store, err := api.ObjectStore(ctx, broker.DeclarationFilesBucketOf("novox"))
+	novoxBucket, err := broker.DeclarationFilesBucketOf("novox")
+	if err != nil {
+		t.Fatal(err)
+	}
+	store, err := api.ObjectStore(ctx, novoxBucket)
 	if err != nil {
 		t.Fatal(err)
 	}

cmd/mesh-controller/declaration_sweep.go

@@ -247,7 +247,11 @@ func sweepNode(ctx context.Context, conn *nats.Conn, node string) (filesSweep, e
 	if err != nil {
 		return filesSweep{}, err
 	}
-	store, err := js.ObjectStore(working, broker.DeclarationFilesBucketOf(node))
+	bucket, err := broker.DeclarationFilesBucketOf(node)
+	if err != nil {
+		return filesSweep{}, fmt.Errorf("the bucket of node %q: %w", node, err)
+	}
+	store, err := js.ObjectStore(working, bucket)
 	if errors.Is(err, jetstream.ErrBucketNotFound) {
 		return filesSweep{}, nil // a node never sent a reference has no bucket yet
 	}