A group member's own check runs its repository's check alone, a cycle fails the composed check, and mark-ready leaves the delivery seat (issue 977, part D, ADR 0403)

internal/catalogue/delivery_seat.go

@@ -84,15 +84,6 @@ func deliveryVerbs() []Verb {
 				"dry":        "\"true\": what it would retire, changing nothing"}, []string{"why"}, "dry"),
 			// Added after the seat's holder shipped (novox/hq issue 313): optional until mesh-delivery serves it.
 			Optional: true},
-		{Name: "mark-ready", Description: "A reviewer's word that a delivery's head is approved: the holder puts the " +
-			"label mesh/ready on its pull request and then writes \"ready at <head>\", the order the forge counts, " +
-			"as the mesh's own forge account, naming who reviewed it and why. Refused when the delivery's commit is " +
-			"no longer its pull request's head. mesh-delivery then merges it once its checks pass (novox/hq ADR 0364).",
-			Input: schema(map[string]string{"id": "the delivery's id (owner/repository@commit): the head reviewed",
-				"reviewed-by": "who reviewed it, as who@node", "why": "the review's verdict in a line"},
-				[]string{"id", "reviewed-by", "why"}),
-			// Added after the seat's holder shipped (novox/hq issue 913): optional until mesh-delivery serves it.
-			Optional: true},
 	}
 }
 

internal/catalogue/delivery_seat_test.go

@@ -133,32 +133,3 @@ func TestTheDeliverySeatPromisesTimesOptionally(t *testing.T) {
 		t.Fatalf("a holder serving times: %v", err)
 	}
 }
-
-// The seat marks a reviewed head ready (novox/hq issue 913): `mark-ready`, with the delivery's id, who reviewed it
-// and why, so a reviewer marks a pull request through one audited verb, label and comment in the order the forge
-// counts, instead of two raw forge calls. Added after the holder shipped, it is optional.
-func TestTheDeliverySeatPromisesMarkReadyOptionally(t *testing.T) {
-	seat, _ := SeatNamed(DeliverySeat)
-	var mark *Verb
-	for i := range seat.Serves {
-		if seat.Serves[i].Name == "mark-ready" {
-			mark = &seat.Serves[i]
-		}
-	}
-	if mark == nil || !mark.Optional {
-		t.Fatalf("the delivery seat promises %v, mark-ready optionally", VerbNames(seat.Serves))
-	}
-	if req, _ := mark.Input["required"].([]string); !reflect.DeepEqual(req, []string{"id", "reviewed-by", "why"}) {
-		t.Errorf("mark-ready requires %v, wanted id, reviewed-by and why", req)
-	}
-	var without []string
-	for _, v := range VerbNames(seat.Serves) {
-		if v != "mark-ready" {
-			without = append(without, v)
-		}
-	}
-	m := Manifest{Module: "mesh-delivery", Claims: []Claim{{Name: DeliverySeat, Scope: ScopeMesh, Serves: without}}}
-	if err := CanHold(m, seat); err != nil {
-		t.Fatalf("a holder without mark-ready yet: %v", err)
-	}
-}

internal/link/build.go

@@ -150,6 +150,9 @@ type CheckRequest struct {
 	Trunk string `json:"trunk,omitempty"`
 	// Ready says the pull request is marked ready (ADR 0406 §3): its check is queued before every other check.
 	Ready bool `json:"ready,omitempty"`
+	// Composed says the pull request is a member of a delivery group whose gate is the composed check's (novox/hq ADR
+	// 0403 clause 1): this check runs the repository's own merge-check.sh alone, and its gate layer is not run.
+	Composed bool `json:"composed,omitempty"`
 	// Paths are the files the pull request changes, for the width of its rebuild.
 	Paths []string `json:"paths,omitempty"`
 	// Beside are the repositories the check reads next to this one, each cloned at the ref given — the

internal/link/events.go

@@ -294,8 +294,9 @@ type Checked struct {
 	// and send, posted with the verdict.
 	Plan *ChangePlan `json:"plan,omitempty"`
 	// Group is set on a delivery group's composed check (novox/hq ADR 0239): every member's head composed
-	// together as one future state. Members are the heads judged. A forge's holder sets no merge-gate
-	// status from it — the group's verdict is its owner's, mesh-delivery, to say on each member's head.
+	// together as one future state. Members are the heads judged, each with the trunk commit it was merged into. **The
+	// forge's holder sets every member's mesh/merge-gate from it** (novox/hq ADR 0403 clauses 1 and 5): the group's
+	// verdict is each member's gate, and a member's own verdict, whose gate layer is "composed", sets none.
 	Group   string          `json:"group,omitempty"`
 	Members []CheckedMember `json:"members,omitempty"`
 	// Trunk is the trunk commit the head was merged into and judged as, twelve characters (novox/hq ADR 0323