The store's mirror of the assignments may not write while they are switching or moved, asked before every write (issue 1093)

Review round 2. The writer's leave to write is the lease's and AssignmentsMirrorMayWrite, a flag set before the settle of the assignments' switch, kept after the commit and cleared only if the switch fails, so a pass that read its source before the switch lays and purges nothing after it.

internal/inventory/chain.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"fmt"
 	"sync"
+	"sync/atomic"
 
 	"github.com/jackc/pgx/v5"
 	"github.com/jackc/pgx/v5/pgconn"
@@ -41,6 +42,18 @@ type movedKinds struct {
 	// is not saved yet.
 	view    *rolloutView
 	pending map[string]pendingMerge
+	// switching is set when the assignments begin to be switched to the bus and kept once they are: the store's mirror of
+	// them writes nothing from then on (AssignmentsMirrorMayWrite). Cleared only if the switch fails.
+	switching atomic.Bool
+}
+
+// AssignmentsMirrorMayWrite says the store's mirror of the assignments may still write the bucket: the assignments are
+// neither being switched to the bus nor on it. Asked before every write of the mirror's writer, not once a pass.
+func (i *Inventory) AssignmentsMirrorMayWrite() bool {
+	i.moved.mu.Lock()
+	moved := i.moved.kind[KindAssignments]
+	i.moved.mu.Unlock()
+	return !moved && !i.moved.switching.Load()
 }
 
 // ChainOpener opens the chain on the bus when a process first needs it: a command that reads and never moved anything has
@@ -124,3 +137,13 @@ func (i *Inventory) ChainMoved(ctx context.Context) (map[string]int, error) {
 	}
 	return counts, err
 }
+
+// NewForTest is an inventory with no store, for a test of what needs none.
+func NewForTest() *Inventory { return &Inventory{moved: &movedKinds{}} }
+
+// BeginSwitchForTest sets the flag a kind's switch sets, as a switch under way does.
+func (i *Inventory) BeginSwitchForTest(kind string) {
+	if kind == KindAssignments {
+		i.moved.switching.Store(true)
+	}
+}

internal/inventory/chain_move.go

@@ -437,6 +437,7 @@ func (i *Inventory) moveKind(ctx context.Context, m mover, say func(string, ...a
 // switchKind records the kind as moved, in one transaction that holds the tables against writes and finds their count
 // as the move read it: false when they took a row since.
 func (i *Inventory) switchKind(ctx context.Context, m mover, r MoveReport) (bool, error) {
+	committed := false
 	tx, err := i.store.Pool().Begin(ctx)
 	if err != nil {
 		return false, err
@@ -452,6 +453,16 @@ func (i *Inventory) switchKind(ctx context.Context, m mover, r MoveReport) (bool
 	if n != r.TableRows {
 		return false, nil
 	}
+	// The store's mirror of the assignments writes nothing from here: it would lay values without the links over the keys
+	// the settle writes and end the ones it ended.
+	if m.kind == KindAssignments {
+		i.moved.switching.Store(true)
+		defer func() {
+			if !committed {
+				i.moved.switching.Store(false)
+			}
+		}()
+	}
 	// The rows read again under the lock: nothing writes them now, so what the bucket holds is made what they say.
 	rows, tableRows, err := m.rows(ctx)
 	if err != nil {
@@ -475,6 +486,7 @@ func (i *Inventory) switchKind(ctx context.Context, m mover, r MoveReport) (bool
 	if err := tx.Commit(ctx); err != nil {
 		return false, err
 	}
+	committed = true
 	i.moved.mu.Lock()
 	if i.moved.kind == nil {
 		i.moved.kind = map[string]bool{}