Remove the release-branch judge from the controller, the wire and the build seat (issue 977, part A, ADR 0401)
This commit is contained in:
+1
-17
@@ -173,12 +173,6 @@ type CheckRequest struct {
|
||||
// the controller, judged by itself; JudgeValidator for a change to the node-engine, judged by the
|
||||
// running controller built with the change's validator in place of the one it vendors.
|
||||
Judge string `json:"judge,omitempty"`
|
||||
// Release is the release branch the pull request merges into (novox/hq ADR 0358): its base, when that is not its
|
||||
// repository's trunk and mesh-controller has a branch of that name. The gate is then judged by the controller
|
||||
// built from mesh-controller's release branch — a change to the controller still by itself, a change to the
|
||||
// node-engine with its own validator — and each repository beside it is read at its branch of that name where it
|
||||
// has one (CheckedOut.Else otherwise). Empty for every other base, checked as before it.
|
||||
Release string `json:"release,omitempty"`
|
||||
// Siblings are the other open pull requests of this one's delivery group the check reads beside it (novox/hq ADR
|
||||
// 0382 §1): each repository found under Dir is read at the sibling's head merged onto the sibling's base, in
|
||||
// place of the commit the mesh runs. SiblingsUnknown says mesh-delivery could not be asked, or answered without
|
||||
@@ -299,10 +293,6 @@ const (
|
||||
type CheckedOut struct {
|
||||
Repository string `json:"repository"`
|
||||
Ref string `json:"ref,omitempty"`
|
||||
// Else is the ref read when the repository has no branch Ref (novox/hq ADR 0358 §3): beside a check of a pull
|
||||
// request into a release branch, Ref is that branch and Else the repository's trunk. Empty: Ref is read, or the
|
||||
// check cannot run.
|
||||
Else string `json:"else,omitempty"`
|
||||
}
|
||||
|
||||
// CheckOutcome is a merge check's verdict.
|
||||
@@ -327,13 +317,7 @@ type CheckOutcome struct {
|
||||
Members []CheckedMember `json:"members,omitempty"`
|
||||
// Built are the builds it made for its merge (novox/hq ADR 0350 §1).
|
||||
Built []CheckBuilt `json:"built,omitempty"`
|
||||
// Release is the release branch the check was judged for (novox/hq ADR 0358 §4), JudgedBy the commit of the
|
||||
// controller that judged its gate, as twelve characters, and BesideAt the branch each repository beside it was
|
||||
// read at, by directory. Empty from a check of any other base, and from a build seat from before it.
|
||||
Release string `json:"release,omitempty"`
|
||||
JudgedBy string `json:"judged-by,omitempty"`
|
||||
BesideAt map[string]string `json:"beside-at,omitempty"`
|
||||
// Validator says which node-engine validator the judge of a release-branch check was built with (ADR 0358 §2).
|
||||
// Validator says which node-engine validator the group's judge was built with (ADR 0382 §3).
|
||||
Validator string `json:"validator,omitempty"`
|
||||
// Siblings are the pull requests of its delivery group it read beside it, each as its head merged onto its base
|
||||
// commit (ADR 0382 §4), SiblingsUnknown why it could not learn them, and JudgeFrom where the judge came from when
|
||||
|
||||
@@ -307,13 +307,7 @@ type Checked struct {
|
||||
Trunk string `json:"trunk,omitempty"`
|
||||
Beside map[string]string `json:"beside,omitempty"`
|
||||
Took string `json:"took,omitempty"`
|
||||
// Release is the release branch the check judged for (novox/hq ADR 0358 §4), JudgedBy the commit of the
|
||||
// controller that judged its gate (twelve characters), and BesideAt the branch each repository beside it was
|
||||
// read at, by directory: so a reader sees a release-branch judgement apart from a trunk one. Empty otherwise.
|
||||
Release string `json:"release,omitempty"`
|
||||
JudgedBy string `json:"judged-by,omitempty"`
|
||||
BesideAt map[string]string `json:"beside-at,omitempty"`
|
||||
// Validator says which node-engine validator the judge of a release-branch check was built with (ADR 0358 §2).
|
||||
// Validator says which node-engine validator the group's judge was built with (ADR 0382 §3).
|
||||
Validator string `json:"validator,omitempty"`
|
||||
// Siblings are the other pull requests of the delivery group the check read beside it (novox/hq ADR 0382 §4), each
|
||||
// with its head and the base commit it was merged onto; SiblingsUnknown is why it could not learn them, set only
|
||||
|
||||
Reference in New Issue
Block a user