Let a requirement be optional, binding only a provider that already runs (hq issue 166, ADR 0330)

Making every soft dependency a provision made it hard: a mesh without influxdb could not assign
grafana, and one with influxdb in its catalogue would install it for grafana. A requirement may now
be written {"name": ..., "optional": true}. It resolves as a hard one when a provider is assigned or
reachable, and is otherwise absent: never refused, nothing installed for it. Its binding, credential
and only-when-bound files are left out, its ${bound:...|default:...} placeholders take their
defaults, the module check refuses one that could render empty, and plan and node list it unbound.

cmd/mesh-controller/modules.go

@@ -237,7 +237,15 @@ func moduleCommand(ctx context.Context, args []string) error {
 				says = append(says, "provides "+describeOffers(m.Provides))
 			}
 			if len(m.Requires) > 0 {
-				says = append(says, "requires "+strings.Join(m.Requires, ", "))
+				// An optional requirement says so (novox/hq ADR 0330): it is not refused when absent.
+				required := make([]string, 0, len(m.Requires))
+				for _, r := range m.Requires {
+					if m.IsOptional(r) {
+						r += " (optional)"
+					}
+					required = append(required, r)
+				}
+				says = append(says, "requires "+strings.Join(required, ", "))
 			}
 			for _, c := range m.Claims {
 				says = append(says, "claims "+c.At()+"/"+c.Name)

cmd/mesh-controller/nodes.go

@@ -929,6 +929,13 @@ func showNode(ctx context.Context, stored *stores, name string) error {
 		for _, line := range notAppliedLines(name, leftOutOf(plan, settings, node.Adopted)) {
 			fmt.Println(line)
 		}
+		// And which optional requirements of its modules nothing assigned answers (novox/hq ADR 0330 §7).
+		if lines := unboundLines(plan); len(lines) > 0 {
+			fmt.Println()
+			for _, line := range lines {
+				fmt.Println(line)
+			}
+		}
 	}
 	return nil
 }

cmd/mesh-controller/plan.go

@@ -1315,6 +1315,14 @@ func planCommand(ctx context.Context, args []string) error {
 		fmt.Printf("%s is assigned nothing\n", args[0])
 		return nil
 	}
+	// Which optional requirements are unbound (novox/hq ADR 0330 §7): beside the document on the
+	// error stream where the answer is the declaration itself, which carries no such field — the
+	// node-engine refuses an envelope key it does not know.
+	if *asDiff || *asJSON {
+		for _, line := range unboundLines(plan) {
+			fmt.Fprintf(os.Stderr, "%s:%s\n", args[0], line)
+		}
+	}
 	if *asDiff {
 		declared, err := declarationFor(ctx, open, args[0], plan, settings)
 		if err != nil {
@@ -1396,6 +1404,9 @@ func planCommand(ctx context.Context, args []string) error {
 	for _, n := range plan.Needs {
 		fmt.Printf("  needs %s from %s, for %s\n", n.Name, n.From, n.For)
 	}
+	for _, line := range unboundLines(plan) {
+		fmt.Println(line)
+	}
 	declared, err := declarationFor(ctx, open, args[0], plan, settings)
 	if err != nil {
 		return err

cmd/mesh-controller/unbound.go

@@ -0,0 +1,21 @@
+package main
+
+import (
+	"fmt"
+
+	"github.com/novox/mesh-controller/internal/catalogue"
+)
+
+// unboundLines say which optional requirements of a machine's modules nothing assigned answers
+// (novox/hq ADR 0330 §7): left unbound rather than refused, with nothing installed for them, so the
+// module runs without — and said, because a data source that never appears is otherwise a silence.
+// Each binds without anybody's act on the first composition after a provider is assigned.
+func unboundLines(plan catalogue.Resolution) []string {
+	lines := make([]string, 0, len(plan.Absent))
+	for _, a := range plan.Absent {
+		lines = append(lines, fmt.Sprintf(
+			"  unbound  %s, optional for %s — nothing assigned provides it; it binds once a provider is "+
+				"assigned (novox/hq ADR 0330)", a.Requirement, a.Consumer))
+	}
+	return lines
+}

cmd/mesh-controller/unbound_test.go

@@ -0,0 +1,59 @@
+package main
+
+import (
+	"strings"
+	"testing"
+
+	"github.com/novox/mesh-controller/internal/catalogue"
+)
+
+// A machine running grafana without influxdb says so (novox/hq ADR 0330 §7, issue 166): `plan` and
+// `node` list the optional requirement nothing assigned answers, and the requirement is left
+// absent rather than refused — influxdb is in the catalogue and is not installed for it.
+func TestPlanAndNodeListAnOptionalRequirementLeftUnbound(t *testing.T) {
+	open := aMesh(t)
+	ctx := t.Context()
+	register(t, open, catalogue.Manifest{Module: "influxdb", Version: "1",
+		Provides: catalogue.FromAnywhere("influxdb-api")})
+	register(t, open, catalogue.Manifest{Module: "grafana", Version: "1",
+		Requires: []string{"influxdb-api"}, OptionalRequires: map[string]bool{"influxdb-api": true},
+		Resources: []map[string]any{{"id": "state", "type": "directory", "path": "/var/lib/grafana", "mode": "0700"}}})
+	if _, err := assign(ctx, open, "laptop", "grafana"); err != nil {
+		t.Fatalf("grafana could not be assigned on a mesh without influxdb: %v", err)
+	}
+
+	plan, _, err := planFor(ctx, open, "laptop")
+	if err != nil {
+		t.Fatal(err)
+	}
+	for _, m := range plan.Modules {
+		if m.Module == "influxdb" {
+			t.Fatal("influxdb was installed for grafana's optional requirement (ADR 0330 §3)")
+		}
+	}
+	const said = "unbound  influxdb-api, optional for grafana"
+	if shown := printed(t, func() error { return planCommand(ctx, []string{"laptop"}) }); !strings.Contains(shown, said) {
+		t.Errorf("plan laptop does not say influxdb-api is unbound:\n%s", shown)
+	}
+	if shown := printed(t, func() error { return showNode(ctx, open, "laptop") }); !strings.Contains(shown, said) {
+		t.Errorf("node show laptop does not say influxdb-api is unbound:\n%s", shown)
+	}
+	// And once influxdb is assigned somewhere, grafana binds to it with no act on grafana.
+	if _, err := assign(ctx, open, "anchor", "influxdb"); err != nil {
+		t.Fatal(err)
+	}
+	plan, _, err = planFor(ctx, open, "laptop")
+	if err != nil {
+		t.Fatal(err)
+	}
+	if len(plan.Absent) != 0 {
+		t.Fatalf("still absent after influxdb was assigned: %+v", plan.Absent)
+	}
+	var bound bool
+	for _, n := range plan.Needs {
+		bound = bound || n.For == "grafana" && n.Name == "influxdb-api" && n.From == "anchor"
+	}
+	if !bound {
+		t.Fatalf("grafana was not bound to influxdb on anchor: %+v", plan.Needs)
+	}
+}