Count a bus refusal by what the bus said, not by how often the controller looked (issue 402)
S9 reads the one remembered advisory again on every look for an hour, and each look was kept as an observation and a line of evidence, so a single refusal read as one repeated every 30 seconds. An observation may now say when what it reads happened and how often; the keeper counts that, and a look with nothing newer adds nothing. Sources that look at the present keep counting their looks.
This commit is contained in:
@@ -533,7 +533,10 @@ func watchAdvisories(f *signalFacts) []conditions.Observation {
|
||||
machine = f.host
|
||||
}
|
||||
o := conditions.Observation{Scope: conditions.ScopeBus, ID: a.ID, Kind: a.Kind, Token: a.Token,
|
||||
Machine: machine, Severity: severity, Summary: a.Said + times, Said: a.Said}
|
||||
Machine: machine, Severity: severity, Summary: a.Said + times, Said: a.Said,
|
||||
// The advisory is remembered and read again on every look for an hour: the condition counts
|
||||
// what the bus said and when, not the looks (novox/hq issue 402).
|
||||
Happened: a.Last, Times: a.Count}
|
||||
if a.Kind == link.AdvisoryMaxDeliveries && a.Token == link.AdvisoryNotKept {
|
||||
o.Machine = consumerMachine(a.Stream, a.Consumer)
|
||||
o.Headline = clip(conditions.Capital(fmt.Sprintf("%s gave up on a message, not kept",
|
||||
|
||||
Reference in New Issue
Block a user