novox/mesh-controller
8
0
Fork 0
Code Issues Pull Requests 5 Releases Wiki Activity

Merge pull request 'A one-machine walk says its report was its run (hq issue 720)' (#335) from fix/720-a-one-machine-walk-says-its-report into main

Browse Source
This commit was merged in pull request #335.
This commit is contained in:
mesh-admin
2026-10-14 18:59:22 +00:00
parent a5500f732f 34050dc6a3
commit c2ec0a601a
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/inventory/walkphases.go
+2 -1
View File
@@ -397,8 +397,9 @@ func (p Plan) points(now time.Time, applied AppliedLookup, w *WalkPhases) []poin
return append(out, point{phase: PhaseApply, tier: -1, said: "the rest's sends are not kept for a walk made before ADR 0282"}) return append(out, point{phase: PhaseApply, tier: -1, said: "the rest's sends are not kept for a walk made before ADR 0282"})
} }
if len(lastSends) == 0 { if len(lastSends) == 0 {
// novox/hq issue 720: since ADR 0360 no gate reads a walk; its one machine's report is its run.
return append(out, point{phase: PhaseApply, tier: -1, none: true, return append(out, point{phase: PhaseApply, tier: -1, none: true,
said: "no machine beyond the first: the first-node gate's readings were its run"}) said: "no machine beyond the first: its one machine's report was its run"})
} }
if applied == nil { if applied == nil {
return append(out, point{phase: PhaseApply, tier: -1, said: "the rest's reports were not read"}) return append(out, point{phase: PhaseApply, tier: -1, said: "the rest's reports were not read"})
internal/inventory/walkphases_test.go
+1 -1
View File
@@ -89,7 +89,7 @@ func TestARecordedWalksPhasesAddUpToItsTotal(t *testing.T) {
if got := phase(w, PhaseWord, -1); got.State != PhaseNone { if got := phase(w, PhaseWord, -1); got.State != PhaseNone {
t.Errorf("a walk that waits for no word says its word phase %s", got.State) t.Errorf("a walk that waits for no word says its word phase %s", got.State)
} }
if got := phase(w, PhaseApply, -1); got.State != PhaseNone || !strings.Contains(got.Said, "no machine beyond the first") { if got := phase(w, PhaseApply, -1); got.State != PhaseNone || !strings.Contains(got.Said, "no machine beyond the first: its one machine's report was its run") {
t.Errorf("one machine only: apply %s (%s)", got.State, got.Said) t.Errorf("one machine only: apply %s (%s)", got.State, got.Said)
} }
} }