novox/mesh-controller
13
0
Fork 0
Code Issues Pull Requests 3 Releases Wiki Activity

Review round 1: assert the own secret's mode, not merely log it (issue 1170)

Browse Source
This commit is contained in:
jochen
2026-10-19 03:18:22 +02:00
parent 9b7f9a7fd2
commit cfb6a8c531
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/catalogue/own_secret_owner_test.go
+6 -4
View File
@@ -58,10 +58,12 @@ func TestAnOwnSecretsOwnerIsGivenToItsFiles(t *testing.T) {
if got := family["owner"]; got != "mesh-mail-send" { if got := family["owner"]; got != "mesh-mail-send" {
t.Fatalf("the family member's owner: %v; want mesh-mail-send", got) t.Fatalf("the family member's owner: %v; want mesh-mail-send", got)
} }
if got := family["mode"]; got != "" && got != nil { // review round 1, finding 7: asserted, not merely logged. ownedBy never sets "mode", so a sealed secret
// mode is not set by ownedBy; the host applies 0600 to every secret file regardless (ADR 0086). Still, // file carries none here either — the host applies 0600 to every one regardless (novox/hq ADR 0086) —
// a mode this test sees must not have been changed by the owner clause. // and the owner clause must not have added one of its own that could override that.
t.Logf("family mode: %v", got) if _, has := family["mode"]; has {
t.Fatalf("the family member carries its own mode %v; the owner clause must not set one, so the "+
"host's 0600 for every sealed secret file stands", family["mode"])
} }
if plain == nil { if plain == nil {
t.Fatalf("the module's other own secret was not composed at all: %v", out) t.Fatalf("the module's other own secret was not composed at all: %v", out)