Copy node.sent_builds onto the assignments' keys once, and keep the column; list the new store tests (issues 1109, 1096)

Delivery 1 wrote no commit on the key of a pulled-in module, so after the upgrade those modules fell out of SentBuilds. At the start of the lease holder a copy fills every key that names no commit (creating a standing pulled-in key where none stands), overwrites nothing, empties each column it copied, and raises an urgent condition while it fails. Migration 0105 no longer drops node.sent_builds (issue 1112 does).

internal/inventory/chain_source_test.go

@@ -21,10 +21,10 @@ var sqlStatement = regexp.MustCompile(`(?is)^\s*(select|insert|update|delete|alt
 
 // **No code names a table of the chain** (acceptance 12, issue 1096), found by reading the sources: a string literal of any
 // non-test file of internal/ or cmd/ that names one after from, into, update, join, delete from, references or table —
-// build_gate and port_assignment are other words — or the column sent_builds. This is the static half of the proof; the
+// build_gate and port_assignment are other words —. This is the static half of the proof; the
 // integration test reads the catalog.
 func TestNoCodeNamesATableOfTheChain(t *testing.T) {
-	names := regexp.MustCompile(`(?i)\b(from|into|update|join|delete\s+from|references|table)\s+(` + strings.Join(chainTables, "|") + `)\b|\bsent_builds\b`)
+	names := regexp.MustCompile(`(?i)\b(from|into|update|join|delete\s+from|references|table)\s+(` + strings.Join(chainTables, "|") + `)\b`)
 	var found []string
 	for _, root := range []string{"../../internal", "../../cmd"} {
 		err := filepath.WalkDir(root, func(path string, d fs.DirEntry, err error) error {
@@ -71,11 +71,10 @@ func TestNoCodeNamesATableOfTheChain(t *testing.T) {
 
 // The scan sees what it says it sees: planted, a string naming a table is found, and a comment or a word beside is not.
 func TestTheSourceScanFindsATablePlanted(t *testing.T) {
-	names := regexp.MustCompile(`(?i)\b(from|into|update|join|delete\s+from|references|table)\s+(` + strings.Join(chainTables, "|") + `)\b|\bsent_builds\b`)
+	names := regexp.MustCompile(`(?i)\b(from|into|update|join|delete\s+from|references|table)\s+(` + strings.Join(chainTables, "|") + `)\b`)
 	for text, want := range map[string]bool{
 		"select id from build where id = $1":         true,
 		"insert into assignment (node, module)":      true,
-		"update node set sent_builds = $1":           true,
 		"select 1 from build_gate":                   false,
 		"delete from port_assignment":                false,
 		"select a from build_request a join build b": true,
@@ -116,11 +115,14 @@ func TestTheLastMigrationDropsTheTablesOfTheChain(t *testing.T) {
 			t.Errorf("migration %d does not drop %s", last.Number, table)
 		}
 	}
-	for _, want := range []string{"drop function raise_assignment_generation()", "alter table node drop column sent_builds"} {
+	for _, want := range []string{"drop function raise_assignment_generation()"} {
 		if !strings.Contains(sql, want) {
 			t.Errorf("migration %d lacks %q", last.Number, want)
 		}
 	}
+	if strings.Contains(sql, "sent_builds") {
+		t.Errorf("migration %d touches node.sent_builds, which stays as the source of the copy (issue 1112 drops it)", last.Number)
+	}
 	if strings.Contains(sql, "build_gate") || strings.Contains(sql, "assignment_generation;") {
 		t.Errorf("migration %d touches a table that stays", last.Number)
 	}