Let plans wait for a plan to move and answer it as data (issue 229)
An agent following a rollout had plans answer once, in prose, and polled the console with a curl loop of its own to be told a plan moved. plans now takes wait (a plan's id), until (moved, tier or done) and bound, and answers when the plan moves or the bound passes, saying which, with the plan as data and its line as the output. A call's one answer has to reach the console inside its thirty seconds, so link.AnswersWithin lets a handler that waits on purpose hold its answer up to LongestAnswer (25s) instead of AnswerWithin; the bound is at most 20s, and a caller following a plan further asks again.
This commit is contained in:
@@ -1463,6 +1463,10 @@ func plansCommand(ctx context.Context, args []string) error {
|
||||
modules := set.String("modules", "", "or the modules it would change, comma-separated")
|
||||
moduleDirs := set.String("module-dirs", "", "with --paths: the directories holding a module.json at the commit, "+
|
||||
"comma-separated, as the forge's announcer says them (novox/hq issue 278)")
|
||||
// Following a plan (novox/hq issue 229): `plans wait <id>`.
|
||||
until := set.String("until", "", "with wait: what to wait for — moved (any change), tier (its next tier) or done (its end)")
|
||||
bound := set.String("bound", "", "with wait: how long to wait at most, as 15s or seconds (default and at most the "+
|
||||
"longest a call is answered within)")
|
||||
// Ending a plan by hand is a repair, and says why (novox/hq to-be 45 §7).
|
||||
why := addHandActFlags(set)
|
||||
positionals, err := parseAround(set, args)
|
||||
@@ -1482,6 +1486,9 @@ func plansCommand(ctx context.Context, args []string) error {
|
||||
defer open.Close()
|
||||
inv := open.inventory
|
||||
now := time.Now()
|
||||
if len(positionals) == 2 && positionals[0] == "wait" {
|
||||
return planWaitCommand(ctx, inv, positionals[1], *until, *bound)
|
||||
}
|
||||
if len(positionals) == 1 {
|
||||
p, err := inv.PlanByID(ctx, positionals[0])
|
||||
if err != nil {
|
||||
|
||||
Reference in New Issue
Block a user