Announce the controller's states, keep every module's word, and grant a read only where its owner announced the state readable; the copied list of the controller's mirrors goes (issue 1790, D1-D4, ADR 0495, ADR 0513 §3)

cmd/mesh-controller/readable.go

@@ -53,6 +53,11 @@ type meshStatus struct {
 	// Per machine, and data. One node failing must never take the document away from a reader
 	// asking about the others.
 	Unresolved []machineUnresolved `json:"unresolved"`
+	// NotAnnounced are the modules others read the state of that have not said what they keep (novox/hq ADR 0495,
+	// issue 1790): their readers are granted from `reads` as before until they do. NotAnnouncedWhy is why it could not
+	// be read.
+	NotAnnounced    []string `json:"not-announced,omitempty"`
+	NotAnnouncedWhy string   `json:"not-announced-why,omitempty"`
 	// Network is why the private network could not be computed, when it could not; absent when it
 	// could. Almost always a consequence of Unresolved: a node that does not resolve is not on the
 	// network, and a mesh whose hub is that node has no hub.
@@ -247,7 +252,8 @@ func statusAsJSON(asked answers) ([]byte, error) {
 	out := meshStatus{Machines: len(nodes), Wrong: []machineDoing{},
 		Quiet: []machineQuiet{}, Behind: []moduleBehind{}, Waiting: []machineWaiting{},
 		Reported: []machineReported{}, Unresolved: []machineUnresolved{},
-		Network: asked.network, Adopted: adoptedNodes(nodes), Plans: planStatuses(asked.plans, time.Now(), asked.paused, asked.tierBounds)}
+		Network: asked.network, Adopted: adoptedNodes(nodes), Plans: planStatuses(asked.plans, time.Now(), asked.paused, asked.tierBounds),
+		NotAnnounced: asked.notAnnounced, NotAnnouncedWhy: asked.notAnnouncedWhy}
 	// In a stated order, so two readings of an unchanged mesh are the same document.
 	untakenNodes := make([]string, 0, len(asked.untaken))
 	for name := range asked.untaken {