Announce the controller's states, keep every module's word, and grant a read only where its owner announced the state readable; the copied list of the controller's mirrors goes (issue 1790, D1-D4, ADR 0495, ADR 0513 §3)

internal/broker/controller_buckets_test.go

@@ -100,7 +100,7 @@ func TestTheWatchedSignalsMayBeSaidAndHeard(t *testing.T) {
 // stands for their declaration, so the report of state nothing declares never names one.
 func TestAListedMirrorIsNotReportedAsUndeclared(t *testing.T) {
 	names := []string{"gone_state"}
-	for _, m := range ControllerMirrors() {
+	for _, m := range controllerReadableStates() {
 		names = append(names, BucketName(ControllerSeat, m))
 	}
 	undeclared, err := RaiseBuckets(fakeBuckets{names: names}, nil)
@@ -132,7 +132,7 @@ func TestTheMirrorsListAndTheWritersTableAgree(t *testing.T) {
 		}
 	}
 	listed := map[string]bool{}
-	for _, m := range ControllerMirrors() {
+	for _, m := range controllerReadableStates() {
 		bucket := BucketName(ControllerSeat, m)
 		listed[bucket] = true
 		if why, other := MirrorsWrittenByAnother[m]; other { // 1155/AC3: the exception, with its reason
@@ -292,7 +292,7 @@ func TestEveryChainBucketIsOnTheControllersListAndHasAWriterRow(t *testing.T) {
 			t.Errorf("%s is not on the controller's list of buckets", bucket)
 		}
 		local := strings.TrimPrefix(bucket, ControllerSeat+"_")
-		if !slices.Contains(ControllerMirrors(), local) {
+		if !slices.Contains(controllerReadableStates(), local) {
 			t.Errorf("a module cannot name %s in `reads`", bucket)
 		}
 		rows := 0