novox/mesh-controller
12
0
Fork 0
Code Issues Pull Requests 5 Releases Wiki Activity

Quote none of the line in the unclosed-quote refusal: a refusal is kept on the bus as the call's answer (hq issue 294)
mesh/merge-gate pass: builds mesh-controller → novox; no bus step; every machine composes with the change as it did without (4 of 4 compose)
Details
mesh/repo-check pass: its merge-check.sh passed
Details
mesh/delivery delivered
Details

Browse Source
This commit is contained in:
jochen
2026-10-10 18:39:20 +02:00
parent 6188e6b1da
commit d52de218c8
2 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/mesh-controller/seatverbs.go
+7 -12
View File
@@ -1405,7 +1405,7 @@ func splitCommandLine(line string) ([]string, error) {
}
}
if quote != 0 {
return nil, unclosedQuote(runes, quote, opened)
return nil, unclosedQuote(quote, opened)
}
if inWord {
words = append(words, cur.String())
@@ -1415,18 +1415,13 @@ func splitCommandLine(line string) ([]string, error) {
// unclosedQuote is the refusal of a line whose quote is never closed. Most often an apostrophe inside
// a single-quoted value ended that quote early and a later quote was left open, so the refusal says
// where the open quote is, shows the line from there, and says how a quote is written inside a quoted
// value — the shell's own two ways, which this splitter already reads (novox/hq issue 294).
func unclosedQuote(runes []rune, quote rune, opened int) error {
const shown = 40
from := runes[opened:]
excerpt := string(from)
if len(from) > shown {
excerpt = string(from[:shown]) + "…"
}
return fmt.Errorf("command has an unclosed %c quote, opened at character %d: %s — an apostrophe "+
// where the open quote is and how a quote is written inside a quoted value — the shell's own two
// ways, which this splitter already reads (novox/hq issue 294). It quotes none of the line: a refusal
// is kept on the bus as the call's answer, and the line may carry a setting's value.
func unclosedQuote(quote rune, opened int) error {
return fmt.Errorf("command has an unclosed %c quote, opened at character %d — an apostrophe "+
"inside a single-quoted value ends it; write a ' inside single quotes as '\\'' (it'\\''s), or use "+
"double quotes and write \\\" for a \" and \\\\ for a \\ inside them", quote, opened+1, excerpt)
"double quotes and write \\\" for a \" and \\\\ for a \\ inside them", quote, opened+1)
}
// seatAnnouncement is what the controller says it serves on the bus (novox/hq ADR 0197): the