Feature 57 (config and provisioning): release mesh-controller, the reviewed release branch merged with main, on top of main

cmd/mesh-controller/gate.go

@@ -235,6 +235,10 @@ type gateFacts struct {
 	sent       map[string]inventory.SentDeclaration
 	sentBuilds map[string]map[string]string
 	commits    map[string]string
+	// provisioned answers each machine's provisioner client's newest report of a module (novox/hq ADR 0349 §15):
+	// a module the gate's send handed to the provisioner is healthy only once it reported that build placed. Nil
+	// reads as nothing said.
+	provisioned inventory.ProvLookup
 }
 
 // heldReading is the provider a module's findings are held under, as "<module> on <machine>", and, when that
@@ -291,7 +295,7 @@ func (f gateFacts) supersededOn(module, machine string) (string, bool) {
 var gatherGateFacts = func(ctx context.Context, open *stores, component string) (gateFacts, error) {
 	inv := open.inventory
 	f := gateFacts{now: time.Now(), reports: map[string]inventory.Reported{}, engines: map[string]string{},
-		rolledBack: witnessed.all()}
+		rolledBack: witnessed.all(), provisioned: provLookup(ctx)}
 	reports, err := inv.LastReports(ctx)
 	if err != nil {
 		return f, err
@@ -368,6 +372,12 @@ func judgeHealth(module, component string, m catalogue.Manifest, machine string,
 	case r.Outcome != inventory.OutcomeApplied:
 		return healthNotYet, fmt.Sprintf("%s reported %q", machine, r.Outcome)
 	}
+	// **And its files placed** (novox/hq ADR 0349 §15): a module the send handed to the provisioner is judged only
+	// once that machine's client reported the build's templates placed, so a module whose files are not yet written
+	// is never judged; a failure there is the build's on that machine.
+	if h, why := judgeProvisioned(module, machine, r, f); h != healthGood {
+		return h, why
+	}
 	// **No new condition about it**: about the machine itself, or naming the module on that machine,
 	// raised since the judging began. The gate's own are not evidence about the build. A fault that was
 	// there at the send and reopened since is not new; one that had cleared before the send and came back
@@ -449,6 +459,32 @@ func judgeHealth(module, component string, m catalogue.Manifest, machine string,
 	return healthGood, ""
 }
 
+// judgeProvisioned is whether a module's files are placed on a machine, for a module the gate's send handed to the
+// provisioner there: healthy for any other.
+func judgeProvisioned(module, machine string, r inventory.Reported, f gateFacts) (health, string) {
+	sent, kept := f.sent[machine]
+	digest := sent.Provisioned[module]
+	if !kept || digest == "" {
+		return healthGood, ""
+	}
+	at := time.Time{}
+	if r.At != nil {
+		at = *r.At
+	}
+	one := inventory.SentDeclaration{Digest: sent.Digest, At: sent.At, Provisioned: map[string]string{module: digest}}
+	got, ok := inventory.ProvisionedSend(machine, one, inventory.AppliedReport{At: at,
+		Outcome: inventory.OutcomeApplied}, true, f.provisioned)
+	switch {
+	case !ok:
+		return healthNotYet, fmt.Sprintf("the provisioner on %s has not reported %s's files placed for the new "+
+			"build", machine, module)
+	case got.Outcome != inventory.OutcomeApplied:
+		return healthBroken, fmt.Sprintf("the provisioner on %s did not place %s's files: %s", machine, module,
+			got.Outcome)
+	}
+	return healthGood, ""
+}
+
 // machineWord is what one judging found wrong with a machine itself, apart from its modules: facts is
 // the judging's facts without those conditions, on what each names among the modules the send moved,
 // and whole what holds the machine back as a whole.