Say a machine waiting for its push as waiting, not uncomposable (hq issue 275)

Between assign and push a module's own secrets are not made yet; D1 composed
without making them and raised an urgent 'nothing can be sent' that the next
push resolved silently. D1 now composes as the push would (Foreseeing): a
secret the push makes gets a stand-in and is named, one the push is refused on
is refused with the push's words. Waiting is said only past 30 minutes, as a
warning. D3 and D13 expect a holder only once its machine was sent it and
reported or had ten minutes to.

cmd/mesh-controller/data.go

@@ -121,15 +121,15 @@ func readHolder(raw json.RawMessage) (map[string]map[string]inventory.Measuremen
 	return out, nil
 }
 
-// declaredOn is every data item a machine's composition declares, and whether something there holds
-// node-backup to measure them.
-func declaredOn(plan catalogue.Resolution) ([]inventory.DeclaredData, bool) {
+// declaredOn is every data item a machine's composition declares, and the module there that holds
+// node-backup to measure them — empty for none.
+func declaredOn(plan catalogue.Resolution) ([]inventory.DeclaredData, string) {
 	var out []inventory.DeclaredData
-	held := false
+	held := ""
 	for _, m := range plan.Modules {
 		for _, c := range m.Claims {
 			if s, known := catalogue.SeatNamed(c.Name); known && s.Name == catalogue.BackupSeat {
-				held = true
+				held = m.Module
 			}
 		}
 		for _, it := range m.DataItems() {
@@ -166,6 +166,10 @@ func probeData(ctx context.Context, d *doctor) ([]conditions.Observation, error)
 	}
 	heard := heardMachines(d)
 	now := time.Now()
+	delivered, err := readDeliveries(ctx, open.inventory)
+	if err != nil {
+		return nil, err
+	}
 
 	type machine struct {
 		name     string
@@ -185,7 +189,11 @@ func probeData(ctx context.Context, d *doctor) ([]conditions.Observation, error)
 			// declaring nothing: retiring its data on that would be acting on an unreadable result.
 			continue
 		}
-		declared, held := declaredOn(plan)
+		declared, holder := declaredOn(plan)
+		// **A holder is asked only once its machine has been sent it and had time to report** (novox/hq
+		// issue 275): assigned and not pushed yet, it is not there to answer, and "did not say what it
+		// measured" about it was a warning for a push nobody had made yet.
+		held := holder != "" && delivered[n.Name].settled(holder, now)
 		machines = append(machines, &machine{name: n.Name, declared: declared, held: held})
 	}
 	// Every holder asked at once, as D8 asks every ban list.