Pass a wait for a person's new login with the wait carried, and keep the pass of a module healthy beside a failure (hq ADR 0254, issue 318)

cmd/mesh-controller/release.go

@@ -334,6 +334,15 @@ func failCarried(ctx context.Context, open *stores, p *inventory.Plan, g *invent
 		notes = append(notes, p.Note)
 	}
 	done := map[string]bool{except: true}
+	// **What passed on its own keeps its pass** (novox/hq ADR 0254, issue 318): healthy for the passes the
+	// gate asks while another module of the send failed, it is neither put back nor left unjudged — a build
+	// left without a verdict is one more move every other walk would wait for.
+	if kept := keepPassing(ctx, open, p, g, except); len(kept) > 0 {
+		notes = append(notes, "passed on their own and kept: "+strings.Join(kept, ", "))
+		for _, m := range kept {
+			done[m] = true
+		}
+	}
 	for _, c := range g.Carried {
 		if done[c.Module] || (len(g.Failing) > 0 && !slices.Contains(g.Failing, c.Module)) {
 			continue
@@ -356,6 +365,34 @@ func failCarried(ctx context.Context, open *stores, p *inventory.Plan, g *invent
 	p.Note = strings.Join(notes, "; ")
 }
 
+// keepPassing keeps a pass as the verdict of every build the gate carried that passed on its own when the
+// send failed (ADR 0254), except the plan's own module; answers the modules kept.
+func keepPassing(ctx context.Context, open *stores, p *inventory.Plan, g *inventory.PlanGate, except string) []string {
+	var kept []string
+	seen := map[string]bool{}
+	for _, c := range g.Carried {
+		if c.Module == except || c.Build == "" || seen[c.Build] || !slices.Contains(g.Passing, c.Module) {
+			continue
+		}
+		seen[c.Build] = true
+		why := fmt.Sprintf("healthy %d times on its own while the send failed: %s", g.Healthy[c.Module], g.Why)
+		if w := g.Waits[c.Module]; w != "" {
+			why += "; and it waits for a person: " + w
+		}
+		if err := open.inventory.RecordGate(ctx, inventory.GateVerdict{Build: c.Build, Module: c.Module, Commit: c.To,
+			Previous: c.From, Plan: p.ID, Machines: []string{c.Node}, Verdict: inventory.GatePassed, Why: why,
+			Component: coreComponent(c.Module), JudgingFrom: g.Since}); err != nil {
+			fmt.Printf("%s: %s passed its gate on %s on its own, and the verdict could not be kept: %v\n", p.ID, c.Module,
+				c.Node, err)
+			continue
+		}
+		if !slices.Contains(kept, c.Module) {
+			kept = append(kept, c.Module)
+		}
+	}
+	return kept
+}
+
 // sentTheBuild is every machine running a module that was last sent this build of it.
 func sentTheBuild(ctx context.Context, open *stores, module, commit string) ([]string, error) {
 	running, err := open.inventory.Running(ctx, module)