novox/mesh-controller
3
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity

A comment claimed a test that does not exist

Browse Source 
I wrote that a test asserts the control plane's placeholder expression
and the host's still agree. None does, and none in this repository could
— a unit test here can only assert what this repository already
believes.

That is precisely the thing this project refuses to tolerate: a stated
rule with no way to check it, which costs more than no rule because
people believe it. Written by me, today, in the same file that closes a
gap of the same kind.

What actually proves it is the lab, and the comment now says so.
This commit is contained in:
jschoubben
2026-09-01 03:15:22 +02:00
parent a4090014f3
commit e49586646b
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/catalogue/secrets_into_files.go
+7 -3
View File
@@ -24,9 +24,13 @@ import (
// placeholder is what a module's file content says where a sealed value belongs: ${secret:name}. // placeholder is what a module's file content says where a sealed value belongs: ${secret:name}.
// //
// The same expression the host matches, written out again rather than shared. The two // The same expression the host matches, written out again rather than shared: they are separate
// repositories agree on a wire format, and a format read on both sides is exactly the thing that // repositories and this is a wire format, like the shape of the declaration itself.
// must not be quietly changed on one of them; a test asserts they still agree. //
// **Nothing here can check that they agree, and the claim that something did was wrong.** A unit
// test in this repository can only assert what this repository already believes. What proves it is
// the lab, where a real host receives a real declaration and the file arrives filled — and where
// the two expressions disagreeing shows up as a placeholder written through to a machine.
var placeholder = regexp.MustCompile(`\$\{secret:([a-z0-9][a-z0-9-]*)\}`) var placeholder = regexp.MustCompile(`\$\{secret:([a-z0-9][a-z0-9-]*)\}`)
// secretsUsed are the names a file's content asks for, in the order they first appear. // secretsUsed are the names a file's content asks for, in the order they first appear.