Delete the push and the declaration: the send stub and node holds, link declare and its order, the sent readers, and the sweep judged by compositions (release 6, issue 1945 B8)

cmd/mesh-controller/signals.go

@@ -274,29 +274,6 @@ func watchHeartbeats(f *signalFacts) []conditions.Observation {
 	return out
 }
 
-func watchReports(f *signalFacts) []conditions.Observation {
-	var out []conditions.Observation
-	for _, m := range f.machines {
-		if m.sentAt.IsZero() || m.reportedCurrent || m.asleep() {
-			continue
-		}
-		if m.silent(f.now) {
-			continue // silent: S1 says it, and a silent machine reports nothing
-		}
-		bound := max(reportAtLeast, 3*m.lastApply)
-		waited := f.now.Sub(m.sentAt)
-		if waited <= bound {
-			continue
-		}
-		out = append(out, conditions.Observation{Scope: conditions.ScopeMachine, ID: m.name,
-			Kind: "sent-not-reported", Machine: m.name, Severity: conditions.Warning,
-			Summary: fmt.Sprintf("%s was sent a declaration at %s and has not reported applying it (bound %s)",
-				m.name, m.sentAt.UTC().Format("2006-01-02 15:04 MST"), ago(bound)),
-			Said: fmt.Sprintf("waiting %s for the report of the declaration sent", ago(waited))})
-	}
-	return out
-}
-
 func watchLoop(f *signalFacts) []conditions.Observation {
 	if f.loop.pending == 0 {
 		return nil