Delete the push and the declaration: the send stub and node holds, link declare and its order, the sent readers, and the sweep judged by compositions (release 6, issue 1945 B8)

internal/link/order_test.go

@@ -5,34 +5,8 @@ import (
 	"testing"
 )
 
-// The contract of order.go, case by case: what a node-engine refuses of a declaration (the rule
-// mesh-host states, restated so the controller's tests say what the machines do with what it sends),
-// what the controller refuses of a report, and the bytes on the wire both ways.
-
-func TestADeclarationIsOlderOnlyWhenBothClaimAnEpoch(t *testing.T) {
-	for _, c := range []struct {
-		name     string
-		arriving Order
-		held     Order
-		older    bool
-	}{
-		{"a newer sequence of the same epoch", Order{57, 12}, Order{57, 11}, false},
-		{"the same declaration again (a reconcile)", Order{57, 12}, Order{57, 12}, false},
-		{"a lower sequence of the same epoch", Order{57, 11}, Order{57, 12}, true},
-		// Issue 204: a controller that lost its lease goes on sending.
-		{"an older epoch, whatever its sequence", Order{41, 99}, Order{57, 12}, true},
-		{"a newer epoch, whatever its sequence", Order{57, 3}, Order{41, 99}, false},
-		{"no epoch arriving: a rolled-back controller is not stranded", Order{0, 11}, Order{57, 12}, false},
-		{"no epoch held: what the machine held before any lease", Order{57, 11}, Order{0, 12}, false},
-		{"no order at all", Order{}, Order{57, 12}, false},
-	} {
-		t.Run(c.name, func(t *testing.T) {
-			if got := c.arriving.Older(c.held); got != c.older {
-				t.Fatalf("%s against %s: older %v, want %v", c.arriving.Words(), c.held.Words(), got, c.older)
-			}
-		})
-	}
-}
+// The contract of order.go, case by case: what the controller refuses of a node-engine's facts (the node-engine's own order)
+// and the bytes on the wire.
 
 func TestAnAccountIsOlderByEpochThenSequenceThenReportSequence(t *testing.T) {
 	for _, c := range []struct {
@@ -78,7 +52,7 @@ func TestTheOrderOnTheWire(t *testing.T) {
 		r.RefusedOlder != 3 {
 		t.Fatalf("a node-engine's stale refusal reads as %+v", r)
 	}
-	if !r.Ordered() || !r.ReadsEpoch() || !r.StaleRefusalOf() {
+	if !r.Ordered() {
 		t.Fatalf("a node-engine that orders its reports reads as one that does not: %+v", r)
 	}
 
@@ -87,15 +61,9 @@ func TestTheOrderOnTheWire(t *testing.T) {
 	if err := json.Unmarshal([]byte(`{"node":"anchor","applied":["a"],"declared":"d1"}`), &older); err != nil {
 		t.Fatal(err)
 	}
-	if older.Ordered() || older.ReadsEpoch() || older.StaleRefusalOf() {
+	if older.Ordered() {
 		t.Fatalf("an older node-engine's report reads as ordered: %+v", older)
 	}
-	// Its stale refusal, in the words it has always used, is still one.
-	older.Refused = "this declaration " + StaleRefusal + ": it is sequence 3"
-	if !older.StaleRefusalOf() {
-		t.Fatal("an older node-engine's refusal of an older sequence does not read as stale")
-	}
-
 	// And a report with no order puts no order key on the wire.
 	raw, err := json.Marshal(Report{Node: "anchor", Declared: "d1"})
 	if err != nil {