Read what a machine has from its haves: reported-and-current, the bus list, a given value's first good start; drop the digest of a send (migration 0110) (release 6, issue 1945 B8)

cmd/mesh-controller/probes.go

@@ -34,13 +34,6 @@ import (
 // wrong now as observations, or an error when it could not tell — never "nothing" for "could not
 // look" (ADR 0227 rule 4).
 
-// awaitingPushBound is how long a machine may have something only its next push makes — an own
-// secret of a module assigned since its last push — before that is said (novox/hq issue 275).
-var awaitingPushBound = 30 * time.Minute
-
-// kindAwaitingPush is D1's kind for a machine waiting for a push past awaitingPushBound.
-const kindAwaitingPush = "awaiting-push"
-
 // probeDeclarations is D1: every machine's declaration composes, and the node-engine's own validator
 // (mesh-host's `validate`, the package the host runs) takes it.
 //
@@ -80,7 +73,7 @@ func probeDeclarations(ctx context.Context, d *doctor) ([]conditions.Observation
 		if err != nil && !unresolvable(err) {
 			return nil, fmt.Errorf("%s cannot be worked out: %w", n.Name, err)
 		}
-		var problems, foreseen []string
+		var problems []string
 		// Each module the next send leaves out of this machine's declaration (novox/hq issue 380), judged from this
 		// resolution as the send judges it: a finding, never a refusal.
 		if err == nil {
@@ -89,7 +82,6 @@ func probeDeclarations(ctx context.Context, d *doctor) ([]conditions.Observation
 		if err == nil && gensErr == nil {
 			var declared sendable
 			if declared, _, err = composeQuestion(ctx, open, n.Name, compose.Foreseeing, false); err == nil {
-				foreseen = declared.foreseen
 				// With the order it was last sent, so the validator reads the envelope a machine is sent
 				// — its epoch included (novox/hq to-be 45 §6).
 				var serr error
@@ -119,30 +111,11 @@ func probeDeclarations(ctx context.Context, d *doctor) ([]conditions.Observation
 				Summary: fmt.Sprintf("%s's node-engine would refuse its declaration whole: %d problem(s), the first: %s",
 					n.Name, len(problems), problems[0]),
 				Said: strings.Join(problems, "; ")})
-		case len(foreseen) > 0:
-			since, err := open.inventory.AwaitingSince(ctx, n.Name)
-			if err != nil {
-				return nil, err // the store, not the machine: the probe could not run
-			}
-			if waited := time.Since(since); waited > awaitingPushBound {
-				out = append(out, awaitingPush(n.Name, foreseen, since, waited))
-			}
 		}
 	}
 	return out, nil
 }
 
-// awaitingPush is D1's warning for a machine whose declaration composes only once its next push has
-// made what it names, past awaitingPushBound (novox/hq issue 275).
-func awaitingPush(node string, foreseen []string, since time.Time, waited time.Duration) conditions.Observation {
-	made := strings.Join(foreseen, ", ")
-	return conditions.Observation{Scope: conditions.ScopeMachine, ID: node, Token: kindAwaitingPush,
-		Kind: kindAwaitingPush, Machine: node, Severity: conditions.Warning,
-		Summary: fmt.Sprintf("%s has waited %s for a push: its declaration composes once the next push makes %s — "+
-			"`push %s` sends it", node, waited.Round(time.Minute), made, node),
-		Said: fmt.Sprintf("waiting since %s; the next push makes %s", since.UTC().Format(time.RFC3339), made)}
-}
-
 // probeResolvers is D2: every holder of the mesh's resolver answers each machine's name with its
 // address for IPv4, and with no address and no error for IPv6 — NODATA, not NXDOMAIN, which musl
 // takes as final (issue 262).
@@ -600,7 +573,7 @@ func (d lastSend) settled(module string, now time.Time) bool {
 
 // readDeliveries is every machine's last send, by name, from the records a send and a report keep.
 func readDeliveries(ctx context.Context, inv *inventory.Inventory) (map[string]lastSend, error) {
-	reports, err := inv.LastReports(ctx)
+	reports, err := lastReports(ctx, inv)
 	if err != nil {
 		return nil, err
 	}
@@ -1087,7 +1060,7 @@ func probeCoreBuilds(ctx context.Context, d *doctor) ([]conditions.Observation,
 	if err != nil {
 		return nil, err
 	}
-	reports, err := inv.LastReports(ctx)
+	reports, err := lastReports(ctx, inv)
 	if err != nil {
 		return nil, err
 	}