novox/mesh-controller
Archived
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Replay issues 296, 299 and 300 as tests the commit before each fix fails (hq ADR 0237) #124

Merged
mesh-admin merged 1 commits from replays/296-299-300 into main 2026-10-07 21:55:17 +00:00
Conversation 2 Commits 1 Files Changed 1
+181
mesh-admin commented 2026-10-07 21:44:08 +00:00
Contributor
Copy Link
Copy Source

Three replays in cmd/mesh-controller/replays_test.go, written only with what the controller had before each fix, so mesh-lab's prover can lay this file over the merge before the fix:

  • TestReplay296… (hq issue 296, fix #119 / 3808634): a plan in its tier since 19:48:41, saved seconds ago, reads its 41 minutes and LATE via planLine; and a plan whose build waits is not saved again by three advances (revision and last save unchanged).
  • TestReplay299… (hq issue 299, fix #121 / c37d774): through D3 (probeHolders) itself, with the seats read back from the store and a holder on record on every heard machine answering nothing, no holder of a seat whose verbs are all optional is said silent. Replays node-uplink while its verbs are optional, and beside it a seat optional by definition, so it still holds after ADR 0246 step 3.
  • TestReplay300… (hq issue 300, fix #122 / e7dca6c): a catalogue merge adding only modules/systemd-resolved asks the build seat for it at main and opens no plan.

Registered in mesh-lab (R296, R299, R300; HomeRef is this branch's commit 7597294). go run ./replays/cmd/prove R296 R299 R300: all three PROVED — fail on the merge's first parent, pass on the fix merge.

sh merge-check.sh passes locally (full suite, race detector).

Three replays in `cmd/mesh-controller/replays_test.go`, written only with what the controller had before each fix, so mesh-lab's prover can lay this file over the merge before the fix: - **TestReplay296…** (hq issue 296, fix #119 / 3808634): a plan in its tier since 19:48:41, saved seconds ago, reads its 41 minutes and LATE via `planLine`; and a plan whose build waits is not saved again by three advances (revision and last save unchanged). - **TestReplay299…** (hq issue 299, fix #121 / c37d774): through D3 (`probeHolders`) itself, with the seats read back from the store and a holder on record on every heard machine answering nothing, no holder of a seat whose verbs are all optional is said silent. Replays `node-uplink` while its verbs are optional, and beside it a seat optional by definition, so it still holds after ADR 0246 step 3. - **TestReplay300…** (hq issue 300, fix #122 / e7dca6c): a catalogue merge adding only `modules/systemd-resolved` asks the build seat for it at `main` and opens no plan. Registered in mesh-lab (R296, R299, R300; HomeRef is this branch's commit 7597294). `go run ./replays/cmd/prove R296 R299 R300`: all three PROVED — fail on the merge's first parent, pass on the fix merge. `sh merge-check.sh` passes locally (full suite, race detector).
mesh-admin added 1 commit 2026-10-07 21:44:08 +00:00
Replay issues 296, 299 and 300 as tests the commit before each fix fails (hq ADR 0237)
mesh/merge-gate pass: builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step; every machine composes with the change as it…
Details
mesh/repo-check pass: its merge-check.sh passed
Details
mesh/delivery delivered
Details
mesh/delivery-group group replays/296-299-300 merged: every member is merged
Details
7597294ff8
mesh-admin commented 2026-10-07 21:44:47 +00:00
Author
Contributor
Copy Link
Copy Source

Delivery novox/mesh-controller@7597294ff863 — delivered since 2026-10-07T22:08:51Z

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves

Group replays/296-299-300, in order: novox/mesh-controller@7597294ff8 → novox/mesh-lab@74c59661b1

  • composed together: pass — every machine composes with the change as it did without (4 of 4 compose)

Machines

  • mesh-controller on novox: passed — healthy 3 times over 3m39s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 3 times over 3m15s
  • build-agent on the rest running it: sent
  • route-proxy on ace: passed — healthy 3 times over 3m12s
  • route-proxy on the rest running it: sent

Transitions

  • 2026-10-07 21:44 (new) → proposed (announced): novox/mesh-controller#124's head announced
  • 2026-10-07 21:54 proposed → checked (checked): the verdict names this commit
  • 2026-10-07 21:54 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-07 21:55 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-07 21:55 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path
  • 2026-10-07 22:08 delivering → delivered (done): its walk is done: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@7597294ff863` — **delivered** since 2026-10-07T22:08:51Z **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves **Group** `replays/296-299-300`, in order: novox/mesh-controller@7597294ff863 → novox/mesh-lab@74c59661b1d2 - composed together: pass — every machine composes with the change as it did without (4 of 4 compose) **Machines** - mesh-controller on novox: passed — healthy 3 times over 3m39s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 3 times over 3m15s - build-agent on the rest running it: sent - route-proxy on ace: passed — healthy 3 times over 3m12s - route-proxy on the rest running it: sent **Transitions** - 2026-10-07 21:44 (new) → proposed (announced): novox/mesh-controller#124's head announced - 2026-10-07 21:54 proposed → checked (checked): the verdict names this commit - 2026-10-07 21:54 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-07 21:55 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-07 21:55 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path - 2026-10-07 22:08 delivering → delivered (done): its walk is done: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin commented 2026-10-07 21:54:57 +00:00
Author
Contributor
Copy Link
Copy Source

Merge check at 7597294f

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves

Run by the build seat on shanks as build-1791409474980005275 (builds --log build-1791409474980005275).

--- the gate: build-agent, mesh-controller, route-proxy
mesh-controller: ok, 46 tool(s); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-07T21:43:22Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-07T21:43:22Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.038s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	488.520s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.030s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.039s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.034s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.190s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.065s
ok  	github.com/novox/mesh-controller/internal/broker	2.575s
ok  	github.com/novox/mesh-controller/internal/builder	1.353s
ok  	github.com/novox/mesh-controller/internal/catalogue	4.455s
ok  	github.com/novox/mesh-controller/internal/conditions	2.017s
ok  	github.com/novox/mesh-controller/internal/envfile	1.043s
ok  	github.com/novox/mesh-controller/internal/facts	1.050s
ok  	github.com/novox/mesh-controller/internal/identity	49.300s
ok  	github.com/novox/mesh-controller/internal/inventory	302.093s
ok  	github.com/novox/mesh-controller/internal/lease	17.690s
ok  	github.com/novox/mesh-controller/internal/licences	44.408s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.029s
ok  	github.com/novox/mesh-controller/internal/link	88.899s
ok  	github.com/novox/mesh-controller/internal/lint	1.950s
ok  	github.com/novox/mesh-controller/internal/outward	1.071s
ok  	github.com/novox/mesh-controller/internal/overlay	1.051s
ok  	github.com/novox/mesh-controller/internal/secrets	1.492s
ok  	github.com/novox/mesh-controller/internal/store	12.849s
ok  	github.com/novox/mesh-controller/internal/testbus	1.212s
ok  	github.com/novox/mesh-controller/internal/token	1.016s
**Merge check** at `7597294f` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves Run by the build seat on shanks as `build-1791409474980005275` (`builds --log build-1791409474980005275`). ``` --- the gate: build-agent, mesh-controller, route-proxy mesh-controller: ok, 46 tool(s); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-07T21:43:22Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-07T21:43:22Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.038s ok github.com/novox/mesh-controller/cmd/mesh-controller 488.520s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.030s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.039s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.034s ok github.com/novox/mesh-controller/examples/route-proxy 1.190s ok github.com/novox/mesh-controller/internal/artifacts 1.065s ok github.com/novox/mesh-controller/internal/broker 2.575s ok github.com/novox/mesh-controller/internal/builder 1.353s ok github.com/novox/mesh-controller/internal/catalogue 4.455s ok github.com/novox/mesh-controller/internal/conditions 2.017s ok github.com/novox/mesh-controller/internal/envfile 1.043s ok github.com/novox/mesh-controller/internal/facts 1.050s ok github.com/novox/mesh-controller/internal/identity 49.300s ok github.com/novox/mesh-controller/internal/inventory 302.093s ok github.com/novox/mesh-controller/internal/lease 17.690s ok github.com/novox/mesh-controller/internal/licences 44.408s ok github.com/novox/mesh-controller/internal/licences/adapters 1.029s ok github.com/novox/mesh-controller/internal/link 88.899s ok github.com/novox/mesh-controller/internal/lint 1.950s ok github.com/novox/mesh-controller/internal/outward 1.071s ok github.com/novox/mesh-controller/internal/overlay 1.051s ok github.com/novox/mesh-controller/internal/secrets 1.492s ok github.com/novox/mesh-controller/internal/store 12.849s ok github.com/novox/mesh-controller/internal/testbus 1.212s ok github.com/novox/mesh-controller/internal/token 1.016s ```
mesh-admin merged commit db953e7da8 into main 2026-10-07 21:55:17 +00:00
mesh-admin deleted branch replays/296-299-300 2026-10-07 21:55:17 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#124