Two faults found on review #130

2026-09-28T14:32:43Z

mesh-admin commented

2026-09-28 14:32:43 +00:00

No description provided.

mesh-admin added 1 commit 2026-09-28 14:32:43 +00:00

Two faults found on review 1c3f44a526

A second Accept value would have overwritten the first, because the header was Set per value rather
than Added. One value is all any caller passes today, so nothing was wrong — but a helper that
quietly keeps only the last of what it was given is a trap for whoever passes two.

And a replayed announcement that could not be written was published as an empty body: a fact on the
mesh that says nothing, which the reader can only log and drop. It is now said and skipped, because a
body that cannot be marshalled is this program's fault rather than the bus's.

mesh-admin merged commit 04f9f378b0 into main

2026-09-28 14:32:44 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-controller#130