novox/mesh-controller
3
0
Fork 0
Code Issues Pull Requests 3 Releases Wiki Activity

Two store-backed tests rotted because nothing runs the check (issue 177) #180

Merged
mesh-admin merged 1 commits from fix/the-converged-declaration-guard into main 2026-09-30 23:37:40 +00:00
Conversation 0 Commits 1 Files Changed 2
+10 -1
mesh-admin commented 2026-09-30 23:37:28 +00:00
Contributor
Copy Link
Copy Source

novox/hq issue 177. make check on main fails two tests, both since before tonight:

  • TestAConvergedDeclarationIsByteForByteWhatItWas still expected hosts on a container after c978aa7 (2026-09-30) took it off every container. Re-captured with the change named: a field an older host never sees is the one change the guard permits.
  • TestConvergingPreviewsThenChangesAndAdoptingKeepsWhatWasTaken: the adopted-anchor fixture reported no outward link after ADR 0140 (2026-09-28) made a filter depend on one. The fixture now reports one, as a real host does.

No code changes. make check is fully green on this branch. The build does not run the check, which is why nobody saw either; the issue records that.

novox/hq issue 177. `make check` on main fails two tests, both since before tonight: - `TestAConvergedDeclarationIsByteForByteWhatItWas` still expected `hosts` on a container after c978aa7 (2026-09-30) took it off every container. Re-captured with the change named: a field an older host never sees is the one change the guard permits. - `TestConvergingPreviewsThenChangesAndAdoptingKeepsWhatWasTaken`: the adopted-anchor fixture reported no outward link after ADR 0140 (2026-09-28) made a filter depend on one. The fixture now reports one, as a real host does. No code changes. `make check` is fully green on this branch. The build does not run the check, which is why nobody saw either; the issue records that.
mesh-admin added 1 commit 2026-09-30 23:37:28 +00:00
Two store-backed tests rotted because nothing runs the check (novox/hq issue 177) 7e4a0ecf9a 
The converged-declaration guard still expected `hosts` on a container after c978aa7 took it off
every container, and the adopted-anchor fixture reported no outward link after ADR 0140 made a
filter depend on one. Both failed under `make check` since 2026-09-28/30; the build does not run the
check, so the mesh never saw it. The guard is re-captured with the change named — a field an older
host never sees is the one change it permits — and the fixture reports a link as a real host does.
mesh-admin merged commit 5b39e95361 into main 2026-09-30 23:37:40 +00:00
mesh-admin deleted branch fix/the-converged-declaration-guard 2026-09-30 23:37:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jschoubben miel.truyen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#180