novox/mesh-controller
Archived
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

plan --diff says which modules a push would leave out, and why #181

Merged
mesh-admin merged 1 commits from fix/plan-diff-says-what-it-leaves-out into main 2026-10-09 12:41:16 +00:00
Conversation 2 Commits 1 Files Changed 1
+4
mesh-admin commented 2026-10-09 12:27:38 +00:00
Contributor
Copy Link
Copy Source

Symptom (2026-10-09). assign nfs-server ace succeeded, and plan ace diff=true answered ace: nothing would change — it was last sent exactly this. The module was in fact left out of the declaration: its file says ${setting:shares} and nothing set shares (ADR 0163 rule 6). The plain plan ace and push both say this; plan --diff did not, because a left-out module is absent from the body it diffs. A success-shaped answer for a module that will never reach the machine.

Change. The --diff path calls reportLeftOut before the diff, the same lines push and the plain plan print: ace: nfs-server left out — … nothing sets "shares" for it ….

Tests: go test ./cmd/mesh-controller/ passes; the line itself is reportLeftOut, unchanged.

Not merged: waits for a person's approval.

**Symptom (2026-10-09).** `assign nfs-server ace` succeeded, and `plan ace diff=true` answered `ace: nothing would change — it was last sent exactly this`. The module was in fact left out of the declaration: its file says `${setting:shares}` and nothing set `shares` (ADR 0163 rule 6). The plain `plan ace` and `push` both say this; `plan --diff` did not, because a left-out module is absent from the body it diffs. A success-shaped answer for a module that will never reach the machine. **Change.** The `--diff` path calls `reportLeftOut` before the diff, the same lines push and the plain plan print: `ace: nfs-server left out — … nothing sets "shares" for it …`. Tests: `go test ./cmd/mesh-controller/` passes; the line itself is `reportLeftOut`, unchanged. Not merged: waits for a person's approval.
mesh-admin added 1 commit 2026-10-09 12:27:38 +00:00
plan --diff says which modules a push would leave out and why, so a module just assigned whose settings cannot compose is not shown as "nothing would change"
mesh/merge-gate pass: builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step; every machine composes with the change as it…
Details
mesh/repo-check pass: its merge-check.sh passed
Details
mesh/delivery delivered
Details
54b04a7604
mesh-admin commented 2026-10-09 12:28:05 +00:00
Author
Contributor
Copy Link
Copy Source

Delivery novox/mesh-controller@54b04a760478 — delivered since 2026-10-09T12:57:37Z

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves

Machines

  • mesh-controller on novox: passed — healthy 3 times over 3m38s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 3 times over 3m41s
  • build-agent on the rest running it: sent
  • route-proxy on ace: passed — healthy 3 times over 3m26s
  • route-proxy on the rest running it: sent

Transitions

  • 2026-10-09 12:28 (new) → proposed (announced): novox/mesh-controller#181's head announced
  • 2026-10-09 12:33 proposed → checked (checked): the verdict names this commit
  • 2026-10-09 12:33 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-09 12:41 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-09 12:41 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path
  • 2026-10-09 12:57 delivering → delivered (done): its walk is done: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@54b04a760478` — **delivered** since 2026-10-09T12:57:37Z **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves **Machines** - mesh-controller on novox: passed — healthy 3 times over 3m38s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 3 times over 3m41s - build-agent on the rest running it: sent - route-proxy on ace: passed — healthy 3 times over 3m26s - route-proxy on the rest running it: sent **Transitions** - 2026-10-09 12:28 (new) → proposed (announced): novox/mesh-controller#181's head announced - 2026-10-09 12:33 proposed → checked (checked): the verdict names this commit - 2026-10-09 12:33 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-09 12:41 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-09 12:41 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path - 2026-10-09 12:57 delivering → delivered (done): its walk is done: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin commented 2026-10-09 12:33:46 +00:00
Author
Contributor
Copy Link
Copy Source

Merge check at 54b04a76

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves

Run by the build seat on shanks as build-1791548881020414164 (builds --log build-1791548881020414164).

--- the gate: build-agent, mesh-controller, route-proxy
mesh-controller: ok, 52 tool(s); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T12:24:01Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-09T12:24:01Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.039s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	209.772s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.055s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.055s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.053s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.198s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.100s
ok  	github.com/novox/mesh-controller/internal/broker	2.813s
ok  	github.com/novox/mesh-controller/internal/builder	1.977s
ok  	github.com/novox/mesh-controller/internal/catalogue	5.114s
ok  	github.com/novox/mesh-controller/internal/conditions	2.563s
ok  	github.com/novox/mesh-controller/internal/envfile	1.067s
ok  	github.com/novox/mesh-controller/internal/facts	1.065s
ok  	github.com/novox/mesh-controller/internal/identity	4.828s
ok  	github.com/novox/mesh-controller/internal/inventory	85.769s
ok  	github.com/novox/mesh-controller/internal/lease	17.726s
ok  	github.com/novox/mesh-controller/internal/licences	4.456s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.042s
ok  	github.com/novox/mesh-controller/internal/link	53.429s
ok  	github.com/novox/mesh-controller/internal/lint	2.248s
ok  	github.com/novox/mesh-controller/internal/outward	1.083s
ok  	github.com/novox/mesh-controller/internal/overlay	1.081s
ok  	github.com/novox/mesh-controller/internal/secrets	1.553s
ok  	github.com/novox/mesh-controller/internal/store	3.525s
ok  	github.com/novox/mesh-controller/internal/testbus	1.262s
ok  	github.com/novox/mesh-controller/internal/token	1.013s
**Merge check** at `54b04a76` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves Run by the build seat on shanks as `build-1791548881020414164` (`builds --log build-1791548881020414164`). ``` --- the gate: build-agent, mesh-controller, route-proxy mesh-controller: ok, 52 tool(s); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T12:24:01Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-09T12:24:01Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.039s ok github.com/novox/mesh-controller/cmd/mesh-controller 209.772s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.055s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.055s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.053s ok github.com/novox/mesh-controller/examples/route-proxy 1.198s ok github.com/novox/mesh-controller/internal/artifacts 1.100s ok github.com/novox/mesh-controller/internal/broker 2.813s ok github.com/novox/mesh-controller/internal/builder 1.977s ok github.com/novox/mesh-controller/internal/catalogue 5.114s ok github.com/novox/mesh-controller/internal/conditions 2.563s ok github.com/novox/mesh-controller/internal/envfile 1.067s ok github.com/novox/mesh-controller/internal/facts 1.065s ok github.com/novox/mesh-controller/internal/identity 4.828s ok github.com/novox/mesh-controller/internal/inventory 85.769s ok github.com/novox/mesh-controller/internal/lease 17.726s ok github.com/novox/mesh-controller/internal/licences 4.456s ok github.com/novox/mesh-controller/internal/licences/adapters 1.042s ok github.com/novox/mesh-controller/internal/link 53.429s ok github.com/novox/mesh-controller/internal/lint 2.248s ok github.com/novox/mesh-controller/internal/outward 1.083s ok github.com/novox/mesh-controller/internal/overlay 1.081s ok github.com/novox/mesh-controller/internal/secrets 1.553s ok github.com/novox/mesh-controller/internal/store 3.525s ok github.com/novox/mesh-controller/internal/testbus 1.262s ok github.com/novox/mesh-controller/internal/token 1.013s ```
mesh-admin merged commit c58516f819 into main 2026-10-09 12:41:16 +00:00
mesh-admin deleted branch fix/plan-diff-says-what-it-leaves-out 2026-10-09 12:41:16 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#181