Test the newest merge's order, a second reopening's gaps and sub-second merge times (hq issues 348, 349) #183

Merged
mesh-admin merged 1 commits from fix/348-349-test-gaps into main 2026-10-09 13:55:14 +00:00
Contributor

Follow-up to #179's review: tests only, for four paths no test held.

  • TestTheNewestMergeOfABranchIsTheOneMergedLast (inventory): of two earlier plans made in reverse order, NewestMergeOf takes the one merged last, in any state; a tie goes to the plan made last; another branch, another repository, a release and a plan without a merge time are never it; the merge time is kept to the nanosecond.
  • TestASecondReopeningKeepsBothGaps (conditions): two ClearSaying + reopen cycles in one keeper keep both gaps, the first raising, and OpenAt reads them.
  • TestAMergeTimeKeepsItsFractionOfASecond: planOfMerge keeps a sub-second merge time; merges a nanosecond apart keep their order through earlierOnTheBranch and laterOnTheBranch.

Each was mutation-proven: ordering asc, tie-break asc, branch, repository case, release filter, gaps dropped on clear, gaps dropped on reopen, merge time truncated to the second — each mutation fails a test. Local merge-check.sh passes. The redundant release is null stays.

Not merged; a person's approval decides.

Follow-up to #179's review: tests only, for four paths no test held. - `TestTheNewestMergeOfABranchIsTheOneMergedLast` (inventory): of two earlier plans made in reverse order, `NewestMergeOf` takes the one merged last, in any state; a tie goes to the plan made last; another branch, another repository, a release and a plan without a merge time are never it; the merge time is kept to the nanosecond. - `TestASecondReopeningKeepsBothGaps` (conditions): two `ClearSaying` + reopen cycles in one keeper keep both gaps, the first raising, and `OpenAt` reads them. - `TestAMergeTimeKeepsItsFractionOfASecond`: `planOfMerge` keeps a sub-second merge time; merges a nanosecond apart keep their order through `earlierOnTheBranch` and `laterOnTheBranch`. Each was mutation-proven: ordering asc, tie-break asc, branch, repository case, release filter, gaps dropped on clear, gaps dropped on reopen, merge time truncated to the second — each mutation fails a test. Local `merge-check.sh` passes. The redundant `release is null` stays. Not merged; a person's approval decides.
jschoubben added 1 commit 2026-10-09 13:29:33 +00:00
Test the newest merge's order, a second reopening's gaps and sub-second merge times (hq issues 348, 349)
mesh/merge-gate pass: builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step; every machine composes with the change as it…
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
d9a730307c
The review of PR 179 found four paths no test held: which of two earlier
plans NewestMergeOf takes, a tie between them, gaps kept across a second
reopening in one keeper, and a merge time's fraction of a second.
jschoubben force-pushed fix/348-349-test-gaps from 105b71629d to d9a730307c 2026-10-09 13:29:33 +00:00 Compare
Author
Contributor

Delivery novox/mesh-controller@d9a730307c31 — delivered since 2026-10-09T14:08:33Z

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves

Machines

  • mesh-controller on novox: passed — healthy 3 times over 3m39s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 3 times over 2m17s
  • build-agent on the rest running it: sent
  • route-proxy on ace: passed — healthy 3 times over 3m45s
  • route-proxy on the rest running it: sent

Transitions

  • 2026-10-09 13:29 (new) → proposed (announced): novox/mesh-controller#183's head announced
  • 2026-10-09 13:41 proposed → checked (checked): the verdict names this commit
  • 2026-10-09 13:41 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-09 13:55 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-09 13:55 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path
  • 2026-10-09 14:08 delivering → delivered (done): its walk is done: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@d9a730307c31` — **delivered** since 2026-10-09T14:08:33Z **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves **Machines** - mesh-controller on novox: passed — healthy 3 times over 3m39s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 3 times over 2m17s - build-agent on the rest running it: sent - route-proxy on ace: passed — healthy 3 times over 3m45s - route-proxy on the rest running it: sent **Transitions** - 2026-10-09 13:29 (new) → proposed (announced): novox/mesh-controller#183's head announced - 2026-10-09 13:41 proposed → checked (checked): the verdict names this commit - 2026-10-09 13:41 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-09 13:55 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-09 13:55 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path - 2026-10-09 14:08 delivering → delivered (done): its walk is done: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at d9a73030

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves

Run by the build seat on g14 as build-1791552588134791989 (builds --log build-1791552588134791989).

--- the gate: build-agent, mesh-controller, route-proxy
mesh-controller: ok, 52 tool(s); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T13:27:32Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-09T13:27:32Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.037s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	204.500s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.008s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.011s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.008s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.199s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.058s
ok  	github.com/novox/mesh-controller/internal/broker	2.632s
ok  	github.com/novox/mesh-controller/internal/builder	1.773s
ok  	github.com/novox/mesh-controller/internal/catalogue	4.393s
ok  	github.com/novox/mesh-controller/internal/conditions	2.342s
ok  	github.com/novox/mesh-controller/internal/envfile	1.033s
ok  	github.com/novox/mesh-controller/internal/facts	1.035s
ok  	github.com/novox/mesh-controller/internal/identity	4.734s
ok  	github.com/novox/mesh-controller/internal/inventory	73.505s
ok  	github.com/novox/mesh-controller/internal/lease	17.700s
ok  	github.com/novox/mesh-controller/internal/licences	4.331s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.008s
ok  	github.com/novox/mesh-controller/internal/link	51.074s
ok  	github.com/novox/mesh-controller/internal/lint	1.882s
ok  	github.com/novox/mesh-controller/internal/outward	1.030s
ok  	github.com/novox/mesh-controller/internal/overlay	1.020s
ok  	github.com/novox/mesh-controller/internal/secrets	1.414s
ok  	github.com/novox/mesh-controller/internal/store	3.803s
ok  	github.com/novox/mesh-controller/internal/testbus	1.162s
ok  	github.com/novox/mesh-controller/internal/token	1.014s
**Merge check** at `d9a73030` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves Run by the build seat on g14 as `build-1791552588134791989` (`builds --log build-1791552588134791989`). ``` --- the gate: build-agent, mesh-controller, route-proxy mesh-controller: ok, 52 tool(s); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T13:27:32Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-09T13:27:32Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.037s ok github.com/novox/mesh-controller/cmd/mesh-controller 204.500s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.008s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.011s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.008s ok github.com/novox/mesh-controller/examples/route-proxy 1.199s ok github.com/novox/mesh-controller/internal/artifacts 1.058s ok github.com/novox/mesh-controller/internal/broker 2.632s ok github.com/novox/mesh-controller/internal/builder 1.773s ok github.com/novox/mesh-controller/internal/catalogue 4.393s ok github.com/novox/mesh-controller/internal/conditions 2.342s ok github.com/novox/mesh-controller/internal/envfile 1.033s ok github.com/novox/mesh-controller/internal/facts 1.035s ok github.com/novox/mesh-controller/internal/identity 4.734s ok github.com/novox/mesh-controller/internal/inventory 73.505s ok github.com/novox/mesh-controller/internal/lease 17.700s ok github.com/novox/mesh-controller/internal/licences 4.331s ok github.com/novox/mesh-controller/internal/licences/adapters 1.008s ok github.com/novox/mesh-controller/internal/link 51.074s ok github.com/novox/mesh-controller/internal/lint 1.882s ok github.com/novox/mesh-controller/internal/outward 1.030s ok github.com/novox/mesh-controller/internal/overlay 1.020s ok github.com/novox/mesh-controller/internal/secrets 1.414s ok github.com/novox/mesh-controller/internal/store 3.803s ok github.com/novox/mesh-controller/internal/testbus 1.162s ok github.com/novox/mesh-controller/internal/token 1.014s ```
mesh-admin merged commit ef26d4cb0f into main 2026-10-09 13:55:14 +00:00
mesh-admin deleted branch fix/348-349-test-gaps 2026-10-09 13:55:15 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#183