A misspelled placeholder is refused, never written out as text (issue 231) #211

Merged
mesh-admin merged 3 commits from fix/231-a-misspelled-placeholder-is-refused into main 2026-10-11 00:31:47 +00:00
Contributor

Fixes novox/hq issue 231 (a misspelled placeholder is written out as text), except for its undeclared-setting half, which is handed to issue 398 (see below).

What was wrong

Each placeholder namespace is filled by its own pass with its own pattern, in the fields that pass reads. A ${word:…} that no pattern matched (${machnie:address}, ${shel:zsh:first}, ${setting:Undeclared}) was left in the resource as written and reached the machine as a literal value. The catalogue check answered ok.

What changes

  • internal/catalogue/unconsumed_placeholder.go adds unconsumedPlaceholders(module, resource) and one table of which fields each pass fills, by resource type. The table is read from settingInto, dirInto, accessInto, intoFile, boundInto, portInto, seatInto, machineInto and contributionsInto.
  • Every string in a resource is checked, including nested lists and maps. A refusal names the module, the resource, the field (for example content or env.NAME) and the token. It refuses three things:
    1. a known namespace in a field its pass does not read ("not filled in this field", with where it is filled; a secret keeps its ADR 0086 reason);
    2. any other ${<known namespace>:, case-insensitively, unless a shell parameter operator (:-, :=, :+, :?) follows the colon. So ${Machine:address}, ${Dir:x}, ${machine:.address}, ${machine: address} and an unclosed ${machine:address are refused, while ${PORT:-8080}, ${SHELL:-/bin/sh}, ${SECRET:?unset} and ${dir:-/tmp} pass;
    3. a namespace-shaped placeholder of an unknown word.
  • One function at both points, always over the definition as the manifest wrote it.
    • The catalogue check, the strict parse that registration also runs, calls it from contributionPlaceholderProblems.
    • Composition calls it in Declaration, over m.Resources, before any pass runs, beside notTranscribed.
    • What a setting, a merged JSON setting or a binding puts into a file is therefore never checked. Values like Log4j's ${env:…} or Spring's ${timeout:30} reach the machine as set.
    • The check and composition refuse the same things.
  • Contributed shell code is not a resource and is never checked (ADR 0204).

The bounds chosen

  • Namespace-shaped means ${ + a lower-case word + : + a key that begins with a letter or a digit and holds no whitespace, brace or $.
  • Shell syntax passes: ${NAME:-…}, ${(%):-…}, ${1:-.}, any word followed by :-, :=, :+ or :? (${count:-}, ${trial:+…}, ${PORT:-8080}).
  • A zsh modifier (${path:t}) or a bash substring (${where:0:12}) in a resource's own text is refused. The refusal points to the module's contributed shell code.
  • The case-insensitive rule covers only the twelve known namespace words (access, bound, consumer, contribution, dir, environment, machine, port, seat, secret, setting, shell).

Not met here: undeclared settings

The issue also asks that a setting a module uses but does not declare be refused. That is ADR 0164's refusal of an undeclared key. It is not built, and it is tracked by issue 398, to which that half is handed. Under ADR 0262 an operator's value is undeclared on purpose and is refused at composition only when no layer sets it. This change refuses only a setting key no definition could declare (${setting:Undeclared}).

What I checked

  • unconsumed_placeholder_test.go:
    • The issue's four placeholders: three refused by name, module and field, both at the check and at composition; ${XDG_CACHE_HOME:-x} passes through byte for byte.
    • The five misspellings of a known namespace, refused at both points.
    • ${machine:name} in a process's env, refused at both points.
    • The shell operators after known words (${PORT:-8080}, ${SHELL:-/bin/sh}, ${SECRET:?unset}, ${dir:-/tmp} in content, and ${PORT:-80} in env) pass at both points.
    • Contributed zsh code holding ${path:t}, untouched.
    • A setting ${labels:instance} filled through ${setting:template}, and a merged JSON setting ${level:upper}, both compose unchanged.
    • Each case failed on the head before its fix: on main the refusals were accepted; on 360c318 the value case and the misspellings failed; on 525b2c1 the shell-operator cases were refused.
  • Scan of origin/main of mesh-catalog (372b6c2, 125 manifests), mesh-media-catalog (81cff9b, 12 manifests) and the module.json of mesh-controller, mesh-host, mesh-sdk, mesh-tools and mesh-tools-go: mesh-controller module check over all of them gives output identical to main's binary. Nothing live is refused.
  • go vet ./... is clean. go test ./internal/catalogue/ ./cmd/mesh-controller/ passes except TestTheServiceManagerReadsTheSystemdRenderingAsMeant, which fails identically on main on this workstation because it reads the local systemd environment.

What I did not verify

  • Composition of every machine against the live store; the merge gate does that.
  • Manifests registered from outside these repositories.
  • Left as it is, per review: one bad stored manifest makes the whole machine unresolvable rather than leaving that module out (as notTranscribed beside it does).
Fixes novox/hq issue 231 (a misspelled placeholder is written out as text), except for its undeclared-setting half, which is handed to issue 398 (see below). ## What was wrong Each placeholder namespace is filled by its own pass with its own pattern, in the fields that pass reads. A `${word:…}` that no pattern matched (`${machnie:address}`, `${shel:zsh:first}`, `${setting:Undeclared}`) was left in the resource as written and reached the machine as a literal value. The catalogue check answered ok. ## What changes - `internal/catalogue/unconsumed_placeholder.go` adds `unconsumedPlaceholders(module, resource)` and one table of which fields each pass fills, by resource type. The table is read from settingInto, dirInto, accessInto, intoFile, boundInto, portInto, seatInto, machineInto and contributionsInto. - Every string in a resource is checked, including nested lists and maps. A refusal names the module, the resource, the field (for example `content` or `env.NAME`) and the token. It refuses three things: 1. a known namespace in a field its pass does not read ("not filled in this field", with where it is filled; a secret keeps its ADR 0086 reason); 2. any other `${<known namespace>:`, case-insensitively, unless a shell parameter operator (`:-`, `:=`, `:+`, `:?`) follows the colon. So `${Machine:address}`, `${Dir:x}`, `${machine:.address}`, `${machine: address}` and an unclosed `${machine:address` are refused, while `${PORT:-8080}`, `${SHELL:-/bin/sh}`, `${SECRET:?unset}` and `${dir:-/tmp}` pass; 3. a namespace-shaped placeholder of an unknown word. - **One function at both points, always over the definition as the manifest wrote it.** - The catalogue check, the strict parse that registration also runs, calls it from `contributionPlaceholderProblems`. - Composition calls it in `Declaration`, over `m.Resources`, before any pass runs, beside `notTranscribed`. - What a setting, a merged JSON setting or a binding puts into a file is therefore never checked. Values like Log4j's `${env:…}` or Spring's `${timeout:30}` reach the machine as set. - The check and composition refuse the same things. - Contributed shell code is not a resource and is never checked (ADR 0204). ## The bounds chosen - Namespace-shaped means `${` + a lower-case word + `:` + a key that begins with a letter or a digit and holds no whitespace, brace or `$`. - Shell syntax passes: `${NAME:-…}`, `${(%):-…}`, `${1:-.}`, any word followed by `:-`, `:=`, `:+` or `:?` (`${count:-}`, `${trial:+…}`, `${PORT:-8080}`). - A zsh modifier (`${path:t}`) or a bash substring (`${where:0:12}`) in a resource's own text is refused. The refusal points to the module's contributed shell code. - The case-insensitive rule covers only the twelve known namespace words (access, bound, consumer, contribution, dir, environment, machine, port, seat, secret, setting, shell). ## Not met here: undeclared settings The issue also asks that a setting a module uses but does not declare be refused. That is ADR 0164's refusal of an undeclared key. It is not built, and it is tracked by issue 398, to which that half is handed. Under ADR 0262 an operator's value is undeclared on purpose and is refused at composition only when no layer sets it. This change refuses only a setting key no definition could declare (`${setting:Undeclared}`). ## What I checked - `unconsumed_placeholder_test.go`: - The issue's four placeholders: three refused by name, module and field, both at the check and at composition; `${XDG_CACHE_HOME:-x}` passes through byte for byte. - The five misspellings of a known namespace, refused at both points. - `${machine:name}` in a process's env, refused at both points. - The shell operators after known words (`${PORT:-8080}`, `${SHELL:-/bin/sh}`, `${SECRET:?unset}`, `${dir:-/tmp}` in content, and `${PORT:-80}` in env) pass at both points. - Contributed zsh code holding `${path:t}`, untouched. - A setting `${labels:instance}` filled through `${setting:template}`, and a merged JSON setting `${level:upper}`, both compose unchanged. - Each case failed on the head before its fix: on main the refusals were accepted; on 360c318 the value case and the misspellings failed; on 525b2c1 the shell-operator cases were refused. - Scan of origin/main of mesh-catalog (372b6c2, 125 manifests), mesh-media-catalog (81cff9b, 12 manifests) and the module.json of mesh-controller, mesh-host, mesh-sdk, mesh-tools and mesh-tools-go: `mesh-controller module check` over all of them gives output identical to main's binary. Nothing live is refused. - `go vet ./...` is clean. `go test ./internal/catalogue/ ./cmd/mesh-controller/` passes except `TestTheServiceManagerReadsTheSystemdRenderingAsMeant`, which fails identically on main on this workstation because it reads the local systemd environment. ## What I did not verify - Composition of every machine against the live store; the merge gate does that. - Manifests registered from outside these repositories. - Left as it is, per review: one bad stored manifest makes the whole machine unresolvable rather than leaving that module out (as `notTranscribed` beside it does).
mesh-admin added 1 commit 2026-10-11 00:06:34 +00:00
Refuse a placeholder no pass consumes, so a misspelling never reaches a machine as text (issue 231)
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery superseded: a newer head of the same pull request
360c318e85
Author
Contributor

Delivery novox/mesh-controller@dc62fd0075f4 — delivered since 2026-10-11T00:46:15Z

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves

Machines

  • mesh-controller on novox: passed — healthy 3 times over 3m38s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 3 times over 3m36s
  • build-agent on the rest running it: sent

Transitions

  • 2026-10-11 00:20 (new) → proposed (announced): novox/mesh-controller#211's head announced
  • 2026-10-11 00:28 proposed → checked (checked): the verdict names this commit
  • 2026-10-11 00:28 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-11 00:33 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-11 00:33 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-11 00:46 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@dc62fd0075f4` — **delivered** since 2026-10-11T00:46:15Z **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves **Machines** - mesh-controller on novox: passed — healthy 3 times over 3m38s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 3 times over 3m36s - build-agent on the rest running it: sent **Transitions** - 2026-10-11 00:20 (new) → proposed (announced): novox/mesh-controller#211's head announced - 2026-10-11 00:28 proposed → checked (checked): the verdict names this commit - 2026-10-11 00:28 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-11 00:33 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-11 00:33 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-11 00:46 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 360c318e

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • read by no module's build: internal/catalogue/unconsumed_placeholder_test.go

Run by the build seat on shanks as build-1791677224046515398 (builds --log build-1791677224046515398).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T00:04:44Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T00:04:44Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - internal/catalogue/unconsumed_placeholder_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.035s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	232.844s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.018s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.047s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.017s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.245s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.085s
ok  	github.com/novox/mesh-controller/internal/broker	3.025s
ok  	github.com/novox/mesh-controller/internal/builder	2.933s
ok  	github.com/novox/mesh-controller/internal/catalogue	6.349s
ok  	github.com/novox/mesh-controller/internal/conditions	2.601s
ok  	github.com/novox/mesh-controller/internal/envfile	1.061s
ok  	github.com/novox/mesh-controller/internal/facts	1.066s
ok  	github.com/novox/mesh-controller/internal/identity	4.979s
ok  	github.com/novox/mesh-controller/internal/inventory	92.821s
ok  	github.com/novox/mesh-controller/internal/lease	17.707s
ok  	github.com/novox/mesh-controller/internal/licences	4.653s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.063s
ok  	github.com/novox/mesh-controller/internal/link	55.170s
ok  	github.com/novox/mesh-controller/internal/lint	2.341s
ok  	github.com/novox/mesh-controller/internal/outward	1.091s
ok  	github.com/novox/mesh-controller/internal/overlay	1.079s
ok  	github.com/novox/mesh-controller/internal/secrets	1.550s
ok  	github.com/novox/mesh-controller/internal/store	3.621s
ok  	github.com/novox/mesh-controller/internal/testbus	1.247s
ok  	github.com/novox/mesh-controller/internal/token	1.015s
**Merge check** at `360c318e` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - read by no module's build: internal/catalogue/unconsumed_placeholder_test.go Run by the build seat on shanks as `build-1791677224046515398` (`builds --log build-1791677224046515398`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T00:04:44Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T00:04:44Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - internal/catalogue/unconsumed_placeholder_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.035s ok github.com/novox/mesh-controller/cmd/mesh-controller 232.844s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.018s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.047s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.017s ok github.com/novox/mesh-controller/examples/route-proxy 1.245s ok github.com/novox/mesh-controller/internal/artifacts 1.085s ok github.com/novox/mesh-controller/internal/broker 3.025s ok github.com/novox/mesh-controller/internal/builder 2.933s ok github.com/novox/mesh-controller/internal/catalogue 6.349s ok github.com/novox/mesh-controller/internal/conditions 2.601s ok github.com/novox/mesh-controller/internal/envfile 1.061s ok github.com/novox/mesh-controller/internal/facts 1.066s ok github.com/novox/mesh-controller/internal/identity 4.979s ok github.com/novox/mesh-controller/internal/inventory 92.821s ok github.com/novox/mesh-controller/internal/lease 17.707s ok github.com/novox/mesh-controller/internal/licences 4.653s ok github.com/novox/mesh-controller/internal/licences/adapters 1.063s ok github.com/novox/mesh-controller/internal/link 55.170s ok github.com/novox/mesh-controller/internal/lint 2.341s ok github.com/novox/mesh-controller/internal/outward 1.091s ok github.com/novox/mesh-controller/internal/overlay 1.079s ok github.com/novox/mesh-controller/internal/secrets 1.550s ok github.com/novox/mesh-controller/internal/store 3.621s ok github.com/novox/mesh-controller/internal/testbus 1.247s ok github.com/novox/mesh-controller/internal/token 1.015s ```
jschoubben added 1 commit 2026-10-11 00:15:39 +00:00
Sweep the definition, not the filled values, and judge each field alike at check and composition (issue 231)
mesh/delivery superseded: a newer head of the same pull request
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
525b2c1a11
The first sweep ran at composition over the resource after settings, bindings and
machine facts were filled, so an operator's value such as ${labels:instance} was
refused as a misspelling its author never wrote, and the whole machine got nothing.
Both points now sweep the resource as the manifest wrote it, against one table of
which fields each pass fills, so the check and composition refuse the same things.
Any ${<known namespace>: its pattern does not take is refused whatever its case or key.

Issue 231's undeclared-setting half is not met here: refusing a key the module does
not declare (ADR 0164) is not built and is handed to issue 398.
jschoubben added 1 commit 2026-10-11 00:20:46 +00:00
Let a shell parameter operator after a known word pass, so ${PORT:-8080} is not refused (issue 231)
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
dc62fd0075
The case-insensitive rule for the mesh's namespace words took ${PORT:-8080},
${SHELL:-/bin/sh}, ${SECRET:?unset} and ${dir:-/tmp} for misspellings, though they
are among the commonest lines of a script or env file. A :-, :=, :+ or :? after the
colon is the shell's, whatever the word's case.
Author
Contributor

Merge check at 525b2c1a

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • read by no module's build: internal/catalogue/unconsumed_placeholder_test.go

Run by the build seat on shanks as build-1791677742004471001 (builds --log build-1791677742004471001).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T00:14:44Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T00:14:44Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - internal/catalogue/unconsumed_placeholder_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.040s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	291.560s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.030s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.062s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.055s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.258s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.095s
ok  	github.com/novox/mesh-controller/internal/broker	2.882s
ok  	github.com/novox/mesh-controller/internal/builder	2.756s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.128s
ok  	github.com/novox/mesh-controller/internal/conditions	2.630s
ok  	github.com/novox/mesh-controller/internal/envfile	1.060s
ok  	github.com/novox/mesh-controller/internal/facts	1.061s
ok  	github.com/novox/mesh-controller/internal/identity	4.869s
ok  	github.com/novox/mesh-controller/internal/inventory	126.554s
ok  	github.com/novox/mesh-controller/internal/lease	17.746s
ok  	github.com/novox/mesh-controller/internal/licences	4.430s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.057s
ok  	github.com/novox/mesh-controller/internal/link	55.615s
ok  	github.com/novox/mesh-controller/internal/lint	2.384s
ok  	github.com/novox/mesh-controller/internal/outward	1.084s
ok  	github.com/novox/mesh-controller/internal/overlay	1.075s
ok  	github.com/novox/mesh-controller/internal/secrets	1.536s
ok  	github.com/novox/mesh-controller/internal/store	3.543s
ok  	github.com/novox/mesh-controller/internal/testbus	1.231s
ok  	github.com/novox/mesh-controller/internal/token	1.016s
**Merge check** at `525b2c1a` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - read by no module's build: internal/catalogue/unconsumed_placeholder_test.go Run by the build seat on shanks as `build-1791677742004471001` (`builds --log build-1791677742004471001`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T00:14:44Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T00:14:44Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - internal/catalogue/unconsumed_placeholder_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.040s ok github.com/novox/mesh-controller/cmd/mesh-controller 291.560s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.030s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.062s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.055s ok github.com/novox/mesh-controller/examples/route-proxy 1.258s ok github.com/novox/mesh-controller/internal/artifacts 1.095s ok github.com/novox/mesh-controller/internal/broker 2.882s ok github.com/novox/mesh-controller/internal/builder 2.756s ok github.com/novox/mesh-controller/internal/catalogue 7.128s ok github.com/novox/mesh-controller/internal/conditions 2.630s ok github.com/novox/mesh-controller/internal/envfile 1.060s ok github.com/novox/mesh-controller/internal/facts 1.061s ok github.com/novox/mesh-controller/internal/identity 4.869s ok github.com/novox/mesh-controller/internal/inventory 126.554s ok github.com/novox/mesh-controller/internal/lease 17.746s ok github.com/novox/mesh-controller/internal/licences 4.430s ok github.com/novox/mesh-controller/internal/licences/adapters 1.057s ok github.com/novox/mesh-controller/internal/link 55.615s ok github.com/novox/mesh-controller/internal/lint 2.384s ok github.com/novox/mesh-controller/internal/outward 1.084s ok github.com/novox/mesh-controller/internal/overlay 1.075s ok github.com/novox/mesh-controller/internal/secrets 1.536s ok github.com/novox/mesh-controller/internal/store 3.543s ok github.com/novox/mesh-controller/internal/testbus 1.231s ok github.com/novox/mesh-controller/internal/token 1.016s ```
Author
Contributor

Merge check at dc62fd00

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • read by no module's build: internal/catalogue/unconsumed_placeholder_test.go

Run by the build seat on novox as build-1791678051197998049 (builds --log build-1791678051197998049).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T00:14:44Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T00:14:44Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - internal/catalogue/unconsumed_placeholder_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.143s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	266.649s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.024s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.036s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.019s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.148s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.071s
ok  	github.com/novox/mesh-controller/internal/broker	2.976s
ok  	github.com/novox/mesh-controller/internal/builder	3.738s
ok  	github.com/novox/mesh-controller/internal/catalogue	8.518s
ok  	github.com/novox/mesh-controller/internal/conditions	2.659s
ok  	github.com/novox/mesh-controller/internal/envfile	1.030s
ok  	github.com/novox/mesh-controller/internal/facts	1.035s
ok  	github.com/novox/mesh-controller/internal/identity	5.575s
ok  	github.com/novox/mesh-controller/internal/inventory	104.982s
ok  	github.com/novox/mesh-controller/internal/lease	17.695s
ok  	github.com/novox/mesh-controller/internal/licences	5.093s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.011s
ok  	github.com/novox/mesh-controller/internal/link	56.875s
ok  	github.com/novox/mesh-controller/internal/lint	2.473s
ok  	github.com/novox/mesh-controller/internal/outward	1.052s
ok  	github.com/novox/mesh-controller/internal/overlay	1.027s
ok  	github.com/novox/mesh-controller/internal/secrets	1.505s
ok  	github.com/novox/mesh-controller/internal/store	3.498s
ok  	github.com/novox/mesh-controller/internal/testbus	1.190s
ok  	github.com/novox/mesh-controller/internal/token	1.021s
**Merge check** at `dc62fd00` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - read by no module's build: internal/catalogue/unconsumed_placeholder_test.go Run by the build seat on novox as `build-1791678051197998049` (`builds --log build-1791678051197998049`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T00:14:44Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T00:14:44Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - internal/catalogue/unconsumed_placeholder_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.143s ok github.com/novox/mesh-controller/cmd/mesh-controller 266.649s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.024s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.036s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.019s ok github.com/novox/mesh-controller/examples/route-proxy 1.148s ok github.com/novox/mesh-controller/internal/artifacts 1.071s ok github.com/novox/mesh-controller/internal/broker 2.976s ok github.com/novox/mesh-controller/internal/builder 3.738s ok github.com/novox/mesh-controller/internal/catalogue 8.518s ok github.com/novox/mesh-controller/internal/conditions 2.659s ok github.com/novox/mesh-controller/internal/envfile 1.030s ok github.com/novox/mesh-controller/internal/facts 1.035s ok github.com/novox/mesh-controller/internal/identity 5.575s ok github.com/novox/mesh-controller/internal/inventory 104.982s ok github.com/novox/mesh-controller/internal/lease 17.695s ok github.com/novox/mesh-controller/internal/licences 5.093s ok github.com/novox/mesh-controller/internal/licences/adapters 1.011s ok github.com/novox/mesh-controller/internal/link 56.875s ok github.com/novox/mesh-controller/internal/lint 2.473s ok github.com/novox/mesh-controller/internal/outward 1.052s ok github.com/novox/mesh-controller/internal/overlay 1.027s ok github.com/novox/mesh-controller/internal/secrets 1.505s ok github.com/novox/mesh-controller/internal/store 3.498s ok github.com/novox/mesh-controller/internal/testbus 1.190s ok github.com/novox/mesh-controller/internal/token 1.021s ```
mesh-admin merged commit 5bddb16514 into main 2026-10-11 00:31:47 +00:00
mesh-admin deleted branch fix/231-a-misspelled-placeholder-is-refused 2026-10-11 00:31:47 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#211