broker: each credential may call tools only in its own name on the caller-named subjects (hq issue 365) #224

Merged
mesh-admin merged 2 commits from fix/365-a-tool-call-names-its-caller into main 2026-10-11 09:31:37 +00:00
Contributor

Fixes the grants part of hq issue 365 (a module is never told who called its tool), built to the issue's decision of 2026-10-11 02:37, by ADR 0259 section 3's precedent for asks.

What changes. internal/broker/callers.go: wherever a principal is granted to call a tool on the tool kind, it is also granted the same call on the call kind with its own bus user as the last token (dots written ~: shanks~node-tools, person~ada, node~one, two~shop); wherever it may answer a tool, it may answer the caller-named calls naming anybody. Derived from the tool grants in one place at the end of PermissionsFor, so every kind of caller (persons, the runtimes, modules that invoke, node-engines' health checks) gets it by construction. ControllerOnly (the desk's hidden prompt) is denied under call too.

Why call and not the tool subject with a token appended. Every existing call grant is a wildcard over tool (.tool.<t>.* for @node addressing, mesh.mod.*.tool.>), which would match any caller appended: the caller could name another.

One release overlap. The old tool grants stay, so no caller or runtime loses its way to a tool during roll-out; their retirement is hq issue 464 (opened for it). The controller's own grants are not changed this release: they are also the installer's first user list (TestTheInstallersFirstUserListIsWhatTheControllerWouldCompose, judged against the node-engine the mesh runs), so changing them needs a mesh-host delivery first. The controller keeps calling and serving its seat on the old subjects; a caller-named call to its seat reaches nobody and the runtime asks the old subject at once. Noted on issue 464.

Tests (fail first on main's grants). callers_test.go: each kind of credential may call in its own name and not in another's, and holders hear calls naming anybody; old subjects still granted; the desk's prompt stays the controller's under call; the controller has no call grants this release. callers_live_test.go: a real nats-server loaded with the composed accounts answers a runtime calling in its own name and refuses (permissions violation) its call naming another (fails on main). Golden composition updated (each module now also subscribes mesh.mod.<m>.call.>); invokes, person and people tests widened to the call kind. make check passes (26 packages, store-backed, race detector).

Companion pull requests, branch fix/365-a-tool-call-names-its-caller: mesh-sdk#20, mesh-tools#27, mesh-catalog#207.

Order: this one rolls first among the runtime-facing changes (grants delivered to the bus before mesh-tools#27 reaches the nodes); merge it only while no other controller or node-engine plan is mid-gate.

Fixes the grants part of hq issue 365 (a module is never told who called its tool), built to the issue's decision of 2026-10-11 02:37, by ADR 0259 section 3's precedent for asks. **What changes.** `internal/broker/callers.go`: wherever a principal is granted to call a tool on the `tool` kind, it is also granted the same call on the `call` kind with its own bus user as the last token (dots written `~`: `shanks~node-tools`, `person~ada`, `node~one`, `two~shop`); wherever it may answer a tool, it may answer the caller-named calls naming anybody. Derived from the `tool` grants in one place at the end of `PermissionsFor`, so every kind of caller (persons, the runtimes, modules that invoke, node-engines' health checks) gets it by construction. `ControllerOnly` (the desk's hidden prompt) is denied under `call` too. **Why `call` and not the `tool` subject with a token appended.** Every existing call grant is a wildcard over `tool` (`.tool.<t>.*` for @node addressing, `mesh.mod.*.tool.>`), which would match any caller appended: the caller could name another. **One release overlap.** The old `tool` grants stay, so no caller or runtime loses its way to a tool during roll-out; their retirement is hq issue 464 (opened for it). **The controller's own grants are not changed this release**: they are also the installer's first user list (TestTheInstallersFirstUserListIsWhatTheControllerWouldCompose, judged against the node-engine the mesh runs), so changing them needs a mesh-host delivery first. The controller keeps calling and serving its seat on the old subjects; a caller-named call to its seat reaches nobody and the runtime asks the old subject at once. Noted on issue 464. **Tests (fail first on main's grants).** callers_test.go: each kind of credential may call in its own name and not in another's, and holders hear calls naming anybody; old subjects still granted; the desk's prompt stays the controller's under `call`; the controller has no `call` grants this release. callers_live_test.go: a real nats-server loaded with the composed accounts answers a runtime calling in its own name and refuses (permissions violation) its call naming another (fails on main). Golden composition updated (each module now also subscribes `mesh.mod.<m>.call.>`); invokes, person and people tests widened to the `call` kind. `make check` passes (26 packages, store-backed, race detector). Companion pull requests, branch fix/365-a-tool-call-names-its-caller: mesh-sdk#20, mesh-tools#27, mesh-catalog#207. **Order:** this one rolls first among the runtime-facing changes (grants delivered to the bus before mesh-tools#27 reaches the nodes); merge it only while no other controller or node-engine plan is mid-gate.
mesh-admin added 2 commits 2026-10-11 03:47:52 +00:00
Every grant to call a tool is granted again under the call kind, with the
credential's own bus user as the last token, and every grant to answer one is
granted for calls naming any caller: the caller of a tool call becomes a fact
the bus enforces, as ADR 0259 section 3 made the asker of an ask. A kind of its
own because every existing tool grant is a wildcard that would match any caller
appended. The old tool grants stay for one release so nothing loses its way to a
tool (hq issue 464); the controller's own grants move with that issue, since
they are also the installer's first user list.
inventory: a person's one tool is granted naming that person as the caller too (hq issue 365)
mesh/merge-gate pass: builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step; every machine composes with the change as it…
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
mesh/delivery-group group fix/365-a-tool-call-names-its-caller merged: every member is merged
ebca7816bf
Author
Contributor

Delivery novox/mesh-controller@ebca7816bf08 — delivered since 2026-10-11T09:51:47Z

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves

Group fix/365-a-tool-call-names-its-caller, in order: novox/mesh-controller@ebca7816bf → novox/mesh-catalog@61f81d4454 → novox/mesh-sdk@d9e24e95a2 → novox/mesh-tools@ab0f888d67

Machines

  • mesh-controller on novox: passed — healthy 3 times over 4m7s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 3 times over 3m24s
  • build-agent on the rest running it: sent
  • mesh-host on ace: passed — healthy 3 times over 3m43s
  • mesh-tools on every machine running it: sent
  • node-tools on ace: passed — judged with mesh-host: healthy 3 times over 3m43s
  • route-proxy on ace: passed — judged with mesh-host: healthy 3 times over 3m43s
  • mesh-host on the rest running it: sent
  • node-tools on the rest running it: sent
  • route-proxy on the rest running it: sent

Transitions

  • 2026-10-11 03:47 (new) → proposed (announced): novox/mesh-controller#224's head announced
  • 2026-10-11 03:54 proposed → checked (checked): the verdict names this commit
  • 2026-10-11 03:54 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-11 09:33 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-11 09:33 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-11 09:51 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@ebca7816bf08` — **delivered** since 2026-10-11T09:51:47Z **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves **Group** `fix/365-a-tool-call-names-its-caller`, in order: novox/mesh-controller@ebca7816bf08 → novox/mesh-catalog@61f81d44547a → novox/mesh-sdk@d9e24e95a242 → novox/mesh-tools@ab0f888d67d2 - novox/mesh-controller@ebca7816bf08 before novox/mesh-catalog@61f81d44547a: built by - novox/mesh-controller@ebca7816bf08 before novox/mesh-sdk@d9e24e95a242: built by - novox/mesh-controller@ebca7816bf08 before novox/mesh-tools@ab0f888d67d2: built by - composed together: pass — every machine composes with the change as it did without (4 of 4 compose) **Machines** - mesh-controller on novox: passed — healthy 3 times over 4m7s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 3 times over 3m24s - build-agent on the rest running it: sent - mesh-host on ace: passed — healthy 3 times over 3m43s - mesh-tools on every machine running it: sent - node-tools on ace: passed — judged with mesh-host: healthy 3 times over 3m43s - route-proxy on ace: passed — judged with mesh-host: healthy 3 times over 3m43s - mesh-host on the rest running it: sent - node-tools on the rest running it: sent - route-proxy on the rest running it: sent **Transitions** - 2026-10-11 03:47 (new) → proposed (announced): novox/mesh-controller#224's head announced - 2026-10-11 03:54 proposed → checked (checked): the verdict names this commit - 2026-10-11 03:54 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-11 09:33 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-11 09:33 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-11 09:51 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at ebca7816

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • tier 2: route-proxy
  • ace: receives build-agent, route-proxy
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent, route-proxy
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • route-proxy provides route: its consumers are sent again after it
  • route-proxy keeps data (ADR 0233): what it holds is backed up before it moves
  • read by no module's build: internal/broker/callers_live_test.go, internal/broker/callers_test.go, internal/broker/invokes_test.go, internal/broker/nats_test.go, internal/broker/testdata/composed.conf, internal/inventory/people_test.go

Run by the build seat on g14 as build-1791690475018824938 (builds --log build-1791690475018824938).

--- the gate: build-agent, mesh-controller, route-proxy
mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T03:09:01Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T03:09:01Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy

notes:
  - internal/broker/callers_live_test.go, internal/broker/callers_test.go, internal/broker/invokes_test.go, internal/broker/nats_test.go, internal/broker/testdata/composed.conf and internal/inventory/people_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.038s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	222.146s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.016s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.026s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.012s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.153s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.054s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	2.885s
ok  	github.com/novox/mesh-controller/internal/builder	2.480s
ok  	github.com/novox/mesh-controller/internal/catalogue	6.322s
ok  	github.com/novox/mesh-controller/internal/conditions	2.384s
ok  	github.com/novox/mesh-controller/internal/envfile	1.032s
ok  	github.com/novox/mesh-controller/internal/facts	1.037s
ok  	github.com/novox/mesh-controller/internal/identity	4.036s
ok  	github.com/novox/mesh-controller/internal/inventory	74.699s
ok  	github.com/novox/mesh-controller/internal/lease	17.693s
ok  	github.com/novox/mesh-controller/internal/licences	3.711s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.008s
ok  	github.com/novox/mesh-controller/internal/link	57.943s
ok  	github.com/novox/mesh-controller/internal/lint	2.071s
ok  	github.com/novox/mesh-controller/internal/outward	1.041s
ok  	github.com/novox/mesh-controller/internal/overlay	1.025s
ok  	github.com/novox/mesh-controller/internal/secrets	1.424s
ok  	github.com/novox/mesh-controller/internal/store	3.226s
ok  	github.com/novox/mesh-controller/internal/testbus	1.171s
ok  	github.com/novox/mesh-controller/internal/token	1.017s
**Merge check** at `ebca7816` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller, route-proxy) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - tier 2: route-proxy - ace: receives build-agent, route-proxy - g14: receives build-agent - novox: receives mesh-controller, build-agent, route-proxy - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - route-proxy provides route: its consumers are sent again after it - route-proxy keeps data (ADR 0233): what it holds is backed up before it moves - read by no module's build: internal/broker/callers_live_test.go, internal/broker/callers_test.go, internal/broker/invokes_test.go, internal/broker/nats_test.go, internal/broker/testdata/composed.conf, internal/inventory/people_test.go Run by the build seat on g14 as `build-1791690475018824938` (`builds --log build-1791690475018824938`). ``` --- the gate: build-agent, mesh-controller, route-proxy mesh-controller: ok, 56 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T03:09:01Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T03:09:01Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 3 module(s) in 3 tier(s): build-agent, mesh-controller, route-proxy notes: - internal/broker/callers_live_test.go, internal/broker/callers_test.go, internal/broker/invokes_test.go, internal/broker/nats_test.go, internal/broker/testdata/composed.conf and internal/inventory/people_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.038s ok github.com/novox/mesh-controller/cmd/mesh-controller 222.146s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.016s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.026s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.012s ok github.com/novox/mesh-controller/examples/route-proxy 1.153s ok github.com/novox/mesh-controller/internal/artifacts 1.054s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 2.885s ok github.com/novox/mesh-controller/internal/builder 2.480s ok github.com/novox/mesh-controller/internal/catalogue 6.322s ok github.com/novox/mesh-controller/internal/conditions 2.384s ok github.com/novox/mesh-controller/internal/envfile 1.032s ok github.com/novox/mesh-controller/internal/facts 1.037s ok github.com/novox/mesh-controller/internal/identity 4.036s ok github.com/novox/mesh-controller/internal/inventory 74.699s ok github.com/novox/mesh-controller/internal/lease 17.693s ok github.com/novox/mesh-controller/internal/licences 3.711s ok github.com/novox/mesh-controller/internal/licences/adapters 1.008s ok github.com/novox/mesh-controller/internal/link 57.943s ok github.com/novox/mesh-controller/internal/lint 2.071s ok github.com/novox/mesh-controller/internal/outward 1.041s ok github.com/novox/mesh-controller/internal/overlay 1.025s ok github.com/novox/mesh-controller/internal/secrets 1.424s ok github.com/novox/mesh-controller/internal/store 3.226s ok github.com/novox/mesh-controller/internal/testbus 1.171s ok github.com/novox/mesh-controller/internal/token 1.017s ```
mesh-admin merged commit 51db0b5273 into main 2026-10-11 09:31:37 +00:00
mesh-admin deleted branch fix/365-a-tool-call-names-its-caller 2026-10-11 09:31:37 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#224