Fail the repo check when a listed store test did not run against the store (hq issue 459) #233

Merged
mesh-admin merged 1 commits from feat/459-store-tests-are-proven into main 2026-10-11 18:31:46 +00:00
Contributor

Issue 459, in the review of #232. A test that needs the store calls inventory.ForTest, which skips when MESH_TEST_POSTGRES is not set. A skip passes, so nobody can tell from the check whether a change's store tests ever ran. mesh/repo-check runs main's merge-check.sh, so this step has to merge before #232 can be judged by it.

What changes

  • New file testdata/store-tests: one <package> <TestName> per line; # lines are comments. It starts empty.
  • New step at the end of merge-check.sh:
    • With MESH_TEST_POSTGRES set, it runs every listed test with -v, per package. It prints store tests, each run against the store: and then one line per test: --- PASS/FAIL/SKIP: <name>, or --- NOT RUN: <name>. It fails unless every listed test passed.
    • Without the store it prints NOT STORE-CHECKED: ….
    • With nothing listed it prints store tests: none listed in testdata/store-tests.
  • Later pull requests add their own store tests to the list. #232 adds its six.

Tried by hand

  • With a list naming one test that exists and one that does not, and MESH_TEST_POSTGRES set: the existing test showed --- PASS, the other --- NOT RUN, and the step exited 1.
  • Without the variable: NOT STORE-CHECKED, exit 0.
  • With the empty list: none listed, exit 0.

The Go code is unchanged.

Issue 459, in the review of #232. A test that needs the store calls `inventory.ForTest`, which skips when `MESH_TEST_POSTGRES` is not set. A skip passes, so nobody can tell from the check whether a change's store tests ever ran. `mesh/repo-check` runs main's `merge-check.sh`, so this step has to merge before #232 can be judged by it. **What changes** - New file `testdata/store-tests`: one `<package> <TestName>` per line; `#` lines are comments. It starts empty. - New step at the end of `merge-check.sh`: - With `MESH_TEST_POSTGRES` set, it runs every listed test with `-v`, per package. It prints `store tests, each run against the store:` and then one line per test: `--- PASS/FAIL/SKIP: <name>`, or `--- NOT RUN: <name>`. It fails unless every listed test passed. - Without the store it prints `NOT STORE-CHECKED: …`. - With nothing listed it prints `store tests: none listed in testdata/store-tests`. - Later pull requests add their own store tests to the list. #232 adds its six. **Tried by hand** - With a list naming one test that exists and one that does not, and `MESH_TEST_POSTGRES` set: the existing test showed `--- PASS`, the other `--- NOT RUN`, and the step exited 1. - Without the variable: `NOT STORE-CHECKED`, exit 0. - With the empty list: `none listed`, exit 0. The Go code is unchanged.
mesh-admin added 1 commit 2026-10-11 18:23:05 +00:00
Fail the repo check when a listed store test did not run against the store (hq issue 459)
mesh/merge-gate pass: builds build-agent → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges; it…
mesh/delivery covered after its stop: a later merge that contains it was delivered: novox/mesh-controller@e2801773c300 (merged as ece37596 into main, wal…
731143f5b9
A test that needs the store skips without one, and a skip passes unseen, so a
change's store tests could pass the check without ever running. Tests named in
testdata/store-tests must each run and pass, said by name.
Author
Contributor

Delivery novox/mesh-controller@731143f5b9c6 — stopped since 2026-10-11T18:53:37Z

Covered after its stop: a later merge that contains it was delivered: novox/mesh-controller@e2801773c3 (merged as ece37596 into main, walk plan-1791745569394870156): build-agent

Delivery plan — builds build-agent → ace, g14, novox, shanks; no bus step

  • tier 0: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine

Transitions

  • 2026-10-11 18:23 (new) → proposed (announced): novox/mesh-controller#233's head announced
  • 2026-10-11 18:30 proposed → checked (checked): the verdict names this commit
  • 2026-10-11 18:30 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-11 18:33 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-11 18:53 published → stopped (stop): a merged change never reached the machines: its walk plan-1791743521181796058 ended done before its word without building build-agent (moved nothing the mesh holds: nothing to walk), and no later merge into main that contains it delivered them (novox/hq issue 474)

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@731143f5b9c6` — **stopped** since 2026-10-11T18:53:37Z **Covered** after its stop: a later merge that contains it was delivered: novox/mesh-controller@e2801773c300 (merged as ece37596 into main, walk plan-1791745569394870156): build-agent **Delivery plan** — builds build-agent → ace, g14, novox, shanks; no bus step - tier 0: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine **Transitions** - 2026-10-11 18:23 (new) → proposed (announced): novox/mesh-controller#233's head announced - 2026-10-11 18:30 proposed → checked (checked): the verdict names this commit - 2026-10-11 18:30 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-11 18:33 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-11 18:53 published → stopped (stop): a merged change never reached the machines: its walk plan-1791743521181796058 ended done before its word without building build-agent (moved nothing the mesh holds: nothing to walk), and no later merge into main that contains it delivered them (novox/hq issue 474) The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 731143f5

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent)
  • mesh/repo-check: PASS — THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges; its merge-check.sh passed

Delivery plan — builds build-agent → ace, g14, novox, shanks; no bus step

  • tier 0: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine

Run by the build seat on shanks as build-1791743005346756539 (builds --log build-1791743005346756539).

--- the gate: build-agent
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T18:23:22Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-11T18:23:22Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): build-agent
--- THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.042s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	249.860s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.019s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.048s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.016s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.234s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.072s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	3.130s
ok  	github.com/novox/mesh-controller/internal/builder	18.585s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.868s
ok  	github.com/novox/mesh-controller/internal/conditions	2.599s
ok  	github.com/novox/mesh-controller/internal/envfile	1.047s
ok  	github.com/novox/mesh-controller/internal/facts	1.048s
ok  	github.com/novox/mesh-controller/internal/identity	4.895s
ok  	github.com/novox/mesh-controller/internal/inventory	99.010s
ok  	github.com/novox/mesh-controller/internal/lease	17.719s
ok  	github.com/novox/mesh-controller/internal/licences	4.452s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.047s
ok  	github.com/novox/mesh-controller/internal/link	61.736s
ok  	github.com/novox/mesh-controller/internal/lint	2.401s
ok  	github.com/novox/mesh-controller/internal/outward	1.078s
ok  	github.com/novox/mesh-controller/internal/overlay	1.073s
ok  	github.com/novox/mesh-controller/internal/secrets	1.525s
ok  	github.com/novox/mesh-controller/internal/store	3.523s
ok  	github.com/novox/mesh-controller/internal/testbus	1.247s
ok  	github.com/novox/mesh-controller/internal/token	1.015s
**Merge check** at `731143f5` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent) - `mesh/repo-check`: **PASS** — THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges; its merge-check.sh passed **Delivery plan** — builds build-agent → ace, g14, novox, shanks; no bus step - tier 0: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine Run by the build seat on shanks as `build-1791743005346756539` (`builds --log build-1791743005346756539`). ``` --- the gate: build-agent judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-11T18:23:22Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-11T18:23:22Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): build-agent --- THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.042s ok github.com/novox/mesh-controller/cmd/mesh-controller 249.860s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.019s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.048s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.016s ok github.com/novox/mesh-controller/examples/route-proxy 1.234s ok github.com/novox/mesh-controller/internal/artifacts 1.072s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 3.130s ok github.com/novox/mesh-controller/internal/builder 18.585s ok github.com/novox/mesh-controller/internal/catalogue 7.868s ok github.com/novox/mesh-controller/internal/conditions 2.599s ok github.com/novox/mesh-controller/internal/envfile 1.047s ok github.com/novox/mesh-controller/internal/facts 1.048s ok github.com/novox/mesh-controller/internal/identity 4.895s ok github.com/novox/mesh-controller/internal/inventory 99.010s ok github.com/novox/mesh-controller/internal/lease 17.719s ok github.com/novox/mesh-controller/internal/licences 4.452s ok github.com/novox/mesh-controller/internal/licences/adapters 1.047s ok github.com/novox/mesh-controller/internal/link 61.736s ok github.com/novox/mesh-controller/internal/lint 2.401s ok github.com/novox/mesh-controller/internal/outward 1.078s ok github.com/novox/mesh-controller/internal/overlay 1.073s ok github.com/novox/mesh-controller/internal/secrets 1.525s ok github.com/novox/mesh-controller/internal/store 3.523s ok github.com/novox/mesh-controller/internal/testbus 1.247s ok github.com/novox/mesh-controller/internal/token 1.015s ```
mesh-admin merged commit afc7dd8f68 into main 2026-10-11 18:31:46 +00:00
mesh-admin deleted branch feat/459-store-tests-are-proven 2026-10-11 18:31:46 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#233