Say the class of what a change plan moves, for a fix's budget (issue 403, hq ADR 0313) #265

Merged
mesh-admin merged 3 commits from fix/403-fix-time into main 2026-10-12 19:41:27 +00:00
Contributor

What. link.ChangePlan gains class: core, leaf, or none when the change moves no module (no module moved, no dependent, no new module directory). changePlanOf sets it through changeClassOf; the walk's classOf now shares classOfModules with it (same rule: a module on the controller's own path, or one claiming the resolver seat, is core).

Why. hq ADR 0313 §2: an issue's fix budget is that of the slowest-budgeted module its fixes move, and a fix that moves nothing has none. The walk's class (ADR 0282) covers every merge a walk carries, so it can make a leaf fix core; the plan's class is the change's own. mesh-delivery passes it on with each transition (mesh-catalog PR on the same branch), and mesh-issues keeps it on the fix.

Tested. TestAChangePlanSaysTheClassOfWhatItMoves (cmd/mesh-controller/fixclass_test.go): a leaf module and its dependent, the delivery's owner, the resolver, leaf and core together, and a file no build reads (none). It does not compile without the change. sh merge-check.sh passes locally (store tests skipped: no MESH_TEST_POSTGRES).

Order. One delivery group with mesh-catalog and hq on fix/403-fix-time. The catalogue part does not need this to pass: until this controller runs, mesh-delivery falls back to the walk's class, then to none for a plan that moves nothing. A controller rollout: merge only while mesh-controller.plans says done.

Part of issue 403. Not merged.

**What.** `link.ChangePlan` gains `class`: `core`, `leaf`, or `none` when the change moves no module (no module moved, no dependent, no new module directory). `changePlanOf` sets it through `changeClassOf`; the walk's `classOf` now shares `classOfModules` with it (same rule: a module on the controller's own path, or one claiming the resolver seat, is core). **Why.** hq ADR 0313 §2: an issue's fix budget is that of the slowest-budgeted module its fixes move, and a fix that moves nothing has none. The walk's class (ADR 0282) covers every merge a walk carries, so it can make a leaf fix core; the plan's class is the change's own. mesh-delivery passes it on with each transition (mesh-catalog PR on the same branch), and mesh-issues keeps it on the fix. **Tested.** `TestAChangePlanSaysTheClassOfWhatItMoves` (`cmd/mesh-controller/fixclass_test.go`): a leaf module and its dependent, the delivery's owner, the resolver, leaf and core together, and a file no build reads (`none`). It does not compile without the change. `sh merge-check.sh` passes locally (store tests skipped: no MESH_TEST_POSTGRES). **Order.** One delivery group with mesh-catalog and hq on `fix/403-fix-time`. The catalogue part does not need this to pass: until this controller runs, mesh-delivery falls back to the walk's class, then to none for a plan that moves nothing. A controller rollout: merge only while `mesh-controller.plans` says done. Part of issue 403. Not merged.
mesh-admin added 1 commit 2026-10-12 13:50:25 +00:00
Say the class of what a change plan moves, so a fix's budget follows its modules (issue 403)
mesh/merge-gate pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without …
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery-group group fix/403-fix-time ready: every member ready, and composed together they pass
mesh/delivery superseded: a newer head of the same pull request
05eccbf22b
The issue tracker holds a fix to the budget of the slowest-budgeted module it
moves, and gives none to a fix that moves no module (hq ADR 0313 §2). The
walk's class covers every merge a walk carries; the plan's class is the
change's own: core, leaf, or none.
Author
Contributor

Delivery novox/mesh-controller@daf52b3aeb79 — failed since 2026-10-12T19:50:00Z

Covered: covered after its failure: a later walk that contains it was delivered: plan-1791834103351744736 (novox/mesh-controller at c0c379af into main, done, contains its merge c0c379af)

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine

Group fix/403-fix-time, in order: novox/hq@506d00cf74 → novox/mesh-controller@daf52b3aeb → novox/mesh-catalog@005f802504

Machines

  • mesh-controller on novox: passed — healthy 3 times over 3m38s
  • mesh-controller on the rest running it: sent
  • build-agent on ace: passed — healthy 1 times over 1m41s
  • build-agent on the rest running it: sent
  • mesh-delivery on novox: passed — healthy 3 times over 2m11s
  • mesh-issues on novox: passed — judged with mesh-delivery: healthy 3 times over 2m11s
  • mesh-delivery on the rest running it: sent
  • mesh-issues on the rest running it: sent

Transitions

  • 2026-10-12 19:29 (new) → proposed (announced): novox/mesh-controller#265's head announced
  • 2026-10-12 19:36 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-12 19:36 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 19:43 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 19:43 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-12 19:50 delivering → failed (failed): its walk failed, carrying its own commit: a gate on a first machine (what it carried put back), a build, a machine

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@daf52b3aeb79` — **failed** since 2026-10-12T19:50:00Z **Covered**: covered after its failure: a later walk that contains it was delivered: plan-1791834103351744736 (novox/mesh-controller at c0c379af into main, done, contains its merge c0c379af) **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine **Group** `fix/403-fix-time`, in order: novox/hq@506d00cf7428 → novox/mesh-controller@daf52b3aeb79 → novox/mesh-catalog@005f802504fc - novox/mesh-controller@daf52b3aeb79 before novox/mesh-catalog@005f802504fc: built by - composed together: pass — every machine composes with the change as it did without (4 of 4 compose) **Machines** - mesh-controller on novox: passed — healthy 3 times over 3m38s - mesh-controller on the rest running it: sent - build-agent on ace: passed — healthy 1 times over 1m41s - build-agent on the rest running it: sent - mesh-delivery on novox: passed — healthy 3 times over 2m11s - mesh-issues on novox: passed — judged with mesh-delivery: healthy 3 times over 2m11s - mesh-delivery on the rest running it: sent - mesh-issues on the rest running it: sent **Transitions** - 2026-10-12 19:29 (new) → proposed (announced): novox/mesh-controller#265's head announced - 2026-10-12 19:36 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-12 19:36 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 19:43 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 19:43 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-12 19:50 delivering → failed (failed): its walk failed, carrying its own commit: a gate on a first machine (what it carried put back), a build, a machine The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 05eccbf2

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/fixclass_test.go

Run by the build seat on novox as build-1791813031089866129 (builds --log build-1791813031089866129).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T13:33:41Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T13:33:41Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - cmd/mesh-controller/fixclass_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.044s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	298.810s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.019s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.030s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.021s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.127s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.058s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.841s
ok  	github.com/novox/mesh-controller/internal/builder	44.986s
ok  	github.com/novox/mesh-controller/internal/catalogue	9.420s
ok  	github.com/novox/mesh-controller/internal/conditions	2.682s
ok  	github.com/novox/mesh-controller/internal/envfile	1.035s
ok  	github.com/novox/mesh-controller/internal/facts	1.034s
ok  	github.com/novox/mesh-controller/internal/identity	5.463s
ok  	github.com/novox/mesh-controller/internal/inventory	112.790s
ok  	github.com/novox/mesh-controller/internal/lease	17.612s
ok  	github.com/novox/mesh-controller/internal/licences	4.937s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.016s
ok  	github.com/novox/mesh-controller/internal/link	64.492s
ok  	github.com/novox/mesh-controller/internal/lint	2.551s
ok  	github.com/novox/mesh-controller/internal/outward	1.045s
ok  	github.com/novox/mesh-controller/internal/overlay	1.032s
ok  	github.com/novox/mesh-controller/internal/secrets	1.510s
ok  	github.com/novox/mesh-controller/internal/store	3.503s
ok  	github.com/novox/mesh-controller/internal/testbus	1.219s
ok  	github.com/novox/mesh-controller/internal/token	1.016s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.46s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.51s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.46s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.46s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.44s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.43s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.53s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.37s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.48s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.49s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.45s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.54s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.74s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.54s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.55s)
  ./cmd/mesh-controller --- PASS: TestReplay237 (0.45s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.44s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.49s)
  ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.45s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.37s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.31s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.30s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.38s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.27s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.27s)
**Merge check** at `05eccbf2` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/fixclass_test.go Run by the build seat on novox as `build-1791813031089866129` (`builds --log build-1791813031089866129`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T13:33:41Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T13:33:41Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - cmd/mesh-controller/fixclass_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.044s ok github.com/novox/mesh-controller/cmd/mesh-controller 298.810s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.019s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.030s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.021s ok github.com/novox/mesh-controller/examples/route-proxy 1.127s ok github.com/novox/mesh-controller/internal/artifacts 1.058s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.841s ok github.com/novox/mesh-controller/internal/builder 44.986s ok github.com/novox/mesh-controller/internal/catalogue 9.420s ok github.com/novox/mesh-controller/internal/conditions 2.682s ok github.com/novox/mesh-controller/internal/envfile 1.035s ok github.com/novox/mesh-controller/internal/facts 1.034s ok github.com/novox/mesh-controller/internal/identity 5.463s ok github.com/novox/mesh-controller/internal/inventory 112.790s ok github.com/novox/mesh-controller/internal/lease 17.612s ok github.com/novox/mesh-controller/internal/licences 4.937s ok github.com/novox/mesh-controller/internal/licences/adapters 1.016s ok github.com/novox/mesh-controller/internal/link 64.492s ok github.com/novox/mesh-controller/internal/lint 2.551s ok github.com/novox/mesh-controller/internal/outward 1.045s ok github.com/novox/mesh-controller/internal/overlay 1.032s ok github.com/novox/mesh-controller/internal/secrets 1.510s ok github.com/novox/mesh-controller/internal/store 3.503s ok github.com/novox/mesh-controller/internal/testbus 1.219s ok github.com/novox/mesh-controller/internal/token 1.016s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.46s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.51s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.46s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.46s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.44s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.43s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.53s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.37s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.48s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.49s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.45s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.54s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.74s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.54s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.55s) ./cmd/mesh-controller --- PASS: TestReplay237 (0.45s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.44s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.49s) ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.45s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.37s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.31s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.30s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.38s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.27s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.27s) ```
mesh-admin left a comment
Author
Contributor

Verdict: approve at 05eccbf22b

Independent review of issue 403 (ADR 0313) across the group fix/403-fix-time: this pull request, mesh-catalog #250 and hq #331. I read the diff through the forge.

It matches ADR 0313 §2. The change plan now says class: core when a moved module or a dependent is on the controller's own path or holds the resolver, leaf otherwise, and none when the plan moves, makes dependent and adds nothing. classOf for a walk now delegates to classOfModules, so the walk's class (ADR 0282 §1) and the plan's class come from one rule. The new JSON field is omitempty and additive, so today's consumers are unaffected. mesh-delivery #250 reads it, and falls back for a plan from a controller without it.

The test TestAChangePlanSaysTheClassOfWhatItMoves covers leaf with a dependent, the delivery's owner (core), the resolver (core), leaf and core together (core wins), and a README-only change (none).

Minor, not blocking: a plan whose only change is a new module (New) gets classOfModules of an empty list, which is leaf. The doc comment says a new module is "included", but its own class is never looked at. A new core module would read as leaf. Either pass New into classOfModules or reword the comment.

Tests: I did not run merge-check.sh with a throwaway Postgres locally. This session was refused a local clone, so I rely on mesh/repo-check ("its merge-check.sh passed"). I have not shown that the new test fails on main. It cannot compile there, because ChangePlan.Class does not exist.

Statuses at 05eccbf22b: mesh/merge-gate pass (builds build-agent and mesh-controller to ace, g14, novox and shanks; every machine composes). mesh/repo-check pass. mesh/delivery ready. mesh/delivery-group "every member ready, and composed together they pass". This is a controller rollout, so merge it only when mesh-controller.plans says done.

The group as a whole waits on mesh-catalog #250, where I requested a change: the review phase never sees this forge's COMMENT-review approvals.

Verdict: approve at 05eccbf22b926eb0b671a05d42e719433b23773d Independent review of issue 403 (ADR 0313) across the group fix/403-fix-time: this pull request, mesh-catalog #250 and hq #331. I read the diff through the forge. **It matches ADR 0313 §2.** The change plan now says `class`: core when a moved module or a dependent is on the controller's own path or holds the resolver, leaf otherwise, and `none` when the plan moves, makes dependent and adds nothing. `classOf` for a walk now delegates to `classOfModules`, so the walk's class (ADR 0282 §1) and the plan's class come from one rule. The new JSON field is `omitempty` and additive, so today's consumers are unaffected. mesh-delivery #250 reads it, and falls back for a plan from a controller without it. **The test** `TestAChangePlanSaysTheClassOfWhatItMoves` covers leaf with a dependent, the delivery's owner (core), the resolver (core), leaf and core together (core wins), and a README-only change (none). Minor, not blocking: a plan whose only change is a new module (`New`) gets `classOfModules` of an empty list, which is leaf. The doc comment says a new module is "included", but its own class is never looked at. A new core module would read as leaf. Either pass `New` into `classOfModules` or reword the comment. **Tests:** I did not run merge-check.sh with a throwaway Postgres locally. This session was refused a local clone, so I rely on mesh/repo-check ("its merge-check.sh passed"). I have not shown that the new test fails on main. It cannot compile there, because `ChangePlan.Class` does not exist. **Statuses at 05eccbf22b92:** mesh/merge-gate pass (builds build-agent and mesh-controller to ace, g14, novox and shanks; every machine composes). mesh/repo-check pass. mesh/delivery ready. mesh/delivery-group "every member ready, and composed together they pass". This is a controller rollout, so merge it only when `mesh-controller.plans` says done. The group as a whole waits on mesh-catalog #250, where I requested a change: the review phase never sees this forge's COMMENT-review approvals.
jschoubben added 1 commit 2026-10-12 14:16:04 +00:00
Class a new module by its own name, so adding a core module is not called leaf (issue 403, review 69)
mesh/delivery-group group fix/403-fix-time checking: composed check out of date: novox/mesh-controller@7ca5a45ecc5a was judged against trunk ?, the trunk is no…
mesh/merge-gate out of date: judged against trunk 84deb530ee5a, the trunk is now 4dbd4066ca54; judged again on a recheck or when it is merged
mesh/repo-check out of date: judged against trunk 84deb530ee5a, the trunk is now 4dbd4066ca54; judged again on a recheck or when it is merged
mesh/delivery superseded: a newer head of the same pull request
7ca5a45ecc
Author
Contributor

Merge check at 7ca5a45e

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/fixclass_test.go

Run by the build seat on g14 as build-1791814593170949556 (builds --log build-1791814593170949556).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T14:13:26Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T14:13:26Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller

notes:
  - cmd/mesh-controller/fixclass_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.042s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	315.932s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.016s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.027s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.019s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.176s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.059s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	4.678s
ok  	github.com/novox/mesh-controller/internal/builder	39.227s
ok  	github.com/novox/mesh-controller/internal/catalogue	8.411s
ok  	github.com/novox/mesh-controller/internal/conditions	2.645s
ok  	github.com/novox/mesh-controller/internal/envfile	1.036s
ok  	github.com/novox/mesh-controller/internal/facts	1.045s
ok  	github.com/novox/mesh-controller/internal/identity	5.222s
ok  	github.com/novox/mesh-controller/internal/inventory	143.662s
ok  	github.com/novox/mesh-controller/internal/lease	17.735s
ok  	github.com/novox/mesh-controller/internal/licences	4.762s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.018s
ok  	github.com/novox/mesh-controller/internal/link	73.301s
ok  	github.com/novox/mesh-controller/internal/lint	2.665s
ok  	github.com/novox/mesh-controller/internal/outward	1.059s
ok  	github.com/novox/mesh-controller/internal/overlay	1.039s
ok  	github.com/novox/mesh-controller/internal/secrets	1.591s
ok  	github.com/novox/mesh-controller/internal/store	3.607s
ok  	github.com/novox/mesh-controller/internal/testbus	1.208s
ok  	github.com/novox/mesh-controller/internal/token	1.025s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.40s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.42s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.50s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.39s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.36s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.53s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.42s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.39s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.52s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.42s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.45s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.37s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.42s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.37s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.43s)
  ./cmd/mesh-controller --- PASS: TestReplay237 (0.36s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.35s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.54s)
  ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.35s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.23s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.24s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.30s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.23s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.21s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.21s)
**Merge check** at `7ca5a45e` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/fixclass_test.go Run by the build seat on g14 as `build-1791814593170949556` (`builds --log build-1791814593170949556`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T14:13:26Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T14:13:26Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller notes: - cmd/mesh-controller/fixclass_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.042s ok github.com/novox/mesh-controller/cmd/mesh-controller 315.932s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.016s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.027s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.019s ok github.com/novox/mesh-controller/examples/route-proxy 1.176s ok github.com/novox/mesh-controller/internal/artifacts 1.059s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 4.678s ok github.com/novox/mesh-controller/internal/builder 39.227s ok github.com/novox/mesh-controller/internal/catalogue 8.411s ok github.com/novox/mesh-controller/internal/conditions 2.645s ok github.com/novox/mesh-controller/internal/envfile 1.036s ok github.com/novox/mesh-controller/internal/facts 1.045s ok github.com/novox/mesh-controller/internal/identity 5.222s ok github.com/novox/mesh-controller/internal/inventory 143.662s ok github.com/novox/mesh-controller/internal/lease 17.735s ok github.com/novox/mesh-controller/internal/licences 4.762s ok github.com/novox/mesh-controller/internal/licences/adapters 1.018s ok github.com/novox/mesh-controller/internal/link 73.301s ok github.com/novox/mesh-controller/internal/lint 2.665s ok github.com/novox/mesh-controller/internal/outward 1.059s ok github.com/novox/mesh-controller/internal/overlay 1.039s ok github.com/novox/mesh-controller/internal/secrets 1.591s ok github.com/novox/mesh-controller/internal/store 3.607s ok github.com/novox/mesh-controller/internal/testbus 1.208s ok github.com/novox/mesh-controller/internal/token 1.025s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.40s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.42s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.50s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.39s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.36s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.53s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.42s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.39s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.52s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.42s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.45s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.37s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.42s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.37s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.43s) ./cmd/mesh-controller --- PASS: TestReplay237 (0.36s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.35s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.54s) ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.35s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.23s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.24s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.30s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.23s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.21s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.21s) ```
mesh-admin left a comment
Author
Contributor

Verdict: approve at 7ca5a45ecc

Re-review after review 70. The minor finding is fixed.

A new module now counts by its own class. changeClassOf adds the last path element of each New directory as a module name, so a new module on the controller's own path is core. The comment says plainly that a new module cannot be found core through a resolver claim, because the graph holds no manifest for it yet. The test adds three cases: a new leaf module alone, a new module on the controller's path, and a new leaf beside a core module. On the previous head 05eccbf the new test fails ("a new module on the controller's own path, by its own class: class "leaf", want "core""), and it passes at 7ca5a45.

Tests I ran myself on a clone at 7ca5a45: MESH_TEST_POSTGRES=... sh merge-check.sh against a throwaway postgres:16 container exits 0. Every package passes, and every listed store test reports PASS.

Statuses at 7ca5a45ecc: mesh/merge-gate pass (build-agent and mesh-controller to ace, g14, novox and shanks; every machine composes). mesh/repo-check pass. mesh/delivery ready. mesh/delivery-group says "every member ready, and composed together they pass" (14:29). This is a controller rollout, so merge it only when mesh-controller.plans says done.

Verdict: approve at 7ca5a45ecc5abfd33ce84820c9516f4ab1d1b8c7 Re-review after review 70. The minor finding is fixed. **A new module now counts by its own class.** `changeClassOf` adds the last path element of each `New` directory as a module name, so a new module on the controller's own path is core. The comment says plainly that a new module cannot be found core through a resolver claim, because the graph holds no manifest for it yet. The test adds three cases: a new leaf module alone, a new module on the controller's path, and a new leaf beside a core module. On the previous head 05eccbf the new test fails ("a new module on the controller's own path, by its own class: class \"leaf\", want \"core\""), and it passes at 7ca5a45. **Tests I ran myself** on a clone at 7ca5a45: `MESH_TEST_POSTGRES=... sh merge-check.sh` against a throwaway postgres:16 container exits 0. Every package passes, and every listed store test reports PASS. **Statuses at 7ca5a45ecc5a:** mesh/merge-gate pass (build-agent and mesh-controller to ace, g14, novox and shanks; every machine composes). mesh/repo-check pass. mesh/delivery ready. mesh/delivery-group says "every member ready, and composed together they pass" (14:29). This is a controller rollout, so merge it only when `mesh-controller.plans` says done.
Author
Contributor

Merge check at 7ca5a45e
Judged: head 7ca5a45ecc5a merged into trunk 84deb530ee5a

  • mesh/merge-gate: FAIL — head 7ca5a45ecc does not merge cleanly into trunk 84deb530ee: in conflict internal/link/events.go (modules: build-agent, mesh-controller)
  • mesh/repo-check: FAIL — head 7ca5a45ecc does not merge cleanly into trunk 84deb530ee: in conflict internal/link/events.go

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/fixclass_test.go

Run by the build seat on g14 as build-1791831890399787412 (builds --log build-1791831890399787412).

head 7ca5a45ecc5a does not merge cleanly into trunk 84deb530ee5a: in conflict internal/link/events.go
**Merge check** at `7ca5a45e` Judged: head `7ca5a45ecc5a` merged into trunk `84deb530ee5a` - `mesh/merge-gate`: **FAIL** — head 7ca5a45ecc5a does not merge cleanly into trunk 84deb530ee5a: in conflict internal/link/events.go (modules: build-agent, mesh-controller) - `mesh/repo-check`: **FAIL** — head 7ca5a45ecc5a does not merge cleanly into trunk 84deb530ee5a: in conflict internal/link/events.go **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/fixclass_test.go Run by the build seat on g14 as `build-1791831890399787412` (`builds --log build-1791831890399787412`). ``` head 7ca5a45ecc5a does not merge cleanly into trunk 84deb530ee5a: in conflict internal/link/events.go ```
jschoubben added 1 commit 2026-10-12 19:29:38 +00:00
Merge remote-tracking branch 'origin/main' into fix/403-fix-time
mesh/merge-gate head daf52b3aeb79 merged into trunk 4dbd4066ca54 — pass: builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step; every …
mesh/repo-check head daf52b3aeb79 merged into trunk 4dbd4066ca54 — pass: its merge-check.sh passed
mesh/delivery covered after its failure: a later walk that contains it was delivered: plan-1791834103351744736 (novox/mesh-controller at c0c379af into ma…
mesh/delivery-group group fix/403-fix-time merged: every member is merged
daf52b3aeb
# Conflicts:
#	internal/link/events.go
Author
Contributor

Merge check at daf52b3a
Judged: head daf52b3aeb79 merged into trunk 4dbd4066ca54; read beside it: mesh-catalog eb5f33f2b475, mesh-controller-main 4dbd4066ca54, mesh-host 303d4037e84e, mesh-tools 954e1a53eef9

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-controller
  • tier 1: build-agent
  • ace: receives build-agent
  • g14: receives build-agent
  • novox: receives mesh-controller, build-agent
  • shanks: receives build-agent
  • build-agent keeps data (ADR 0233): what it holds is backed up before it moves
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine
  • read by no module's build: cmd/mesh-controller/fixclass_test.go

Run by the build seat on ace as build-1791833395086636158 (builds --log build-1791833395086636158).

--- the gate: build-agent, mesh-controller
mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8)
long-running resources without health: 1
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T19:24:51Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T19:24:51Z

modules the change moves:
  - mesh-controller (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-controller/cmd/mesh-builder	1.036s
ok  	github.com/novox/mesh-controller/cmd/mesh-controller	245.054s
ok  	github.com/novox/mesh-controller/examples/objectstore-provisioner	1.012s
ok  	github.com/novox/mesh-controller/examples/postgres-provisioner	1.018s
ok  	github.com/novox/mesh-controller/examples/redis-provisioner	1.013s
ok  	github.com/novox/mesh-controller/examples/route-proxy	1.117s
ok  	github.com/novox/mesh-controller/internal/artifacts	1.042s
?   	github.com/novox/mesh-controller/internal/beside	[no test files]
ok  	github.com/novox/mesh-controller/internal/broker	3.923s
ok  	github.com/novox/mesh-controller/internal/builder	31.956s
ok  	github.com/novox/mesh-controller/internal/catalogue	7.359s
ok  	github.com/novox/mesh-controller/internal/conditions	2.579s
ok  	github.com/novox/mesh-controller/internal/envfile	1.047s
ok  	github.com/novox/mesh-controller/internal/facts	1.047s
ok  	github.com/novox/mesh-controller/internal/identity	4.309s
ok  	github.com/novox/mesh-controller/internal/inventory	85.965s
ok  	github.com/novox/mesh-controller/internal/lease	17.727s
ok  	github.com/novox/mesh-controller/internal/licences	3.926s
ok  	github.com/novox/mesh-controller/internal/licences/adapters	1.076s
ok  	github.com/novox/mesh-controller/internal/link	59.204s
ok  	github.com/novox/mesh-controller/internal/lint	2.258s
ok  	github.com/novox/mesh-controller/internal/outward	1.100s
ok  	github.com/novox/mesh-controller/internal/overlay	1.090s
ok  	github.com/novox/mesh-controller/internal/secrets	1.492s
ok  	github.com/novox/mesh-controller/internal/store	3.385s
ok  	github.com/novox/mesh-controller/internal/testbus	1.224s
ok  	github.com/novox/mesh-controller/internal/token	1.017s
store tests, each run against the store:
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.38s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.42s)
  ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.40s)
  ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.39s)
  ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.39s)
  ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.35s)
  ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (4.36s)
  ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.42s)
  ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.30s)
  ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.43s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.41s)
  ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.39s)
  ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.39s)
  ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.45s)
  ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.40s)
  ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.42s)
  ./cmd/mesh-controller --- PASS: TestReplay237 (0.41s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.38s)
  ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.35s)
  ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.41s)
  ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.42s)
  ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.48s)
  ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.46s)
  ./cmd/mesh-controller --- PASS: TestReplay201 (0.34s)
  ./cmd/mesh-controller --- PASS: TestARollbackWhoseSendWasRefusedIsCompletedByTheNextSend (0.34s)
  ./cmd/mesh-controller --- PASS: TestAGateJudgesTheOtherMovesBesideAKeptCore (0.35s)
  ./cmd/mesh-controller --- PASS: TestReplay401 (0.48s)
  ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.24s)
  ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.24s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.23s)
  ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.23s)
  ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.23s)
  ./internal/inventory --- PASS: TestAPlanIdHoldingAQuoteIsReadAsAPlainId (0.24s)
  ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.23s)
**Merge check** at `daf52b3a` Judged: head `daf52b3aeb79` merged into trunk `4dbd4066ca54`; read beside it: mesh-catalog `eb5f33f2b475`, mesh-controller-main `4dbd4066ca54`, mesh-host `303d4037e84e`, mesh-tools `954e1a53eef9` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: build-agent, mesh-controller) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds build-agent, mesh-controller → ace, g14, novox, shanks; no bus step - tier 0: mesh-controller - tier 1: build-agent - ace: receives build-agent - g14: receives build-agent - novox: receives mesh-controller, build-agent - shanks: receives build-agent - build-agent keeps data (ADR 0233): what it holds is backed up before it moves - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before build-agent is judged on its first machine - read by no module's build: cmd/mesh-controller/fixclass_test.go Run by the build seat on ace as `build-1791833395086636158` (`builds --log build-1791833395086636158`). ``` --- the gate: build-agent, mesh-controller mesh-controller: ok, 58 tool(s); WARNING: merge-window ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339); WARNING: controller stay(s) up and say(s) not how it is ready — judged by liveness alone, refused from 2026-11-18 (ADR 0240 rule 8) long-running resources without health: 1 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T19:24:51Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T19:24:51Z modules the change moves: - mesh-controller (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 2 module(s) in 2 tier(s): build-agent, mesh-controller --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-controller/cmd/mesh-builder 1.036s ok github.com/novox/mesh-controller/cmd/mesh-controller 245.054s ok github.com/novox/mesh-controller/examples/objectstore-provisioner 1.012s ok github.com/novox/mesh-controller/examples/postgres-provisioner 1.018s ok github.com/novox/mesh-controller/examples/redis-provisioner 1.013s ok github.com/novox/mesh-controller/examples/route-proxy 1.117s ok github.com/novox/mesh-controller/internal/artifacts 1.042s ? github.com/novox/mesh-controller/internal/beside [no test files] ok github.com/novox/mesh-controller/internal/broker 3.923s ok github.com/novox/mesh-controller/internal/builder 31.956s ok github.com/novox/mesh-controller/internal/catalogue 7.359s ok github.com/novox/mesh-controller/internal/conditions 2.579s ok github.com/novox/mesh-controller/internal/envfile 1.047s ok github.com/novox/mesh-controller/internal/facts 1.047s ok github.com/novox/mesh-controller/internal/identity 4.309s ok github.com/novox/mesh-controller/internal/inventory 85.965s ok github.com/novox/mesh-controller/internal/lease 17.727s ok github.com/novox/mesh-controller/internal/licences 3.926s ok github.com/novox/mesh-controller/internal/licences/adapters 1.076s ok github.com/novox/mesh-controller/internal/link 59.204s ok github.com/novox/mesh-controller/internal/lint 2.258s ok github.com/novox/mesh-controller/internal/outward 1.100s ok github.com/novox/mesh-controller/internal/overlay 1.090s ok github.com/novox/mesh-controller/internal/secrets 1.492s ok github.com/novox/mesh-controller/internal/store 3.385s ok github.com/novox/mesh-controller/internal/testbus 1.224s ok github.com/novox/mesh-controller/internal/token 1.017s store tests, each run against the store: ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeWalksTheOthersAgain (0.38s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeEndsTheMergesThatContainIt (0.42s) ./cmd/mesh-controller --- PASS: TestAStopWalksTheOthersAgainInTheOpenBatch (0.40s) ./cmd/mesh-controller --- PASS: TestAStopNamesWhatStaysOnTheMachinesAndWhatStillCarriesIt (0.39s) ./cmd/mesh-controller --- PASS: TestAStopWithoutAMergeLeavesItOutOfABatch (0.39s) ./cmd/mesh-controller --- PASS: TestSavingPlansAndMovingMergesIsOneAct (0.35s) ./cmd/mesh-controller --- PASS: TestAPlanFollowedFromTheStoreAnswersWhenItMoves (4.36s) ./cmd/mesh-controller --- PASS: TestNodeShowAndStatusReadTheLastSendFromTheStore (0.42s) ./cmd/mesh-controller --- PASS: TestTheConditionsVerbReadsTheLooksTheBucketNoLongerHolds (0.30s) ./cmd/mesh-controller --- PASS: TestAWalkLetGoAndStoppedByVerbsIsSaidStartedAndEnded (0.43s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedOrClosedByAPersonIsSaidEndedStopped (0.41s) ./cmd/mesh-controller --- PASS: TestAWalkRetriedByAPersonIsSaidStartedAgain (0.39s) ./cmd/mesh-controller --- PASS: TestABacklogReleasedByAPersonIsSaidStarted (0.39s) ./cmd/mesh-controller --- PASS: TestAWalkEndedByCancelOrClearIsSaidEnded (0.45s) ./cmd/mesh-controller --- PASS: TestAWalkRestartedByARebuildIsSaidStarted (0.40s) ./cmd/mesh-controller --- PASS: TestAWalkStoppedByHandAndRetriedEndsFailedWhenItFailsAgain (0.42s) ./cmd/mesh-controller --- PASS: TestReplay237 (0.41s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeUnresolvedSaysSoOnceInItsAnswer (0.38s) ./cmd/mesh-controller --- PASS: TestAnUnassignThatLeavesItsNodeResolvedSaysNothingOfIt (0.35s) ./cmd/mesh-controller --- PASS: TestAnAssignThatLeavesItsNodeUnresolvedSaysOnlyThePlansRefusal (0.41s) ./cmd/mesh-controller --- PASS: TestADirectoryOwnersKeyIsRefusedThroughAVerb (0.42s) ./cmd/mesh-controller --- PASS: TestTheSendMakesNoValueForAnOutsideSecretNobodyGave (0.48s) ./cmd/mesh-controller --- PASS: TestAQuestionComposesWithoutAnOutsideSecretNobodyGave (0.46s) ./cmd/mesh-controller --- PASS: TestReplay201 (0.34s) ./cmd/mesh-controller --- PASS: TestARollbackWhoseSendWasRefusedIsCompletedByTheNextSend (0.34s) ./cmd/mesh-controller --- PASS: TestAGateJudgesTheOtherMovesBesideAKeptCore (0.35s) ./cmd/mesh-controller --- PASS: TestReplay401 (0.48s) ./internal/inventory --- PASS: TestTheLastSendSaysWhatTheMachineAnswered (0.24s) ./internal/inventory --- PASS: TestAReportIsTheLastSendsAnswerOnlyWhenItIsAboutThatSend (0.24s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedToEveryHolderOnceAndNotAgain (0.23s) ./internal/inventory --- PASS: TestAnIssuedValueIsSealedAgainAfterAKeyChangeOrAnAcceptance (0.23s) ./internal/inventory --- PASS: TestAConditionsLooksAreKeptBesideTheBucket (0.23s) ./internal/inventory --- PASS: TestAPlanIdHoldingAQuoteIsReadAsAPlainId (0.24s) ./internal/inventory --- PASS: TestAWalksStartIsKeptAndARefusedSaveLeavesItUnsaid (0.23s) ```
Author
Contributor

Re-check at daf52b3aeb (merge of main into the approved 7ca5a45e): the PR's own diff against main is line-for-line the approved diff; the only conflict was ChangePlan's last fields (main's Trunk, this PR's Class), both kept. Review 78's approval carries to this head.

Re-check at daf52b3aeb799909dc924eb191ba754e3d623e1f (merge of main into the approved 7ca5a45e): the PR's own diff against main is line-for-line the approved diff; the only conflict was ChangePlan's last fields (main's Trunk, this PR's Class), both kept. Review 78's approval carries to this head.
mesh-admin merged commit c0c379af2b into main 2026-10-12 19:41:27 +00:00
mesh-admin deleted branch fix/403-fix-time 2026-10-12 19:41:27 +00:00
This repo is archived. You cannot comment on pull requests.
No Reviewers
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#265