Test the refusal of a jail whose pattern names the host twice #364

Merged
mesh-tools merged 1 commits from fix/959-jail-pattern-test into main 2026-10-16 20:19:49 +00:00
Member

Issue 959.

Main refuses a jail whose failregex names <HOST> more than once (internal/catalogue/manifest.go, jailProblems; ADR 0179), because fail2ban would refuse its whole configuration and keep no bans. No test held that refusal: the only one sat untracked in an old worktree. This adds it, unchanged.

Proved: the test passes on main, and fails when the refusal's append is removed (mutation run locally, then restored). go test ./internal/catalogue/ passes.

Test only; nothing the mesh runs changes.

Issue 959. Main refuses a jail whose failregex names `<HOST>` more than once (`internal/catalogue/manifest.go`, `jailProblems`; ADR 0179), because fail2ban would refuse its whole configuration and keep no bans. No test held that refusal: the only one sat untracked in an old worktree. This adds it, unchanged. Proved: the test passes on main, and fails when the refusal's `append` is removed (mutation run locally, then restored). `go test ./internal/catalogue/` passes. Test only; nothing the mesh runs changes.
mesh-tools added 1 commit 2026-10-16 20:09:09 +00:00
Test the refusal of a jail whose pattern names the host twice
mesh/merge-gate head f614eeb445a1 merged into trunk 53a3c91f53ce — pass: the change touches no module of the mesh's graph
mesh/repo-check head f614eeb445a1 merged into trunk 53a3c91f53ce — pass: its merge-check.sh passed
mesh/delivery delivered
f614eeb445
Main refuses such a jail (fail2ban would refuse its whole configuration and
keep no bans), but no test held it: the only one sat untracked in an old
worktree. Issue 959.
Author
Member

Delivery novox/mesh-controller@f614eeb445a1 — delivered since 2026-10-16T20:19:51Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-16 20:09 (new) → proposed (announced): novox/mesh-controller#364's head announced
  • 2026-10-16 20:12 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-16 20:12 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-16 20:19 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-16 20:19 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@f614eeb445a1` — **delivered** since 2026-10-16T20:19:51Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-16 20:09 (new) → proposed (announced): novox/mesh-controller#364's head announced - 2026-10-16 20:12 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-16 20:12 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-16 20:19 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-16 20:19 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-tools added the mesh/ready label 2026-10-16 20:13:11 +00:00
Author
Member

ready at f614eeb445

Reviewed by review-959@shanks: Approved: the test passes on main and fails without the refusal; both checks green at trunk 53a3c91f; the operator's word to mark ready, 22:16. Marked through mesh-delivery.mark-ready (novox/hq issue 913).

ready at f614eeb445a1c5756e6aba8a41d38e65aab94a48 Reviewed by review-959@shanks: Approved: the test passes on main and fails without the refusal; both checks green at trunk 53a3c91f; the operator's word to mark ready, 22:16. Marked through mesh-delivery.mark-ready (novox/hq issue 913).
mesh-tools merged commit 1cdf12df00 into main 2026-10-16 20:19:49 +00:00
mesh-tools deleted branch fix/959-jail-pattern-test 2026-10-16 20:19:50 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#364