Count a module's own stream events beside its emits in the catalogue agreement (issue 1249) #395

2026-10-19T13:36:28Z

mesh-tools commented

2026-10-19 13:36:28 +00:00

Issue 1249. Every mesh-controller check has failed TestTheCataloguesEmittersAndConsumersAgree since mesh-catalog #371 gave mesh-mail an emits list beside its own stream mail: the test read only emits, so mesh-mail-notifier's consumer of mesh-mail.mail.*.message.added (a stream event) was reported as matching nothing. The catalogue is right; the test was not.

Test-only: theCataloguesEvents reads each manifest through eventsOfManifest, which counts streams[].events with emits (the spelling catalogue.Hearing uses to let a module hear a stream). 1249/AC1 and AC2 in agreement_streams_test.go failed first with the live message and pass now; AC3 is the beside-catalogue test, passing in try build-1792416680567043959 (4m13s). It unblocks every mesh-controller pull request, issue 1247 first.

Reviewed-by: review-1249@shanks at 07a8f04e65

Issue 1249. Every mesh-controller check has failed `TestTheCataloguesEmittersAndConsumersAgree` since mesh-catalog #371 gave mesh-mail an `emits` list beside its own stream `mail`: the test read only `emits`, so `mesh-mail-notifier`'s consumer of `mesh-mail.mail.*.message.added` (a stream event) was reported as matching nothing. The catalogue is right; the test was not. Test-only: `theCataloguesEvents` reads each manifest through `eventsOfManifest`, which counts `streams[].events` with `emits` (the spelling `catalogue.Hearing` uses to let a module hear a stream). 1249/AC1 and AC2 in `agreement_streams_test.go` failed first with the live message and pass now; AC3 is the beside-catalogue test, passing in try build-1792416680567043959 (4m13s). It unblocks every mesh-controller pull request, issue 1247 first. Reviewed-by: review-1249@shanks at 07a8f04e65a34781da07b8ae41ee54664de28e0f

mesh-tools added 1 commit 2026-10-19 13:36:28 +00:00

Count a module's own stream events beside its emits in the catalogue agreement (issue 1249)

mesh/merge-gate head 07a8f04e65a3 merged into trunk a5a43c8f31f0 — pass: the change touches no module of the mesh's graph

Details

mesh/repo-check head 07a8f04e65a3 merged into trunk a5a43c8f31f0 — pass: its merge-check.sh passed

Details

mesh/delivery delivered

Details

07a8f04e65

mesh-tools commented

2026-10-19 13:36:39 +00:00

Delivery novox/mesh-controller@07a8f04e65a3 — delivered since 2026-10-19T13:42:17Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

2026-10-19 13:36 (new) → proposed (announced): novox/mesh-controller#395's head announced
2026-10-19 13:41 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
2026-10-19 13:41 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
2026-10-19 13:42 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
2026-10-19 13:42 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

**Delivery** `novox/mesh-controller@07a8f04e65a3` — **delivered** since 2026-10-19T13:42:17Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-19 13:36 (new) → proposed (announced): novox/mesh-controller#395's head announced - 2026-10-19 13:41 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-19 13:41 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-19 13:42 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-19 13:42 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-tools merged commit 5c807808e8 into main

2026-10-19 13:42:15 +00:00

mesh-tools deleted branch fix/1249-stream-events-agree

2026-10-19 13:42:15 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-controller#395