novox/mesh-controller
18
0
Fork 0
Code Issues Pull Requests 3 Releases Wiki Activity

R4g finish: reads-outside markers (issue 1935) #454

Merged
jschoubben merged 4 commits from feat/r4g-finish into main 2026-10-24 20:57:08 +00:00
Conversation 3 Commits 4 Files Changed 10
+16 -3
mesh-tools commented 2026-10-24 11:49:34 +00:00
Member
Copy Link
Copy Source

Delivery group feat/r4g-finish (design 47, milestone R4g+R5, its finish): hq, mesh-sdk, mesh-controller, mesh-delivery, mesh-catalog, mesh-media-catalog, mesh-host. One Approve, one delivery plan.

This member: reads-outside markers for the packages whose tests read outside their directory (issue 1935); main merged in (#453). After the group check fcb076c5387f: TestAPlanPassesATierWhoseMachineNeverReportsAfterTheBoundAndSendsTheNextToTheOthers waits until the plan shows b taken from its key instead of reading it the instant the tier moves (a timing flake on a loaded build node). Filtered tries try-1792845173701822933 and try-1792845370162666520 passed.

Reviewed-by: review-r4g-r3@shanks at ecbb317dc3
Pushed-by: lead-47@shanks

Delivery group feat/r4g-finish (design 47, milestone R4g+R5, its finish): hq, mesh-sdk, mesh-controller, mesh-delivery, mesh-catalog, mesh-media-catalog, mesh-host. One Approve, one delivery plan. This member: reads-outside markers for the packages whose tests read outside their directory (issue 1935); main merged in (#453). After the group check fcb076c5387f: TestAPlanPassesATierWhoseMachineNeverReportsAfterTheBoundAndSendsTheNextToTheOthers waits until the plan shows b taken from its key instead of reading it the instant the tier moves (a timing flake on a loaded build node). Filtered tries try-1792845173701822933 and try-1792845370162666520 passed. Reviewed-by: review-r4g-r3@shanks at ecbb317dc3244a5bb2063056178093fda2128bdb Pushed-by: lead-47@shanks
mesh-tools added 3 commits 2026-10-24 11:49:34 +00:00
Mark the packages whose tests read files outside their directory, so mesh-build-go never keeps their verdict (issue 1935) a96bd2ff38
Mark the packages whose tests read files outside their directory, found by the review (issue 1935) 8831c74f70
Merge main into feat/r4g-finish (#453)
mesh/delivery-group group feat/r4g-finish rejected: a member's own check failed
Details
mesh/delivery superseded: a newer head of the same pull request
Details
mesh/check failed: shanks: novox/mesh-delivery#35: modules/mesh-delivery-assigner/go.mod names mesh-sdk bc0c25e51052, which is neither on mesh-sdk's t…
dd2d8b91be
mesh-tools commented 2026-10-24 11:49:37 +00:00
Author
Member
Copy Link
Copy Source

Delivery novox/mesh-controller@ecbb317dc324 — delivered since 2026-10-24T21:11:25Z

Delivery plan — builds mesh-controller → novox; no bus step

  • tier 0: mesh-controller
  • novox: receives mesh-controller

Group feat/r4g-finish: novox/hq@2249d30151, novox/mesh-catalog@2fabbe556e, novox/mesh-controller@ecbb317dc3, novox/mesh-delivery@65496fc4f7, novox/mesh-host@13bdcb694b, novox/mesh-media-catalog@6392690b90, novox/mesh-sdk@bfc3883af9

  • composed together: pass — the checker's verdict at the members' heads (590ced519c20)

Machines

  • adwaita on every machine running it: sent
  • blueman on every machine running it: sent
  • brother on every machine running it: sent
  • forticlient on every machine running it: sent
  • i3 on every machine running it: sent
  • lemurs on every machine running it: sent
  • mesh-build-image on every machine running it: sent
  • mesh-build-node on every machine running it: sent
  • mesh-delivery-builder on every machine running it: sent
  • mesh-delivery-checker on every machine running it: sent
  • mesh-delivery-gate on every machine running it: sent
  • mesh-delivery-indexer on every machine running it: sent
  • mesh-delivery-teller on every machine running it: sent
  • mesh-delivery-watchman on every machine running it: sent
  • mesh-host on every machine running it: sent
  • mesh-issues on every machine running it: sent
  • mesh-knowledge on every machine running it: sent
  • mesh-mail on every machine running it: sent
  • mesh-mail-notifier on every machine running it: sent
  • mesh-mail-reader on every machine running it: sent
  • mesh-provisioner-client on every machine running it: sent
  • mesh-sdk on every machine running it: sent
  • minio on every machine running it: sent
  • networkmanager on every machine running it: sent
  • nextcloud-client on every machine running it: sent
  • nm-applet on every machine running it: sent
  • openrazer on every machine running it: sent
  • pacman on every machine running it: sent
  • polychromatic on every machine running it: sent
  • postgres on every machine running it: sent
  • slack on every machine running it: sent
  • systemd-networkd on every machine running it: sent
  • xorg on every machine running it: sent
  • xterm on every machine running it: sent
  • mesh-controller on every machine running it: sent
  • mesh-build-go on every machine running it: sent
  • mesh-delivery-assigner on every machine running it: sent

Transitions

  • 2026-10-24 12:32 (new) → proposed (announced): novox/mesh-controller#454's head announced
  • 2026-10-24 12:52 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-24 12:52 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed
  • 2026-10-24 14:20 rejected → proposed (recheck): its mesh/check judged it again: pass ecbb317dc3 on 1b0fd8b442 | unit 4575 run, 5233 kept, 13 skipped | integration 4618 run, 6407 kept, 21 skipped …
  • 2026-10-24 14:20 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-24 14:20 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-24 15:37 ready → proposed (trunk moved): out of date: judged against trunk 1b0fd8b442, the trunk is now 34b105ea88df; judged again on a recheck or when it is merged
  • 2026-10-24 16:01 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-24 16:01 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed
  • 2026-10-24 20:57 rejected → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides that it goes on
  • 2026-10-24 20:59 held → delivering (go): its walk started on a word that was not this owner's: the controller's own path, which waits for nobody, or a person's plans go
  • 2026-10-24 21:11 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@ecbb317dc324` — **delivered** since 2026-10-24T21:11:25Z **Delivery plan** — builds mesh-controller → novox; no bus step - tier 0: mesh-controller - novox: receives mesh-controller **Group** `feat/r4g-finish`: novox/hq@2249d30151e8, novox/mesh-catalog@2fabbe556e73, novox/mesh-controller@ecbb317dc324, novox/mesh-delivery@65496fc4f7a6, novox/mesh-host@13bdcb694be0, novox/mesh-media-catalog@6392690b90c2, novox/mesh-sdk@bfc3883af980 - composed together: pass — the checker's verdict at the members' heads (590ced519c20) **Machines** - adwaita on every machine running it: sent - blueman on every machine running it: sent - brother on every machine running it: sent - forticlient on every machine running it: sent - i3 on every machine running it: sent - lemurs on every machine running it: sent - mesh-build-image on every machine running it: sent - mesh-build-node on every machine running it: sent - mesh-delivery-builder on every machine running it: sent - mesh-delivery-checker on every machine running it: sent - mesh-delivery-gate on every machine running it: sent - mesh-delivery-indexer on every machine running it: sent - mesh-delivery-teller on every machine running it: sent - mesh-delivery-watchman on every machine running it: sent - mesh-host on every machine running it: sent - mesh-issues on every machine running it: sent - mesh-knowledge on every machine running it: sent - mesh-mail on every machine running it: sent - mesh-mail-notifier on every machine running it: sent - mesh-mail-reader on every machine running it: sent - mesh-provisioner-client on every machine running it: sent - mesh-sdk on every machine running it: sent - minio on every machine running it: sent - networkmanager on every machine running it: sent - nextcloud-client on every machine running it: sent - nm-applet on every machine running it: sent - openrazer on every machine running it: sent - pacman on every machine running it: sent - polychromatic on every machine running it: sent - postgres on every machine running it: sent - slack on every machine running it: sent - systemd-networkd on every machine running it: sent - xorg on every machine running it: sent - xterm on every machine running it: sent - mesh-controller on every machine running it: sent - mesh-build-go on every machine running it: sent - mesh-delivery-assigner on every machine running it: sent **Transitions** - 2026-10-24 12:32 (new) → proposed (announced): novox/mesh-controller#454's head announced - 2026-10-24 12:52 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-24 12:52 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed - 2026-10-24 14:20 rejected → proposed (recheck): its mesh/check judged it again: pass ecbb317dc324 on 1b0fd8b442c4 | unit 4575 run, 5233 kept, 13 skipped | integration 4618 run, 6407 kept, 21 skipped … - 2026-10-24 14:20 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-24 14:20 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-24 15:37 ready → proposed (trunk moved): out of date: judged against trunk 1b0fd8b442c4, the trunk is now 34b105ea88df; judged again on a recheck or when it is merged - 2026-10-24 16:01 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-24 16:01 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed - 2026-10-24 20:57 rejected → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides that it goes on - 2026-10-24 20:59 held → delivering (go): its walk started on a word that was not this owner's: the controller's own path, which waits for nobody, or a person's `plans go` - 2026-10-24 21:11 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
jschoubben added 1 commit 2026-10-24 12:32:50 +00:00
Wait for tier 1's module to be marked taken from its key: the tier moves in one look and the mark comes in the next, so a loaded build node read it between them (group check fcb076c5387f)
mesh/check checking ecbb317dc324 on bdb8193456e1 | novox/mesh-controller#454 in group feat/r4g-finish
mesh/delivery delivered
Details
mesh/delivery-group group feat/r4g-finish delivered: every member is delivered
Details
ecbb317dc3
mesh-tools commented 2026-10-24 16:01:21 +00:00
Author
Member
Copy Link
Copy Source

mesh-delivery: not merged. This pull request's checks passed at ecbb317dc3, and now its check failed: failed: shanks: novox/mesh-delivery#35 does not merge into the trunk: files in conflict: modules/mesh-delivery-checker/internal/check/pins_…. A new head, or a recheck that passes, asks the operator again.

mesh-delivery: **not merged.** This pull request's checks passed at ecbb317dc3244a5bb2063056178093fda2128bdb, and now its check failed: failed: shanks: novox/mesh-delivery#35 does not merge into the trunk: files in conflict: modules/mesh-delivery-checker/internal/check/pins_…. A new head, or a recheck that passes, asks the operator again.
mesh-tools commented 2026-10-24 19:55:04 +00:00
Author
Member
Copy Link
Copy Source

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.
jschoubben merged commit bdb8193456 into main 2026-10-24 20:57:08 +00:00
jschoubben deleted branch feat/r4g-finish 2026-10-24 20:57:08 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#454