novox/mesh-controller
18
0
Fork 0
Code Issues Pull Requests 3 Releases Wiki Activity

Keep moved modules' filled paths in the node's own composition, put every file object, grant access-act and the provisioner's have read (issue 1944) #458

Merged
jschoubben merged 4 commits from fix/r6-node-composition into main 2026-10-25 00:17:43 +00:00
Conversation 1 Commits 4 Files Changed 12
+233 -11
mesh-tools commented 2026-10-25 00:17:00 +00:00
Member
Copy Link
Copy Source

The release-6 controller dropped the filled paths of modules moved into a node's own composition (composed_writer.go:101-108), so the node-engine wrote those files empty (issue 1944). It also composed from a body that names large files by digest, so their objects were never put, and novox's own composition could not apply (issue 1945 note 16). Now: moved modules' filled paths stay in the node's own composition; compositions are made from the inline body and a composition naming an object the bucket lacks is refused; the node is granted mesh.node..ask.access-act (missing since ADR 0325); the provisioner client may read its node's own have (node-engine_have, key .node, read only).

Delivery group fix/r6-node-composition: mesh-sdk, mesh-controller, mesh-host, mesh-delivery, mesh-catalog.

Tries: try-1792886542022660571 passed on 3dadc46e.
Reviewed-by: reviewer-r6m@shanks at 3dadc46ee6
Pushed-by: lead-47@shanks

The release-6 controller dropped the filled paths of modules moved into a node's own composition (composed_writer.go:101-108), so the node-engine wrote those files empty (issue 1944). It also composed from a body that names large files by digest, so their objects were never put, and novox's own composition could not apply (issue 1945 note 16). Now: moved modules' filled paths stay in the node's own composition; compositions are made from the inline body and a composition naming an object the bucket lacks is refused; the node is granted mesh.node.<n>.ask.access-act (missing since ADR 0325); the provisioner client may read its node's own have (node-engine_have, key <node>.node, read only). Delivery group fix/r6-node-composition: mesh-sdk, mesh-controller, mesh-host, mesh-delivery, mesh-catalog. Tries: try-1792886542022660571 passed on 3dadc46e. Reviewed-by: reviewer-r6m@shanks at 3dadc46ee6ccb47fed038394a483af722ff542a3 Pushed-by: lead-47@shanks
mesh-tools added 4 commits 2026-10-25 00:17:01 +00:00
Grant each node-engine its own access-act ask, which it has subscribed to since ADR 0325 and was refused at every connect (issue 1945) b1f758ed71
Split compositions from the inline body so their large files' objects are put, and refuse a composition naming an object the bucket lacks (issue 1945) 82c89bec65
Keep the filled paths of the modules moved into a node's own composition, which the node-engine otherwise wrote empty (issue 1945) d8aa565fee
Grant each provisioner client a read of its node's own have, so it refills when the node's own composition moves (issue 1945)
mesh/delivery checking
Details
mesh/delivery-group group fix/r6-node-composition held: a member is held: novox/mesh-sdk@10b6e202320f (merged without a passing check: only a person decides wh…
Details
mesh/check checking 3dadc46ee6cc on ba4d15657343 | novox/mesh-controller#458 in group fix/r6-node-composition
3dadc46ee6
mesh-tools commented 2026-10-25 00:17:03 +00:00
Author
Member
Copy Link
Copy Source

Delivery novox/mesh-controller@3dadc46ee6cc — held since 2026-10-25T00:17:45Z

Held for a person: merged without a passing check: only a person decides what follows — the merge reached the trunk without a passing check.

Source — source.main moved to novox/mesh-controller@7039c1b4b3. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/r6-node-composition: novox/mesh-catalog@53749833bf, novox/mesh-controller@3dadc46ee6, novox/mesh-delivery@48aaecf556, novox/mesh-host@4e6b756bd2, novox/mesh-sdk@10b6e20232

Transitions

  • 2026-10-25 00:17 (new) → proposed (announced): novox/mesh-controller#458's head announced
  • 2026-10-25 00:17 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides what follows

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-controller@3dadc46ee6cc` — **held** since 2026-10-25T00:17:45Z Held for a person: merged without a passing check: only a person decides what follows — the merge reached the trunk without a passing check. **Source** — source.main moved to novox/mesh-controller@7039c1b4b3a6. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/r6-node-composition`: novox/mesh-catalog@53749833bfbd, novox/mesh-controller@3dadc46ee6cc, novox/mesh-delivery@48aaecf556c5, novox/mesh-host@4e6b756bd225, novox/mesh-sdk@10b6e202320f **Transitions** - 2026-10-25 00:17 (new) → proposed (announced): novox/mesh-controller#458's head announced - 2026-10-25 00:17 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides what follows The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
jschoubben merged commit 7039c1b4b3 into main 2026-10-25 00:17:43 +00:00
jschoubben deleted branch fix/r6-node-composition 2026-10-25 00:17:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-controller#458