Declarations test: the indexer stand-in answers the trunk value at the trunk's commit alone (issue 1945) #471

2026-10-26T12:29:16Z

mesh-tools commented

2026-10-26 12:29:16 +00:00

On the operator's word (2026-10-26 13:2x, 'maybe you can also fix it while still releasing it'); the take-over group merged before this commit reached it, so it comes on its own. TestTheDeclarationsStreamGoesOnceEveryNodeRunsTheNewEngine failed on main since #465 (take-in registers on the fingerprint): the test's indexer stand-in (composed_integration_test.go trunkKeys.ModuleAt) answered the trunk value for every commit, so mesh-host, registered at an older commit, looked already at the trunk's fingerprint; the take-in only moved its commit, recorded no build, and declarationsDone saw an empty fingerprint. The stand-in now answers only at the trunk's commit, as the real indexer does (builderkeys.ErrNoValue otherwise). Test file only; controller code unchanged. Fails before, passes after (local run against the test store; fix-decltest@shanks); issue 1945 notes 87-88.

Reviewed-by: lead-47@shanks at 23226384e5

On the operator's word (2026-10-26 13:2x, 'maybe you can also fix it while still releasing it'); the take-over group merged before this commit reached it, so it comes on its own. TestTheDeclarationsStreamGoesOnceEveryNodeRunsTheNewEngine failed on main since #465 (take-in registers on the fingerprint): the test's indexer stand-in (composed_integration_test.go trunkKeys.ModuleAt) answered the trunk value for every commit, so mesh-host, registered at an older commit, looked already at the trunk's fingerprint; the take-in only moved its commit, recorded no build, and declarationsDone saw an empty fingerprint. The stand-in now answers only at the trunk's commit, as the real indexer does (builderkeys.ErrNoValue otherwise). Test file only; controller code unchanged. Fails before, passes after (local run against the test store; fix-decltest@shanks); issue 1945 notes 87-88. Reviewed-by: lead-47@shanks at 23226384e52933586a8ad7bf786ac48a0e9401d3

mesh-tools added 1 commit 2026-10-26 12:29:16 +00:00

Answer the indexer's trunk value at the trunk's commit alone in the declarations test, so its take-in records mesh-host's build (issue 1945)

mesh/delivery merged: source.main moved to novox/mesh-controller@08a261ac1a6d

Details

mesh/check being carried to 23226384e529 on 08a261ac1a6d | from 350f8ebdfe5f

23226384e5

The stub answered the trunk for every commit, so since registering on the
fingerprint (666d1b68, #465) mesh-host, registered at an older commit, looked
already at the trunk's fingerprint: the take-in only moved its commit, no build
was recorded, and the fingerprints never named the new node-engine. The real
indexer holds no value at a commit it never indexed.

(cherry picked from commit 779533764b)

mesh-tools commented

2026-10-26 12:29:20 +00:00

Delivery novox/mesh-controller@23226384e529 — merged since 2026-10-26T12:30:19Z

Source — source.main moved to novox/mesh-controller@08a261ac1a. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-10-26 12:29 (new) → proposed (announced): novox/mesh-controller#471's head announced
2026-10-26 12:29 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-26 12:30 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-controller@23226384e529` — **merged** since 2026-10-26T12:30:19Z **Source** — source.main moved to novox/mesh-controller@08a261ac1a6d. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-26 12:29 (new) → proposed (announced): novox/mesh-controller#471's head announced - 2026-10-26 12:29 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 12:30 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 08a261ac1a into main

2026-10-26 12:30:18 +00:00

mesh-tools deleted branch fix/declarations-test-stand-in

2026-10-26 12:30:19 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-controller#471