jschoubben
f325073982
Two halves of novox/hq ADR 0131. Migration 0040 moves the mesh-broker row from `amqp` to `mesh-bus`, so the seat's holder answers for the mesh's bus and not for the wire protocol the old broker spoke — which is what let only the retiring broker hold the seat that names the bus. Safe under the current holder: the control plane composes its own address through the seat by name and the overview derives holders by name; only registration and provision resolution read the column. What must not happen in between is re-registering the current holder. And the parser refuses a manifest that provides or requires `amqp`, each refusal saying what to do instead: a module reaches the mesh's bus through the sdk and depends on the seat, not on a protocol. A whole-catalogue test asserts nothing beside this checkout names it; the three modules that did are removed there. Two tests that used the old broker as a fixture now use the module that replaces it or a manifest this package owns.
88 lines
4.2 KiB
Go
88 lines
4.2 KiB
Go
package catalogue
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// The mesh's bus is one per mesh, read from the catalogue beside this checkout.
|
|
//
|
|
// **This is step 2's claim, and it is checked here rather than in a bed** (novox/hq ADR 0116):
|
|
// adoption puts the NATS server into the `mesh-broker` seat on a mesh that is already running,
|
|
// and the property that matters is that a second one anywhere is refused *when it is assigned*,
|
|
// not discovered later as two servers holding different halves of the mesh's traffic. A second
|
|
// bus is not a degraded mesh; it is two meshes that both believe they are the one.
|
|
func TestASecondMeshBusAnywhereIsRefusedByName(t *testing.T) {
|
|
nats := catalogueManifest(t, "nats")
|
|
|
|
if _, err := Resolve(shelf(nats), []string{"nats"}, workstation(), World{}); err != nil {
|
|
t.Fatalf("the bus alone does not resolve: %v", err)
|
|
}
|
|
|
|
elsewhere := World{Held: []Held{{Claim: "mesh-broker", Scope: ScopeMesh,
|
|
Node: "anchor", Module: "nats"}}}
|
|
other := workstation()
|
|
other.Name = "laptop"
|
|
_, err := Resolve(shelf(nats), []string{"nats"}, other, elsewhere)
|
|
if err == nil {
|
|
t.Fatal("a second bus was accepted on another machine")
|
|
}
|
|
if !strings.Contains(err.Error(), "mesh-broker") || !strings.Contains(err.Error(), "one per mesh") {
|
|
t.Fatalf("refused without naming the seat: %v", err)
|
|
}
|
|
}
|
|
|
|
// The seat is the server's role, not the product's name (novox/hq ADR 0079). A different
|
|
// implementation of the bus claims the same seat, and the mesh refuses it for the same reason —
|
|
// which is the property that lets the bus be replaced at all.
|
|
func TestTheSeatRefusesADifferentBusToo(t *testing.T) {
|
|
nats := catalogueManifest(t, "nats")
|
|
held := World{Held: []Held{{Claim: "mesh-broker", Scope: ScopeMesh,
|
|
Node: "anchor", Module: "some-other-broker"}}}
|
|
other := workstation()
|
|
other.Name = "laptop"
|
|
if _, err := Resolve(shelf(nats), []string{"nats"}, other, held); err == nil {
|
|
t.Fatal("the seat admitted a second holder because the module's name differed")
|
|
}
|
|
}
|
|
|
|
// The old broker is gone from the catalogue (novox/hq ADR 0131, design 28 task 5.4), so it is no
|
|
// longer a fixture here. That two eligible holders stand beside each other with one on record is
|
|
// pinned in holdings_test.go against manifests this package owns.
|
|
|
|
// **A seat and the interface it delivers are different names, and renaming one must not rename
|
|
// the other** (novox/hq ADR 0118). This nearly went wrong: the seats were renamed to the `mesh-*`
|
|
// prefix, and a blanket search-and-replace also renamed `npm-package-registry` and `git` where
|
|
// they are *provisions* — which a consumer requires and a provider offers. The tests failed with
|
|
// "the package registry is served on <nil>", which does not say "you renamed an interface".
|
|
func TestRenamingASeatDidNotRenameTheInterfaceItDelivers(t *testing.T) {
|
|
for _, pair := range []struct{ seat, delivers string }{
|
|
{"git", "git"},
|
|
{"npm-package-registry", "npm-package-registry"},
|
|
{"the-artifact-store", "artifact-store"},
|
|
{"mesh-store", "postgres-database"},
|
|
{"mesh-broker", "mesh-bus"},
|
|
} {
|
|
s, known := SeatNamed(pair.seat)
|
|
if !known {
|
|
t.Fatalf("%q is not a seat", pair.seat)
|
|
}
|
|
if s.Delivers != pair.delivers {
|
|
t.Errorf("the %s seat delivers %q, expected %q — renaming the seat moved the "+
|
|
"interface with it, and every consumer requiring it would stop resolving",
|
|
pair.seat, s.Delivers, pair.delivers)
|
|
}
|
|
// **Three of these deliberately share a name with what they deliver**, and that is not an
|
|
// incomplete rename. Renaming a seat that delivers a provision cascades to every consumer
|
|
// requiring it, with a mesh-wide window where a holder stops resolving mid-flight — so the
|
|
// trunk deferred exactly those three (novox/hq ADR 0121) while renaming the node-scoped ones.
|
|
// What this test is for is the other direction: that renaming a seat never moves the
|
|
// interface, which once produced "the package registry is served on <nil>".
|
|
}
|
|
}
|
|
|
|
// A manifest written against an old seat name is told what it became rather than refused as
|
|
// unknown. **That map is the controller's store now, not this package** (novox/hq ADR 0122): a
|
|
// rename is a row, so the courtesy survives a rename nobody recompiled for. Checked where the
|
|
// table is read, not here, where there is no longer a hardcoded list to check against.
|