jochen
208901c6cc
A merge planned without looking at open plans, so two plans worked the same modules and a stuck plan stayed open for ever. The newer plan folds in what older plans of the same repository and branch had not built or sent, and closes them as superseded. A person can close a stuck plan by id with `plans close <id>`.
76 lines
2.9 KiB
Go
76 lines
2.9 KiB
Go
package inventory
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// A plan is a record the mesh keeps and resumes (novox/hq ADR 0162): written whole, read back open,
|
|
// advanced, and gone from the open ones when done.
|
|
func TestAPlanIsKeptAdvancedAndResumedFromTheStore(t *testing.T) {
|
|
inv := ForTest(t)
|
|
ctx := t.Context()
|
|
p := Plan{ID: "plan-1", Repository: "novox/mesh-tools", Commit: "abc", Created: time.Now().UTC(),
|
|
State: PlanBuilding, Tiers: [][]string{{"mesh-tools"}, {"builder"}, {"shop"}},
|
|
Modules: map[string]*PlanModule{"mesh-tools": {}, "builder": {}, "shop": {}}}
|
|
if err := inv.SavePlan(ctx, p); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
open, err := inv.OpenPlans(ctx)
|
|
if err != nil || len(open) != 1 || open[0].ID != "plan-1" || len(open[0].Tiers) != 3 {
|
|
t.Fatalf("the plan was not kept whole: %v %+v", err, open)
|
|
}
|
|
// Another controller picks it up where it was left: a tier advanced and a module built.
|
|
now := time.Now().UTC()
|
|
resumed := open[0]
|
|
resumed.Tier = 1
|
|
resumed.Modules["mesh-tools"].State = "built"
|
|
resumed.Modules["mesh-tools"].BuiltAt = &now
|
|
resumed.State = PlanRolling
|
|
resumed.Note = "tier 0 built; waiting for builder on anchor to be applied"
|
|
if err := inv.SavePlan(ctx, resumed); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
again, err := inv.PlanByID(ctx, "plan-1")
|
|
if err != nil || again.Tier != 1 || again.Modules["mesh-tools"].State != "built" || again.State != PlanRolling {
|
|
t.Fatalf("the advanced plan did not come back as left: %v %+v", err, again)
|
|
}
|
|
again.State = PlanDone
|
|
if err := inv.SavePlan(ctx, again); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if open, _ = inv.OpenPlans(ctx); len(open) != 0 {
|
|
t.Fatalf("a done plan is not open: %+v", open)
|
|
}
|
|
if recent, _ := inv.RecentPlans(ctx, 5); len(recent) != 1 || recent[0].State != PlanDone {
|
|
t.Fatalf("a done plan is still among the recent ones: %+v", recent)
|
|
}
|
|
}
|
|
|
|
// novox/hq issue 254: a plan keeps the branch its merge went into, and a superseded plan is not open.
|
|
func TestASupersededPlanIsNotOpen(t *testing.T) {
|
|
inv := ForTest(t)
|
|
ctx := t.Context()
|
|
p := Plan{ID: "plan-1", Repository: "novox/mesh-catalog", Branch: "main", Commit: "abc",
|
|
Created: time.Now().UTC(), State: PlanBuilding, Tiers: [][]string{{"gitea"}},
|
|
Modules: map[string]*PlanModule{"gitea": {}}}
|
|
if err := inv.SavePlan(ctx, p); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
kept, err := inv.PlanByID(ctx, "plan-1")
|
|
if err != nil || kept.Branch != "main" {
|
|
t.Fatalf("the branch was not kept: %v %+v", err, kept)
|
|
}
|
|
kept.State = PlanSuperseded
|
|
kept.Note = "superseded at tier 0 by plan-2"
|
|
if err := inv.SavePlan(ctx, kept); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if open, err := inv.OpenPlans(ctx); err != nil || len(open) != 0 {
|
|
t.Fatalf("a superseded plan is still open: %v %+v", err, open)
|
|
}
|
|
if recent, _ := inv.RecentPlans(ctx, 5); len(recent) != 1 || recent[0].State != PlanSuperseded {
|
|
t.Fatalf("a superseded plan is not among the recent ones as superseded: %+v", recent)
|
|
}
|
|
}
|