jschoubben
e419d0182f
The controller asks no build of anybody (ADR 0501 §5, ADR 0525 clause 6, ADR 0503 §3). Every module of a walk is taken from the builder's done key; a key not done yet waits, named in the plan, and never fails it. - C2b/C2c: internal/builder and cmd/mesh-controller's asks go (askABuild, onlyTheBuildersOwn, buildOneAsked, takeIn from an outcome, buildAgentsOwn, the builder's say and its fallback, the daemon hearing an outcome). The server follows the retired seats' built subjects only to let go of them, because the installer's carried user list names them. - C2d: replay, queue, cancel, clear, kill, pause, resume, delivery-check, check-here and merge-gate are refused by name. - C3: the check queues (CHECKS_READY, CHECKS_OTHER) and their workers, the checks-running and plans-building buckets and their grants, the build queue and its hold (plans_building.go, queue.go, link/holds.go, builds_nats.go, checks_nats.go). - C4: merge_gate*.go, the pull request's repo-check path, the Checked event and its layers; a pull request asks the controller nothing but to tell mesh-config what its head declares. - C5: the builds bucket is written only by key_takein. - C10 (help and refusals): the terminal's help lists only what is served. Integration tests of the plan's tiers, sends, stops and retries now run on a stand-in builder with a done key for every module (walk_keys_scaffold_integration_test.go); the tests of the asks, the queue, the merge gate and the replays are deleted.
80 lines
3.6 KiB
Go
80 lines
3.6 KiB
Go
//go:build integration
|
|
|
|
package main
|
|
|
|
import (
|
|
"encoding/json"
|
|
"strings"
|
|
"testing"
|
|
|
|
"git.novox.be/novox/mesh-sdk/go/catalogue"
|
|
)
|
|
|
|
func TestRegistrationPublishesTheNewestTrunkListAndJudgesEveryModuleAgainstIt(t *testing.T) {
|
|
withoutAPublishedList(t)
|
|
open := aMesh(t)
|
|
ctx := t.Context()
|
|
|
|
// A manifest naming font-size registers, and its build's list is published.
|
|
if _, _, err := takeIn(ctx, open.inventory, asTheOperator(t, open.inventory,
|
|
catalogueBuild("b-1", notifierFallingBackTo("font-size", "number"), theFirstKeys, 10))); err != nil {
|
|
t.Fatalf("a module naming font-size was not registered: %v", err)
|
|
}
|
|
kept, has, err := open.inventory.PredefinedKept(ctx)
|
|
if err != nil || !has || kept.Generation != 10 || kept.Build != "b-1" {
|
|
t.Fatalf("the list was not published: %+v %v %v", kept, has, err)
|
|
}
|
|
if got := catalogue.PublishedPredefined(); len(got) != 2 {
|
|
t.Fatalf("the controller judges against %v, not the list published", got)
|
|
}
|
|
|
|
// One naming a key not on the list, or of another type, is refused and never enters the catalogue.
|
|
for i, c := range []struct{ manifest, says string }{
|
|
{notifierFallingBackTo("font-scale", "number"), "not on the list"},
|
|
{notifierFallingBackTo("font-size", "string"), "which is a number"},
|
|
} {
|
|
id := []string{"b-2", "b-3"}[i]
|
|
if _, _, err := takeIn(ctx, open.inventory, catalogueBuild(id, c.manifest, theFirstKeys, 10)); err == nil ||
|
|
!strings.Contains(err.Error(), c.says) {
|
|
t.Errorf("wanted the registration refused saying %q, got %v", c.says, err)
|
|
}
|
|
}
|
|
src, err := open.inventory.SourceOf(ctx, "notifier")
|
|
if err != nil || src.BuiltFrom != strings.Repeat("1", 12) {
|
|
t.Fatalf("a refused build replaced the registered one: %+v %v", src, err)
|
|
}
|
|
|
|
// A newer build's list, which drops agent-managed-settings, replaces the published one.
|
|
smaller := `{"font-size": {"type": "number", "description": "points", "minimum": 6, "maximum": 72}}`
|
|
if _, _, err := takeIn(ctx, open.inventory, catalogueBuild("b-4",
|
|
notifierFallingBackTo("font-size", "number"), smaller, 12)); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// The older build's outcome heard later registers nothing new about the list: the newer stands.
|
|
if _, _, err := takeIn(ctx, open.inventory, catalogueBuild("b-5",
|
|
notifierFallingBackTo("font-size", "number"), theFirstKeys, 11)); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
kept, _, _ = open.inventory.PredefinedKept(ctx)
|
|
if kept.Build != "b-4" || len(kept.Keys) != 1 || len(catalogue.PublishedPredefined()) != 1 {
|
|
t.Fatalf("an older build's list heard later replaced the newer one: %+v", kept)
|
|
}
|
|
|
|
// A build of another repository publishes nothing, and its manifest is judged against the published list.
|
|
other := catalogueBuild("b-6", notifierFallingBackTo("font-size", "number"), theFirstKeys, 99)
|
|
other.Repository, other.Source.Repository = "http://forge.internal:20000/novox/notifier.git", "novox/notifier"
|
|
other.Manifest = json.RawMessage(strings.Replace(notifierFallingBackTo("font-size", "number"), `"notifier"`,
|
|
`"chimes"`, 1))
|
|
if _, _, err := takeIn(ctx, open.inventory, asTheOperator(t, open.inventory, other)); err != nil {
|
|
t.Fatalf("a module of another repository naming a published key: %v", err)
|
|
}
|
|
if kept, _, _ = open.inventory.PredefinedKept(ctx); kept.Build != "b-4" {
|
|
t.Fatalf("a build of another repository published its list: %+v", kept)
|
|
}
|
|
other.ID, other.Manifest = "b-7", json.RawMessage(strings.Replace(notifierFallingBackTo("agent-managed-settings",
|
|
"number"), `"notifier"`, `"chimes"`, 1))
|
|
if _, _, err := takeIn(ctx, open.inventory, other); err == nil || !strings.Contains(err.Error(), "not on the list") {
|
|
t.Fatalf("a key only another repository's list holds was registered: %v", err)
|
|
}
|
|
}
|