Files
mesh-controller/cmd/mesh-controller/composed_node_last_test.go
T
jschoubben eafd1883f6
mesh/delivery merged: source.main moved to novox/mesh-controller@0fff3efd4e0b
mesh/check pass eafd1883f65c on 0fff3efd4e0b | unit 953 run, 171 kept, 2 skipped | integration 1612 run, 232 kept, 7 skipped | over bound: integration…
Write a node's own composition last, and not in a pass where a module's composition failed (issue 1945)
2026-10-25 02:57:24 +02:00

57 lines
2.2 KiB
Go

package main
import (
"context"
"encoding/json"
"testing"
sdkdelivery "git.novox.be/novox/mesh-sdk/go/delivery"
)
// The node's own composition is written last, and not at all in a pass where a module's composition failed: written
// without the resources that moved to that module, it would have the node-engine remove them while the module's own
// composition is not there to take them (issue 1945, the review's gap 1).
func TestTheNodesOwnIsWrittenLastAndNotAfterAModuleFailed(t *testing.T) {
own, _ := sdkdelivery.ComposedNodeKey("ace")
// "aaa" sorts before "ace.node"... and "zzz" after: the node's own must still come last.
a, _ := sdkdelivery.ComposedKey("ace", "aaa", fp2For('a'))
z, _ := sdkdelivery.ComposedKey("ace", "zzz", fp2For('b'))
file := func(module string) json.RawMessage {
return json.RawMessage(`{"id":"` + module + `.f","type":"file","module":"` + module + `","path":"/etc/` + module +
`","mode":"0644","content":"x"}`)
}
comps := map[string]sdkdelivery.Composed{
own: {Node: "ace", Resources: []json.RawMessage{}},
a: {Node: "ace", Module: "aaa", FP: fp2For('a'), Resources: []json.RawMessage{file("aaa")}},
z: {Node: "ace", Module: "zzz", FP: fp2For('b'), Resources: []json.RawMessage{file("zzz")}},
}
at, _, _, _ := aPlace(t, "ace")
wrote, err := writeNodeCompositions(context.Background(), at, comps)
if err != nil {
t.Fatal(err)
}
if len(wrote) != 3 || wrote[2] != own {
t.Fatalf("written in the order %v, the node's own last", wrote)
}
// A module's composition that cannot be written: the node's own is not written in that pass.
at, _, _, _ = aPlace(t, "ace")
broken := comps[z]
broken.Resources = []json.RawMessage{file("other")} // a resource of another module: refused
comps[z] = broken
if _, err := writeNodeCompositions(context.Background(), at, comps); err == nil {
t.Fatal("a composition that cannot be written was not said")
}
if _, rev, _ := readComposed(context.Background(), at.bucket, own); rev != 0 {
t.Fatal("the node's own composition was written in a pass where a module's failed")
}
}
func fp2For(c byte) string {
b := make([]byte, 64)
for i := range b {
b[i] = c
}
return sdkdelivery.SourcePrefix2 + string(b)
}