One commit, one plan: a commit off the trunk — a pull request's head, a branch built by hand, a rebuild or replay of one — is for checking. The build seat reads from its clone which branches hold the commit, and the controller records and never registers a build whose commit is not on the branch the module follows (the repository's default for a new one), so nothing off the trunk can be sent. A pull request's check now carries its change plan, computed by the planner: what a merge would build in which order, what each machine would receive, and what is not an ordinary send — the bus step, a module waiting for a person, a provider's consumers.
156 lines
4.9 KiB
Go
156 lines
4.9 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"sort"
|
|
"strings"
|
|
|
|
"github.com/novox/mesh-controller/internal/inventory"
|
|
"github.com/novox/mesh-controller/internal/link"
|
|
)
|
|
|
|
// The change plan (novox/hq ADR 0238): **one commit, one plan** — what a change does to the mesh, computed
|
|
// from its diffset (a repository, the branch it merges into, the commit at hand) by the planner, never by
|
|
// a mapping of its own. reachOfMerge answers what moves and what follows it; this adds where each module
|
|
// goes — the deploy plan, machine by machine in the build plan's order — and what is not an ordinary
|
|
// send. A pull request's check posts it with its verdict; the release a merge makes follows the same
|
|
// planner, so the two can be compared.
|
|
|
|
// policyOf is a module's upgrade policy, as the controller holds it; false when it cannot be read.
|
|
type policyOf func(module string) (inventory.Upgrade, bool)
|
|
|
|
// changePlanOf is the change plan of a reach: pure, so it is tested without a store.
|
|
func changePlanOf(repository, base, head string, r mergeReach, entries []inventory.Entry, policy policyOf) link.ChangePlan {
|
|
p := link.ChangePlan{Repository: repository, Base: base, Head: head, Moved: r.Moved(), Dependents: r.Dependents(),
|
|
New: r.Added, Unread: r.Unread, Tiers: r.Plan.Tiers}
|
|
byName := map[string]inventory.Entry{}
|
|
for _, e := range entries {
|
|
byName[e.Manifest.Module] = e
|
|
}
|
|
machines := map[string]*link.MachinePlan{}
|
|
machine := func(name string) *link.MachinePlan {
|
|
if machines[name] == nil {
|
|
machines[name] = &link.MachinePlan{Machine: name}
|
|
}
|
|
return machines[name]
|
|
}
|
|
for _, tier := range r.Plan.Tiers {
|
|
for _, name := range tier {
|
|
e, held := byName[name]
|
|
if !held {
|
|
continue
|
|
}
|
|
u, known := policy(name)
|
|
waits := known && !u.RollOut
|
|
for _, on := range e.On {
|
|
if waits {
|
|
machine(on).Waits = append(machine(on).Waits, name)
|
|
} else {
|
|
machine(on).Receives = append(machine(on).Receives, name)
|
|
}
|
|
}
|
|
switch {
|
|
case name == "nats":
|
|
p.Steps = append(p.Steps, "a planned bus step: the bus is upgraded by `bus upgrade`, never by an ordinary send")
|
|
case waits && len(e.On) > 0:
|
|
p.Steps = append(p.Steps, fmt.Sprintf("%s waits for a person: its policy records (%s)", name,
|
|
orNone(u.From)))
|
|
}
|
|
if len(e.Manifest.Provides) > 0 && len(e.On) > 0 {
|
|
var offers []string
|
|
for _, o := range e.Manifest.Provides {
|
|
offers = append(offers, o.Name)
|
|
}
|
|
p.Steps = append(p.Steps, fmt.Sprintf("%s provides %s: its consumers are sent again after it",
|
|
name, strings.Join(offers, ", ")))
|
|
}
|
|
if e.Manifest.Data != nil && len(e.On) > 0 {
|
|
p.Steps = append(p.Steps, fmt.Sprintf("%s keeps data (ADR 0233): what it holds is backed up before it moves", name))
|
|
}
|
|
}
|
|
}
|
|
var names []string
|
|
for name := range machines {
|
|
names = append(names, name)
|
|
}
|
|
sort.Strings(names)
|
|
for _, name := range names {
|
|
p.Machines = append(p.Machines, *machines[name])
|
|
}
|
|
p.Summary = summaryOf(p)
|
|
return p
|
|
}
|
|
|
|
// summaryOf is a change plan in one line: what it builds, where it goes, and whether the bus moves.
|
|
func summaryOf(p link.ChangePlan) string {
|
|
if len(p.Moved) == 0 && len(p.New) == 0 {
|
|
return "builds nothing: the change touches no module of the mesh's graph"
|
|
}
|
|
var parts []string
|
|
what := strings.Join(p.Moved, ", ")
|
|
if len(p.Dependents) > 0 {
|
|
what += fmt.Sprintf(" (+%d dependent(s))", len(p.Dependents))
|
|
}
|
|
if len(p.New) > 0 {
|
|
if what != "" {
|
|
what += ", "
|
|
}
|
|
what += "new: " + strings.Join(p.New, ", ")
|
|
}
|
|
var to []string
|
|
for _, m := range p.Machines {
|
|
if len(m.Receives) > 0 {
|
|
to = append(to, m.Machine)
|
|
}
|
|
}
|
|
if len(to) > 0 {
|
|
parts = append(parts, "builds "+what+" → "+strings.Join(to, ", "))
|
|
} else {
|
|
parts = append(parts, "builds "+what+", sent nowhere")
|
|
}
|
|
bus := "no bus step"
|
|
for _, s := range p.Steps {
|
|
if strings.HasPrefix(s, "a planned bus step") {
|
|
bus = "a bus step"
|
|
}
|
|
}
|
|
parts = append(parts, bus)
|
|
waiting := 0
|
|
for _, m := range p.Machines {
|
|
waiting += len(m.Waits)
|
|
}
|
|
if waiting > 0 {
|
|
parts = append(parts, fmt.Sprintf("%d wait(s) for a person", waiting))
|
|
}
|
|
return strings.Join(parts, "; ")
|
|
}
|
|
|
|
// planText is a change plan as a person reads it, for the pull request's comment.
|
|
func planText(p link.ChangePlan) string {
|
|
var b strings.Builder
|
|
fmt.Fprintf(&b, "change plan of %s at %.8s into %s: %s\n", p.Repository, p.Head, p.Base, p.Summary)
|
|
for i, tier := range p.Tiers {
|
|
fmt.Fprintf(&b, " tier %d: %s\n", i, strings.Join(tier, ", "))
|
|
}
|
|
for _, m := range p.Machines {
|
|
line := " " + m.Machine + ": "
|
|
if len(m.Receives) > 0 {
|
|
line += "receives " + strings.Join(m.Receives, ", ")
|
|
}
|
|
if len(m.Waits) > 0 {
|
|
if len(m.Receives) > 0 {
|
|
line += "; "
|
|
}
|
|
line += "waits for a person: " + strings.Join(m.Waits, ", ")
|
|
}
|
|
b.WriteString(line + "\n")
|
|
}
|
|
for _, s := range p.Steps {
|
|
b.WriteString(" - " + s + "\n")
|
|
}
|
|
if len(p.Unread) > 0 {
|
|
fmt.Fprintf(&b, " read by no module's build: %s\n", strings.Join(p.Unread, ", "))
|
|
}
|
|
return b.String()
|
|
}
|