mesh/merge-gate pass: builds build-agent, mesh-controller, route-proxy → ace, g14, novox, shanks; no bus step; every machine composes with the change as it…
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
mesh/delivery-group group feat/no-change-takes-effect-unseen delivered: every member is delivered
Two incidents had one shape: a change took effect that nobody saw first (hq issues 241, 304). Three guards, each silent when nothing is at stake: - settings show [--history], and a set that answers each key it adds, changes and removes, and refuses a removal unless --replace; the replaced or cleared layer is kept in settings_history, in the same transaction as the write (migration 0078). - every send keeps a summary of what it sent (no file content), plan <node> --diff compares with it, and push with no machine is refused unless --all. - a push that would give a running container's mount another host directory holds that machine, naming the module, mount and both directories, until push <node> --move <module>; a named push's cascade is held the same way. Rebased onto main and fitted to it: the hold runs before the push says what it recreates, a whole push still says so first and leaves machines waiting for a gate, the verb's push with no machine is still --behind and a push still needs why. The verbs take plan diff, settings replace and history, and push move beside a machine, each refused where it cannot take effect.
116 lines
3.8 KiB
Go
116 lines
3.8 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/novox/mesh-controller/internal/link"
|
|
)
|
|
|
|
// A declaration carries the lease's epoch (novox/hq to-be 45 §6) — to a machine whose node-engine said
|
|
// it reads one, and to no other: an older node-engine refuses a key it does not know, whole.
|
|
|
|
// bodiesDelivery records each send as the mesh does, and keeps the bodies.
|
|
type bodiesDelivery struct {
|
|
recordedDelivery
|
|
bodies map[string][]byte
|
|
}
|
|
|
|
func (b *bodiesDelivery) declare(ctx context.Context, s readyNode, body []byte) (string, error) {
|
|
b.bodies[s.node] = body
|
|
return b.recordedDelivery.declare(ctx, s, body)
|
|
}
|
|
|
|
func TestAMachineIsSentTheEpochOnlyOnceItSaysItReadsOne(t *testing.T) {
|
|
open := aMesh(t)
|
|
ctx := t.Context()
|
|
inv := open.inventory
|
|
epoch := uint64(57)
|
|
was := epochForActs
|
|
epochForActs = func(context.Context) (uint64, error) { return epoch, nil }
|
|
t.Cleanup(func() { epochForActs = was })
|
|
|
|
anchor, err := inv.NodeByName(ctx, "anchor")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := inv.RecordReadsEpoch(ctx, anchor.ID, true); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
gens, err := generators(ctx, open)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
d := &bodiesDelivery{recordedDelivery: recordedDelivery{inv: inv}, bodies: map[string][]byte{}}
|
|
if _, err := sendRound(ctx, open, []string{"anchor", "laptop"}, composeForPush(open, gens), d, "", nil); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
carried := func(node string) (epoch float64, has bool) {
|
|
var envelope map[string]any
|
|
if err := json.Unmarshal(d.bodies[node], &envelope); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
epoch, has = envelope["epoch"].(float64)
|
|
return epoch, has
|
|
}
|
|
if e, has := carried("anchor"); !has || e != 57 {
|
|
t.Fatalf("the machine that reads an epoch was sent %v: %s", e, d.bodies["anchor"])
|
|
}
|
|
if _, has := carried("laptop"); has {
|
|
t.Fatalf("a machine that never said it reads an epoch was sent one: %s", d.bodies["laptop"])
|
|
}
|
|
|
|
// A new holder of the lease is not a change of the machine: neither reads as behind.
|
|
epoch = 58
|
|
would, err := wouldSend(ctx, open, mustNodes(t, open))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
for _, node := range []string{"anchor", "laptop"} {
|
|
sent, err := inv.Outstanding(ctx, node)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if would[node] != sent {
|
|
t.Fatalf("%s reads as behind after the lease changed hands, with nothing else changed", node)
|
|
}
|
|
}
|
|
}
|
|
|
|
// A process that may not act composes nothing and sends nothing: its number is not taken.
|
|
func TestNothingIsComposedOrSentWithoutTheLease(t *testing.T) {
|
|
open := aMesh(t)
|
|
ctx := t.Context()
|
|
was := epochForActs
|
|
epochForActs = func(context.Context) (uint64, error) { return 0, errors.New("this controller lost the lease") }
|
|
t.Cleanup(func() { epochForActs = was })
|
|
gens, err := generators(ctx, open)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
d := &bodiesDelivery{recordedDelivery: recordedDelivery{inv: open.inventory}, bodies: map[string][]byte{}}
|
|
refused, err := sendRound(ctx, open, []string{"anchor"}, composeForPush(open, gens), d, "", nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(d.bodies) != 0 || len(refused) != 1 || !strings.Contains(refused[0], "lost the lease") {
|
|
t.Fatalf("a controller without the lease composed %d and refused %v", len(d.bodies), refused)
|
|
}
|
|
anchor, _ := open.inventory.NodeByName(ctx, "anchor")
|
|
if seq, _ := open.inventory.Sequence(ctx, anchor.ID); seq != 0 {
|
|
t.Fatalf("a controller without the lease took sequence %d", seq)
|
|
}
|
|
|
|
// And at the send itself: the gate every declaration passes.
|
|
gate := link.ActingGate
|
|
link.ActingGate = func(context.Context) error { return errors.New("this controller lost the lease") }
|
|
t.Cleanup(func() { link.ActingGate = gate })
|
|
if err := link.Declare(ctx, nil, nil, "anchor", []byte(`{"declaration":1}`), 0); err == nil ||
|
|
!strings.Contains(err.Error(), "lost the lease") {
|
|
t.Fatalf("a declaration was let through the gate: %v", err)
|
|
}
|
|
}
|