jschoubben
d25b69178b
ADR 0214 / to-be 43: a node seat whose holder keeps nightly restore points of what every module on the machine declares. A contribution of kind backup may name its module's own directories, filled per module when placed. The catalogue check refuses a store provider that contributes no backup; parsing does not, so the providers already running stay readable.
73 lines
3.1 KiB
Go
73 lines
3.1 KiB
Go
package catalogue
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// A store provider says how its data is backed up (novox/hq ADR 0214); a provider of something that
|
|
// holds nothing does not have to.
|
|
func TestAStoreProviderWithoutABackupIsRefusedByTheCheck(t *testing.T) {
|
|
bare, err := ParseManifest([]byte(`{"module":"pg","version":"1",
|
|
"provides":[{"name":"postgres-database","scope":"mesh"}]}`))
|
|
if err != nil {
|
|
t.Fatalf("parsing refused it, and the rule is the check's: %v", err)
|
|
}
|
|
if problems := CheckBackup(bare); len(problems) != 1 || !strings.Contains(problems[0], "node-backup") {
|
|
t.Fatalf("a store with no backup passed the check: %v", problems)
|
|
}
|
|
backed, err := ParseManifest([]byte(`{"module":"pg","version":"1",
|
|
"provides":[{"name":"postgres-database","scope":"mesh"}],
|
|
"resources":[{"id":"dumps","type":"directory","mode":"0700"}],
|
|
"contributions":[{"seat":"node-backup","kind":"backup","content":"path ${dir:dumps}"}]}`))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if problems := CheckBackup(backed); len(problems) != 0 {
|
|
t.Fatalf("a store that contributes a backup was refused: %v", problems)
|
|
}
|
|
route, _ := ParseManifest([]byte(`{"module":"r","version":"1","provides":[{"name":"route","scope":"mesh"}]}`))
|
|
if problems := CheckBackup(route); len(problems) != 0 {
|
|
t.Fatalf("a route was asked for a backup: %v", problems)
|
|
}
|
|
}
|
|
|
|
// A backup contribution names its module's own directories; one it does not declare is refused
|
|
// where it is written rather than reaching the holder as the literal text.
|
|
func TestABackupNamingAnUndeclaredDirectoryIsRefused(t *testing.T) {
|
|
_, err := ParseManifest([]byte(`{"module":"pg","version":"1",
|
|
"contributions":[{"seat":"node-backup","kind":"backup","content":"path ${dir:nowhere}"}]}`))
|
|
if err == nil || !strings.Contains(err.Error(), "nowhere") {
|
|
t.Fatalf("a backup of an undeclared directory was accepted: %v", err)
|
|
}
|
|
}
|
|
|
|
// The holder receives every module's backup lines with each module's own directories filled, each
|
|
// module's under a comment naming it — and a kind written in a shell's grammar is left untouched.
|
|
func TestBackupContributionsArePlacedWithTheirModulesDirectories(t *testing.T) {
|
|
pg, err := ParseManifest([]byte(`{"module":"pg","version":"1",
|
|
"resources":[{"id":"dumps","type":"directory","path":"/srv/pg/dumps","mode":"0700"}],
|
|
"contributions":[{"seat":"node-backup","kind":"backup","content":"run pg-dump-all\npath ${dir:dumps}"}]}`))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
mail, err := ParseManifest([]byte(`{"module":"mail","version":"1",
|
|
"resources":[{"id":"spool","type":"directory","mode":"0700"}],
|
|
"contributions":[{"seat":"node-backup","kind":"backup","content":"path ${dir:spool}"}]}`))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
placed, err := seatContributions([]Manifest{pg, mail}, BackupSeat, "backup", Rendering{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
for _, want := range []string{"# pg\nrun pg-dump-all\npath /srv/pg/dumps\n", "# mail\npath /var/lib/mail/spool\n"} {
|
|
if !strings.Contains(placed, want) {
|
|
t.Errorf("placed contributions lack %q:\n%s", want, placed)
|
|
}
|
|
}
|
|
if strings.Contains(placed, "${dir:") {
|
|
t.Errorf("a directory reached the holder unfilled:\n%s", placed)
|
|
}
|
|
}
|