jschoubben
e419d0182f
The controller asks no build of anybody (ADR 0501 §5, ADR 0525 clause 6, ADR 0503 §3). Every module of a walk is taken from the builder's done key; a key not done yet waits, named in the plan, and never fails it. - C2b/C2c: internal/builder and cmd/mesh-controller's asks go (askABuild, onlyTheBuildersOwn, buildOneAsked, takeIn from an outcome, buildAgentsOwn, the builder's say and its fallback, the daemon hearing an outcome). The server follows the retired seats' built subjects only to let go of them, because the installer's carried user list names them. - C2d: replay, queue, cancel, clear, kill, pause, resume, delivery-check, check-here and merge-gate are refused by name. - C3: the check queues (CHECKS_READY, CHECKS_OTHER) and their workers, the checks-running and plans-building buckets and their grants, the build queue and its hold (plans_building.go, queue.go, link/holds.go, builds_nats.go, checks_nats.go). - C4: merge_gate*.go, the pull request's repo-check path, the Checked event and its layers; a pull request asks the controller nothing but to tell mesh-config what its head declares. - C5: the builds bucket is written only by key_takein. - C10 (help and refusals): the terminal's help lists only what is served. Integration tests of the plan's tiers, sends, stops and retries now run on a stand-in builder with a done key for every module (walk_keys_scaffold_integration_test.go); the tests of the asks, the queue, the merge gate and the replays are deleted.
76 lines
3.2 KiB
Go
76 lines
3.2 KiB
Go
package main
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"git.novox.be/novox/mesh-sdk/go/catalogue"
|
|
"github.com/novox/mesh-controller/internal/inventory"
|
|
"github.com/novox/mesh-controller/internal/link"
|
|
)
|
|
|
|
// **One commit, one change plan** (novox/hq ADR 0238): the planner's reach, laid out machine by machine in
|
|
// the build plan's order, with what is not an ordinary send said — the bus step, a module that waits for a
|
|
// person, a provider whose consumers follow it.
|
|
func TestAChangePlanSaysWhatEachMachineReceives(t *testing.T) {
|
|
const catalogue_ = "http://forge.internal:20000/novox/mesh-catalog.git"
|
|
entry := func(name, path string, on ...string) inventory.Entry {
|
|
e := fromRepo(name, catalogue_, path)
|
|
e.Source.BuiltFrom = "old"
|
|
e.On = on
|
|
return e
|
|
}
|
|
nats := entry("nats", "modules/nats", "anchor")
|
|
nats.Manifest.Provides = []catalogue.Offer{{Name: "mesh-bus"}}
|
|
gitea := entry("gitea", "modules/gitea", "anchor")
|
|
held := entry("photos", "modules/photos", "anchor", "laptop")
|
|
tools := fromRepo("node-tools", "http://forge.internal:20000/novox/mesh-tools.git", "node-tools")
|
|
tools.On = []string{"anchor", "laptop"}
|
|
entries := []inventory.Entry{nats, gitea, held, tools}
|
|
edges := []inventory.Edge{{From: "node-tools", To: "nats", Kind: inventory.EdgeStandsOn}}
|
|
policy := func(module string) (inventory.Upgrade, bool) {
|
|
if module == "photos" {
|
|
return inventory.Upgrade{RollOut: false, From: "a person"}, true
|
|
}
|
|
return inventory.Upgrade{RollOut: true}, true
|
|
}
|
|
plan := func(paths ...string) link.ChangePlan {
|
|
m := link.SourceMoved{Owner: "novox", Repo: "mesh-catalog", Base: "main", Commit: "head", Paths: paths}
|
|
return changePlanOf("novox/mesh-catalog", "main", "head", reachOfMerge(m, entries, nil, edges), entries, policy)
|
|
}
|
|
|
|
p := plan("modules/gitea/index.ts")
|
|
if p.Summary != "builds gitea → anchor; no bus step" {
|
|
t.Errorf("one module's change reads %q", p.Summary)
|
|
}
|
|
|
|
p = plan("modules/nats/Dockerfile", "modules/photos/x.js")
|
|
if !strings.Contains(p.Summary, "needs a person's bus upgrade") || !strings.Contains(p.Summary, "2 wait(s) for a person") ||
|
|
!strings.Contains(p.Summary, "(+1 dependent(s))") {
|
|
t.Errorf("the bus and a held module read %q", p.Summary)
|
|
}
|
|
got := map[string]string{}
|
|
for _, m := range p.Machines {
|
|
got[m.Machine] = strings.Join(m.Receives, ",") + "|" + strings.Join(m.Waits, ",")
|
|
}
|
|
// The bus first, what stands on it after: the build plan's order, per machine.
|
|
if got["anchor"] != "nats,node-tools|photos" || got["laptop"] != "node-tools|photos" {
|
|
t.Errorf("the deploy plan reads %v", got)
|
|
}
|
|
text := strings.Join(p.Steps, "\n")
|
|
// Said before the merge (novox/hq issue 336): merging it holds every send to the bus's machine until a
|
|
// person runs the bus's step, and the verb that does.
|
|
for _, want := range []string{"merging this needs a person's bus upgrade", "nothing else is sent to anchor",
|
|
"mesh_call mesh-controller.bus", "the same as the one running there", "photos waits for a person",
|
|
"nats provides mesh-bus"} {
|
|
if !strings.Contains(text, want) {
|
|
t.Errorf("the steps do not say %q:\n%s", want, text)
|
|
}
|
|
}
|
|
|
|
p = plan("merge-check.sh")
|
|
if !strings.HasPrefix(p.Summary, "builds nothing") || len(p.Machines) != 0 || strings.Join(p.Unread, ",") != "merge-check.sh" {
|
|
t.Errorf("a root file's plan reads %+v", p)
|
|
}
|
|
}
|