jschoubben
e419d0182f
The controller asks no build of anybody (ADR 0501 §5, ADR 0525 clause 6, ADR 0503 §3). Every module of a walk is taken from the builder's done key; a key not done yet waits, named in the plan, and never fails it. - C2b/C2c: internal/builder and cmd/mesh-controller's asks go (askABuild, onlyTheBuildersOwn, buildOneAsked, takeIn from an outcome, buildAgentsOwn, the builder's say and its fallback, the daemon hearing an outcome). The server follows the retired seats' built subjects only to let go of them, because the installer's carried user list names them. - C2d: replay, queue, cancel, clear, kill, pause, resume, delivery-check, check-here and merge-gate are refused by name. - C3: the check queues (CHECKS_READY, CHECKS_OTHER) and their workers, the checks-running and plans-building buckets and their grants, the build queue and its hold (plans_building.go, queue.go, link/holds.go, builds_nats.go, checks_nats.go). - C4: merge_gate*.go, the pull request's repo-check path, the Checked event and its layers; a pull request asks the controller nothing but to tell mesh-config what its head declares. - C5: the builds bucket is written only by key_takein. - C10 (help and refusals): the terminal's help lists only what is served. Integration tests of the plan's tiers, sends, stops and retries now run on a stand-in builder with a done key for every module (walk_keys_scaffold_integration_test.go); the tests of the asks, the queue, the merge gate and the replays are deleted.
35 lines
1.2 KiB
Go
35 lines
1.2 KiB
Go
package broker
|
|
|
|
import (
|
|
"slices"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// R4g (issue 1299, ADR 0525 clause 6): the controller declares no work-queue stream for builds or checks and no
|
|
// plans-building or checks-running bucket. The streams and buckets a bus already holds are left until a cleanup; none
|
|
// is asserted.
|
|
func TestTheControllerDeclaresNoBuildQueueAndNoBuildHold(t *testing.T) {
|
|
for _, s := range MeshStreams() {
|
|
if strings.HasPrefix(s.Name, "CHECKS_") || strings.HasPrefix(s.Name, "SEAT_") {
|
|
t.Errorf("the mesh's own streams hold %s, a queue of builds or checks", s.Name)
|
|
}
|
|
if s.Retention == RetentionWorkQueue && s.Name != "CONTROL" && s.Name != DeadLetterNoticesStream {
|
|
t.Errorf("%s is a work queue the controller declares", s.Name)
|
|
}
|
|
}
|
|
for _, c := range MeshConsumers() {
|
|
if strings.HasSuffix(c.Name, "_worker") {
|
|
t.Errorf("%s is a worker of a build or check queue", c.Name)
|
|
}
|
|
}
|
|
for _, name := range ControllerBuckets() {
|
|
if strings.Contains(name, "plans-building") || strings.Contains(name, "checks-running") {
|
|
t.Errorf("the controller's buckets hold %s", name)
|
|
}
|
|
}
|
|
if slices.Contains(ControllerBuckets(), "") {
|
|
t.Error("an unnamed bucket")
|
|
}
|
|
}
|