From 008a85b73c014526afa5784d22da8b1ed59e98b7 Mon Sep 17 00:00:00 2001 From: jochen Date: Mon, 2 Nov 2026 19:23:17 +0100 Subject: [PATCH] mesh-delivery-indexer: the judge's tests ask nothing of the composition's offers, overflow or left-out reasons MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ADR 0593 §7: OffersIssuedOutside, Resolution and UnknownFieldReason left mesh-sdk with the composition, so the judge's tests keep its own reading and refusals and those proofs go to the node-engine's tests. Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL --- modules/mesh-delivery-indexer/judge/rules_test.go | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/modules/mesh-delivery-indexer/judge/rules_test.go b/modules/mesh-delivery-indexer/judge/rules_test.go index 0184121..de8ecff 100644 --- a/modules/mesh-delivery-indexer/judge/rules_test.go +++ b/modules/mesh-delivery-indexer/judge/rules_test.go @@ -1870,9 +1870,6 @@ func TestAnOfferMaySayAPersonOutsideTheMeshIssuesItsCredential(t *testing.T) { if _, shared := m.SharedCredentialOf("tv-api"); shared { t.Fatal("a credential issued outside was read as an own secret shared") } - if who, offered := catalogue.OffersIssuedOutside(map[string]catalogue.Manifest{"tv": m}, "tv-api"); !offered || who != "tv" { - t.Fatalf("the catalogue does not say tv offers tv-api issued outside: %q %v", who, offered) - } for want, raw := range map[string]string{ "names its own secret": `{"module":"d","version":"1","own-secrets":{"key":{"path":"/p","taken":"at-start"}}, @@ -2612,12 +2609,7 @@ func TestARequirementOnAKeylessProvisionComposesWithALongName(t *testing.T) { if got := IdentityProblems(shelf, 6); len(got) != 0 { t.Fatalf("a requirement on a keyless provision was refused for its length: %q", got) } - r := catalogue.Resolution{Node: "laptop", Modules: []catalogue.Manifest{shelf["networkmanager"]}, - Needs: []catalogue.Needed{{Name: "wildcard-resolution", From: "anchor", For: "networkmanager", - Identity: shelf["resolver"].IdentityBoundOf("wildcard-resolution")}}} - if got := r.Overflowing(); len(got) != 0 { - t.Fatalf("a keyless requirement is reported as overflowing: %+v", got) - } + // Whether the composed requirement overflows on the machine is the node-engine's composition to say (ADR 0593 §7). } // A resolved manifest keeps a built artifact's reference in the store-relative form, never the @@ -5739,9 +5731,6 @@ func aModuleWithAFieldSetAsideStillProvidesWhatItProvides(t *testing.T) { t.Errorf("unknown %q does not say it read without %s", m.UnknownField(), want) } } - if why := catalogue.UnknownFieldReason(m); why != "" { - t.Fatal(why) - } } func notifier() catalogue.Manifest {