novox/mesh-delivery
19
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request 'mesh-delivery-checker: leave compose-candidate out of its invokes until the new indexer runs' (#142) from fix/checker-invoke-later into main

Browse Source
This commit was merged in pull request #142.
This commit is contained in:
mesh-tools
2026-11-02 21:55:29 +00:00
parent 073e3fab65 22f3658a36
commit 15d28ddf5b
2 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/mesh-delivery-checker/manifest_test.go
+7 -5
View File
@@ -111,11 +111,13 @@ func TestManifestDeclarations(t *testing.T) { // 1678/AC1
} }
// 1887/A5b: the checker reads nothing of the controller's plans-building (ADR 0483 superseded by ADR 0525 §7), calls no // 1887/A5b: the checker reads nothing of the controller's plans-building (ADR 0483 superseded by ADR 0525 §7), calls no
// build module's tool and holds no capacity: it puts check asks on the Go and Node build seats (ADR 0525 §1, §4). // build module's tool and holds no capacity: it puts check asks on the Go and Node build seats (ADR 0525 §1, §4).
// The forge's reads for a mesh-sdk pin (ADR 0484 clause 9), and of the node seat node-engine its one verb // The forge's reads for a mesh-sdk pin (ADR 0484 clause 9). Not yet the node seat node-engine's compose-candidate
// compose-candidate, asked of every placed node (ADR 0593 §7), never the seat's other verbs. // (ADR 0593 §7): the indexer that runs while this delivers was built before the verb existed and refuses a manifest
if want := []string{"gitea.gitea_commits", "gitea.gitea_compare", "gitea.gitea_get_file", "gitea.gitea_list_branches", // invoking it, which held the grants part's whole list (issue 1126, 2026-11-02); a follow-up adds it back once the
"seat:node-engine.compose-candidate"}; !reflect.DeepEqual(sorted(m.Invokes), want) { // new indexer runs.
t.Errorf("invokes = %v, want the forge's reads and compose-candidate", m.Invokes) if want := []string{"gitea.gitea_commits", "gitea.gitea_compare", "gitea.gitea_get_file",
"gitea.gitea_list_branches"}; !reflect.DeepEqual(sorted(m.Invokes), want) {
t.Errorf("invokes = %v, want the forge's reads", m.Invokes)
} }
if want := []string{"node-build-go", "node-build-node"}; !reflect.DeepEqual(sorted(m.Uses), want) { if want := []string{"node-build-go", "node-build-node"}; !reflect.DeepEqual(sorted(m.Uses), want) {
t.Errorf("uses = %v, want the Go and Node build seats", m.Uses) t.Errorf("uses = %v, want the Go and Node build seats", m.Uses)
modules/mesh-delivery-checker/module.json
+1 -2
View File
@@ -65,8 +65,7 @@
"gitea.gitea_commits", "gitea.gitea_commits",
"gitea.gitea_compare", "gitea.gitea_compare",
"gitea.gitea_get_file", "gitea.gitea_get_file",
"gitea.gitea_list_branches", "gitea.gitea_list_branches"
"seat:node-engine.compose-candidate"
], ],
"own-secrets": { "own-secrets": {