From 16950758368774f485d2c4988ae83209a0cec5d7 Mon Sep 17 00:00:00 2001 From: jochen Date: Sat, 14 Nov 2026 17:13:11 +0100 Subject: [PATCH] Indexer: a seed's registration write ends no proposal key (an empty key stopped the seed after its first module); the history fill is read within a second and its failure said --- .../cmd/mesh-delivery-indexer/registry.go | 13 ++++++++++--- .../internal/index/registrations.go | 3 +++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/modules/mesh-delivery-indexer/cmd/mesh-delivery-indexer/registry.go b/modules/mesh-delivery-indexer/cmd/mesh-delivery-indexer/registry.go index f38d322d..4ab8eb42 100644 --- a/modules/mesh-delivery-indexer/cmd/mesh-delivery-indexer/registry.go +++ b/modules/mesh-delivery-indexer/cmd/mesh-delivery-indexer/registry.go @@ -59,12 +59,19 @@ func newRegistry(js jetstream.JetStream, conn *nats.Conn, cred process.Account, } _, err = js.Publish(ctx, historySubject(cred.Module, r.Module), data, jetstream.WithMsgID(fmt.Sprintf("%s.%d", r.Module, r.Version))) if err == nil { - // Past 80 % full the stream's fill is a finding (design 47 G §704). - if st, serr := js.Stream(ctx, catalogue.StreamBusName(index.RegistrationHistoryStream)); serr == nil { - if info, ierr := st.Info(ctx); ierr == nil { + // Past 80 % full the stream's fill is a finding (design 47 G §704); read within a second, and said when it cannot be. + fctx, cancel := context.WithTimeout(ctx, time.Second) + st, serr := js.Stream(fctx, catalogue.StreamBusName(index.RegistrationHistoryStream)) + if serr == nil { + var info *jetstream.StreamInfo + if info, serr = st.Info(fctx); serr == nil { ix.HistoryFill(ctx, int64(info.State.Bytes), info.Config.MaxBytes) } } + cancel() + if serr != nil { + logf("the fill of %s is not read, so its finding is not judged: %v", index.RegistrationHistoryStream, serr) + } } return err }, diff --git a/modules/mesh-delivery-indexer/internal/index/registrations.go b/modules/mesh-delivery-indexer/internal/index/registrations.go index 3b72ef20..2793e6b2 100644 --- a/modules/mesh-delivery-indexer/internal/index/registrations.go +++ b/modules/mesh-delivery-indexer/internal/index/registrations.go @@ -838,6 +838,9 @@ func (r *Registry) write(ctx context.Context, key string, p Proposal, next meshc r.logf("the builds of %s on the branches it no longer watches are not pruned: %v", next.Module, err) } } + if key == "" { + return nil // a write of the seed's: no proposal key of its own to end + } return r.endKey(ctx, key, p, ProposalApplied, fmt.Sprintf("applied as version %d of %s on %s", next.Version, next.Module, occ.Says(w))) }