From 1db38fcc720175be0812cf51188b55e31eca178c Mon Sep 17 00:00:00 2001 From: jochen Date: Fri, 20 Nov 2026 21:05:39 +0100 Subject: [PATCH] Declare asks in the assigner's version series, and have the teller and the view accept it there (H-A-188) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The builder numbers every artifact of a release in its module's version, so the assigner's package asks is published in 0.3, not the 0.1 eba4309b declared: asks now names series 0.3, and the teller and the view, which import it, accept it at 0.3 in their manifests' packages. The other eight packages' modules are all at 0.1, so their series stand. The gate in mesh-catalog, which imports asks too, follows with the catalog's next change. Builds: design 47 G §370, H-A-186, H-A-188 --- modules/mesh-delivery-assigner/manifest_test.go | 6 +++--- modules/mesh-delivery-assigner/module.json | 2 +- modules/mesh-delivery-teller/manifest_test.go | 5 +++++ modules/mesh-delivery-teller/module.json | 3 +++ modules/mesh-delivery-view/manifest_test.go | 5 +++++ modules/mesh-delivery-view/module.json | 3 +++ 6 files changed, 20 insertions(+), 4 deletions(-) diff --git a/modules/mesh-delivery-assigner/manifest_test.go b/modules/mesh-delivery-assigner/manifest_test.go index 993f5206..8a3db0c2 100644 --- a/modules/mesh-delivery-assigner/manifest_test.go +++ b/modules/mesh-delivery-assigner/manifest_test.go @@ -120,11 +120,11 @@ func TestManifest(t *testing.T) { } } // H-A-186 (design 47 G §370): asks, which the gate, the teller and the view import, is a declared Go package of the - // module, so every release publishes it. + // module, so every release publishes it; H-A-188: in the module's version series, 0.3. if !slices.ContainsFunc(m.Build.Artifacts, func(a catalogue.Artifact) bool { - return a.Name == "asks" && a.Kind == catalogue.ArtifactPackage && a.Language == "go" && slices.Equal(a.Paths, []string{"asks"}) && a.Series == "0.1" + return a.Name == "asks" && a.Kind == catalogue.ArtifactPackage && a.Language == "go" && slices.Equal(a.Paths, []string{"asks"}) && a.Series == m.Version && m.Version == "0.3" }) { - t.Errorf("artifacts = %+v, want the Go package asks of series 0.1", m.Build.Artifacts) + t.Errorf("artifacts = %+v, want the Go package asks of series 0.3, the module's", m.Build.Artifacts) } // ADR 0635 §5: its views family is its ordinary events, `views.` among its emits, on no stream of its own. // The seat's four events are said on the seat's own subject (the seat's family), so the module keeps no stream for them diff --git a/modules/mesh-delivery-assigner/module.json b/modules/mesh-delivery-assigner/module.json index 659044dc..32979138 100644 --- a/modules/mesh-delivery-assigner/module.json +++ b/modules/mesh-delivery-assigner/module.json @@ -378,7 +378,7 @@ "paths": [ "asks" ], - "series": "0.1" + "series": "0.3" } ] } diff --git a/modules/mesh-delivery-teller/manifest_test.go b/modules/mesh-delivery-teller/manifest_test.go index e031746f..dcb8d85b 100644 --- a/modules/mesh-delivery-teller/manifest_test.go +++ b/modules/mesh-delivery-teller/manifest_test.go @@ -43,6 +43,7 @@ type artifact struct { } type manifest struct { + Packages map[string]string `json:"packages"` Module string `json:"module"` Version string `json:"version"` Slug string `json:"slug"` @@ -181,6 +182,10 @@ func TestManifestProcess(t *testing.T) { // 1240/AC1 if len(m.Build.Artifacts) != 3 { t.Fatalf("artifacts = %+v, want the program, the tools and the package tellerevents", m.Build.Artifacts) } + // H-A-188: the assigner is at 0.3, so its package asks, which this module imports, is accepted in that series. + if got := m.Packages["git.novox.be/novox/mesh-delivery/modules/mesh-delivery-assigner/asks"]; got != "0.3" || len(m.Packages) != 1 { + t.Errorf("packages = %v, want asks accepted in the assigner's series 0.3", m.Packages) + } // H-A-186 (design 47 G §370): tellerevents, which the assigner imports, is a declared package. if a := m.Build.Artifacts[2]; a.Name != "tellerevents" || a.Kind != "package" || a.Language != "go" || !reflect.DeepEqual(a.Paths, []string{"tellerevents"}) || a.Series != "0.1" { t.Errorf("package artifact = %+v", a) diff --git a/modules/mesh-delivery-teller/module.json b/modules/mesh-delivery-teller/module.json index 25e7581b..b993a061 100644 --- a/modules/mesh-delivery-teller/module.json +++ b/modules/mesh-delivery-teller/module.json @@ -1,6 +1,9 @@ { "module": "mesh-delivery-teller", "version": "0.1", + "packages": { + "git.novox.be/novox/mesh-delivery/modules/mesh-delivery-assigner/asks": "0.3" + }, "slug": "teller", "tools": [ "teller_end_ask", diff --git a/modules/mesh-delivery-view/manifest_test.go b/modules/mesh-delivery-view/manifest_test.go index 797882fe..e473d9a0 100644 --- a/modules/mesh-delivery-view/manifest_test.go +++ b/modules/mesh-delivery-view/manifest_test.go @@ -70,6 +70,7 @@ type claim struct { } type manifest struct { + Packages map[string]string `json:"packages"` Claims []claim `json:"claims"` State []state `json:"state"` Module string `json:"module"` @@ -313,6 +314,10 @@ func TestManifestIsTakenAndReadsOnly(t *testing.T) { // 1134/AC7 func TestManifestIsWholeInItsRepository(t *testing.T) { // 1134/AC7 m, _ := load(t) + // H-A-188: the assigner is at 0.3, so its package asks, which this module imports, is accepted in that series. + if got := m.Packages["git.novox.be/novox/mesh-delivery/modules/mesh-delivery-assigner/asks"]; got != "0.3" || len(m.Packages) != 1 { + t.Errorf("packages = %v, want asks accepted in the assigner's series 0.3", m.Packages) + } // H-A-186 (design 47 G §370): viewstate, which the gate, the assigner and the teller import, is a declared package. if len(m.Build.Artifacts) != 5 || m.Build.Artifacts[4].Name != "viewstate" { t.Fatalf("artifacts = %+v", m.Build.Artifacts) diff --git a/modules/mesh-delivery-view/module.json b/modules/mesh-delivery-view/module.json index 4d0df481..b2deb116 100644 --- a/modules/mesh-delivery-view/module.json +++ b/modules/mesh-delivery-view/module.json @@ -1,6 +1,9 @@ { "module": "mesh-delivery-view", "version": "0.1", + "packages": { + "git.novox.be/novox/mesh-delivery/modules/mesh-delivery-assigner/asks": "0.3" + }, "moved": true, "slug": "view", "tools": [